[jboss-jira] [JBoss JIRA] Created: (JBID-228) FileBasedMetadataConfigurationStore.loadTrustedProviders keeps trustedFile locked for some indeterminate period

FileBasedMetadataConfigurationStore.loadTrustedProviders keeps trustedFile locked for some indeterminate period --------------------------------------------------------------------------------------------------------------- Key: JBID-228 URL: https://jira.jboss.org/jira/browse/JBID-228 Project: JBoss Identity Issue Type: Bug Components: Identity-Federation Environment: Windows XP SP3, JBoss 5.1.0.GA Reporter: Jaap Reitsma Assignee: Anil Saldhana In package org.jboss.identity.federation.core.saml.v2.metadata.store, class FileBasedMetadataConfigurationStore, the method.loadTrustedProviders() locks the trustedFile for a (short) indeterminate period, due to a missing ois.close() at the end of the method. In the unit test a failure will occur in FileBasedMetadataConfigurationStoreUnitTestCase.testTrustedProviders() due to a sharing violation (Windows) error, because it cannot delete a file which is held open, at least not in Windows. Solution: Close the stream explicitly instead of waiting for the garbage collector. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira