[jboss-jira] [JBoss JIRA] (WFLY-7537) Review NamingContext.check() method

Review NamingContext.check() method ----------------------------------- Key: WFLY-7537 URL: https://issues.jboss.org/browse/WFLY-7537 Project: WildFly Issue Type: Task Components: Naming Reporter: Darran Lofthouse Assignee: Farah Juma Fix For: 13.0.0.Beta1 The new naming client is sending in a SimpleName where the lookup was performed using a String. When a SecurityManager is installed the check() method of NamingContext is called and results in the following error: - {noformat} javax.naming.InvalidNameException: Not a composite name: jms at javax.naming.CompositeName.addAll(CompositeName.java:472) at org.jboss.as.naming.NamingContext.check(NamingContext.java:592) at org.jboss.as.naming.NamingContext.lookup(NamingContext.java:197) at org.jboss.as.naming.NamingContext.lookup(NamingContext.java:184) at org.jboss.naming.remote.protocol.v1.Protocol$1.handleServerMessage(Protocol.java:127) at org.jboss.naming.remote.protocol.v1.RemoteNamingServerV1$MessageReciever$1.run(RemoteNamingServerV1.java:73) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) {noformat} A fix has been applied to convert the incoming name to a CompositeName but as we deliberately have a SimpleName to avoid CompositeName I wonder if that is completely correct. Some other options I think of: - 1. Stick with current fix. 2 The client should convert to CompositeName before sending. 3. Manually iterate the segments if not a CompositeName 4. Check if the NamingStore really needs to use a CompositeName