[jboss-jira] [JBoss JIRA] Commented: (JBMESSAGING-1440) JTA-prepared message delivered to other consumer.
[
https://jira.jboss.org/jira/browse/JBMESSAGING-1440?page=com.atlassian.ji...
]
Howard Gao commented on JBMESSAGING-1440:
-----------------------------------------
Current Fix is:
1. Add a flag to SimpleDelivery:
private boolean xa;
public boolean isXA();
2. During Tx prepare time (or commit time for one-phase-commit), when the message ref is
being persisted into DB, the SimpleDelivery containing that ref will check the Tx, as
public void acknowledge(Transaction tx) throws Throwable
{
if (trace) { log.trace(this + " acknowledging delivery " + ( tx == null ?
"non-transactionally" : "in " + tx)); }
if (tx.getXid() != null)
{
xa = true;
}
else
{
xa = false;
}
}
3. After prepared, if connection failure happens the delivery will be cancelled, but if
the xa flag is true, the message ref will not be put back to the mem list for re-delivery.
The message ref will stay in DB together with the corresponding TX entry, waiting for the
recovery to be initiated by TM.
JTA-prepared message delivered to other consumer.
--------------------------------------------------
Key: JBMESSAGING-1440
URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1440
Project: JBoss Messaging
Issue Type: Bug
Environment: JBoss 4.2.2 + JBM 1.4.0.SP3. Windows XP.
Reporter: szhigunov
Assignee: Howard Gao
Fix For: 1.4.0.SP3.CP05, 1.4.2.GA
Attachments: myxatest.zip, myxatest1.zip
The problem is that when fully prepared tx1 fails in the commit phase, JBM delivers the
message second time in tx2, while tx1 is still in progress. Eventually recovery commits
tx1, so the message gets delivered and committed twice.
The attached test (myxatest.zip) is a clean JBoss 4.2.2 + JBM 1.4.0 SP3 with my test
MBean: jboss-4.2.2.GA\server\messaging\lib\myxatest.jar (code and source) +
jboss-4.2.2.GA\server\messaging\deploy\myxatest-service.xml.
Steps to reproduce the problem:
1. Start the server.
2. Go to JMX console + myxatest + service=Test. Invoke send.
3. Go to JMX console + jboss.messaging.destination + name=A.service=Queue. Verify
MessageCount=1.
4. Go to JMX console + myxatest + service=Test. Invoke receive. That will start XA
transaction; enlist DummyXAResource; get JMS connection from JCA and receive message.
DummyXAResource sleeps 60 sec inside the commit call.
5. Verify that DummyXAResource prints "DummyXAResource commit start sleeping for 60
sec" message.
6. Go to JMX console + jboss.jca + name=JmsXA,service=ManagedConnectionPool and invoke
stop(). Check that DummyXAResource finished commit and printed "DummyXAResource
commit end" message. JBM commit fails.
7. Now we have fully prepared JBM transaction in progress. You can see one record in
JBM_TX.
8. Go to JMX console + jboss.jca + name=JmsXA,service=ManagedConnectionPool and invoke
start().
9. Go to JMX console + myxatest + service=Test. Invoke receive again. Same message
delivered again. And this is wrong. Wait for a minute and let transaction finish
successfully.
10. Got to JBM_TX and verify that transaction is still there (nobody recovered it!).
11. Stop server, enable JBM recovery, start server. In couple minutes the original
transaction is found and committed (second time). JBM_TX is empty.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira