[jboss-jira] [JBoss JIRA] Updated: (JGRP-721) timtout and num_ping_requests effectively hardcoded in Discovery.java

timtout and num_ping_requests effectively hardcoded in Discovery.java --------------------------------------------------------------------- Key: JGRP-721 URL: http://jira.jboss.com/jira/browse/JGRP-721 Project: JGroups Issue Type: Bug Reporter: Michael Newcomb Assigned To: Bela Ban Priority: Minor Fix For: 2.7, 2.6.3 Original Estimate: 1 minute Remaining Estimate: 1 minute int num_ping_requests=2; int num_discovery_requests=0; private final Set<Responses> ping_responses=new HashSet<Responses>(); private final PingSenderTask sender=new PingSenderTask(timeout, num_ping_requests); num_ping_requests and timeout are used at construction time to create the PingSenderTask (which is final). The PingSenderTask uses the num_ping_requests and timeout to determine the send interval. Since the PingSenderTask doesn't ever recheck these values (it always uses the calculated interval) there is no effect upon changing these values... There will always only be 2 ping requests, 1 at +0ms and the other at +1500ms. It is further complicated by the fact that timeout is used in the waiting process, so if timeout < 3000ms, you run the risk of missing your second discovery response all together. Recommend calculating the interval with every call to PingSenderTask.start().