[jboss-jira] [JBoss JIRA] (WFLY-5584) Remove and deprecate profile concept for data-sources
[
https://issues.jboss.org/browse/WFLY-5584?page=com.atlassian.jira.plugin....
]
James Perkins commented on WFLY-5584:
-------------------------------------
The problem is it doesn't work with {{-ds.xml}} deployments that are not on the
{{default}} profile. With the shipped configurations there are no servers associated with
the {{default}} profile. {{server-one}} and {{server-two}} are on the {{full}} profile.
{{server-three}} is on the {{full-ha}} profile. So with the profile concept for
datasources during deployment of a {{-ds.xml}} {{null}} is always passed for the profile
which then uses the {{default}} profile which has no installed drivers since no servers
were started. Since no servers are started on the default profile there are no drivers
installed in the registry.
The web console no longer uses an approach where they execute the
{{installled-drivers-list}} operation. They now execute
{{/profile=some-profile/subsystem=datasources:read-children-resources(child-type=jdbc-driver)}}.
The {{installed-drivers-list}} is only registered on a host anyway making the profile
irrelevant.
In general though the subsystem shouldn't know or care about what profile it's
running on. The driver registry is only run on a server e.g. in the runtime stage of a OSH
or in a DUP. Having the driver registry have a concept of profiles just isn't needed.
Remove and deprecate profile concept for data-sources
-----------------------------------------------------
Key: WFLY-5584
URL: https://issues.jboss.org/browse/WFLY-5584
Project: WildFly
Issue Type: Bug
Components: JCA
Reporter: James Perkins
Assignee: James Perkins
Priority: Blocker
Fix For: 10.0.0.Final
The datasource subsystem was given the concept of domain profiles in WFLY-3634. This
doesn't appear to have been fully implemented as {{-ds.xml}} deployments in domain
mode don't work. During the deploy process the profile is passed as {{null}} which
results in the profile named {{default}} being used. Essentially this means that
{{-ds.xml}} domain deployments would only ever work on a profile named {{default}}.
While debugging the issue it doesn't seem as if the profile concept is even needed
for data sources. The subsystem is only registered on servers and a server shouldn't
need to know about profiles.
In short the profile concept needs to be removed and the {{profile}} attribute on the
result of the {{installed-drivers-list}} operation as well as the {{installed-drivers}}
complex attribute needs to be deprecated. The attribute was added for the web console and
per https://developer.jboss.org/message/941413#941413 it is not used.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)