[jboss-jira] [JBoss JIRA] (ELY-801) ModifiableSecurityRealm#getRealmIdentityIterator() is a bit wrong

ModifiableSecurityRealm#getRealmIdentityIterator() is a bit wrong ----------------------------------------------------------------- Key: ELY-801 URL: https://issues.jboss.org/browse/ELY-801 Project: WildFly Elytron Issue Type: Bug Components: API / SPI Reporter: David Lloyd Assignee: David Lloyd Priority: Minor After the fixes for iterator closing which pertain mainly to the file system realm, we have a new interface CloseableIterator which adds a close() method which throws IOException. However this doesn't fit the general mold for identity handling, and only the FS realm would ever throw IOException (others would throw SQLException or NamingException for example). Fix this in a couple ways: # Drop CloseableIterator and replace it with a ModifiableRealmIdentityIterator which extends {{Iterator<ModifiableRealmIdentity>}} and {{AutoCloseable}} # Override {{close()}} to throw {{RealmUnavailableException}} Then make the associated changes to the realm(s).