[jboss-jira] [JBoss JIRA] (WFLY-8438) EJBComponentDescription : possible NPE on securityRoles

EJBComponentDescription : possible NPE on securityRoles ------------------------------------------------------- Key: WFLY-8438 URL: https://issues.jboss.org/browse/WFLY-8438 Project: WildFly Issue Type: Bug Components: EJB Reporter: Farah Juma Assignee: Farah Juma In https://github.com/wildfly/wildfly/commit/38f8f5915b40d036bd0fd1a904d6a13... you added check on {{if (securityRoles != null)}}. securityRoles is not checked few lines below your check (in different if block) https://github.com/wildfly/wildfly/blob/master/ejb3/src/main/java/org/jbo... (securityRoles.getSecurityRoleNamesByPrincipal ... ) I suggest to change https://github.com/wildfly/wildfly/blob/master/ejb3/src/main/java/org/jbo... from {code} if (runAsPrincipal != null) { {code} to {code} if ((securityRoles != null) && (runAsPrincipal != null)) { {code}