[jboss-jira] [JBoss JIRA] Closed: (JBRULES-780) no-loop results in NullPointer in RuleTerminalNode.retractTuple

no-loop results in NullPointer in RuleTerminalNode.retractTuple --------------------------------------------------------------- Key: JBRULES-780 URL: http://jira.jboss.com/jira/browse/JBRULES-780 Project: JBoss Rules Issue Type: Bug Security Level: Public(Everyone can see) Components: Reteoo Affects Versions: 3.1-m1 Reporter: Mark Proctor Assigned To: Mark Proctor Fix For: 3.1-m2 no-loop is currently trapped with: // if the current Rule is no-loop and the origin rule is the same then return if ( this.rule.getNoLoop() && this.rule.equals( context.getRuleOrigin() ) ) { return; } That means we have a tuple that reached the terminal node, but is not added to the memory or an activation created and attached. Thus on a modify or a retract the Tuple reaches the RuleTerminalNode and causes a Null pointer. The Q is, do we just do a null check and return, or do we do another no-loop check, my worry with just a null check is that it may mask other bugs.