[jboss-jira] [JBoss JIRA] (ELY-618) Dead code in DEREncoder

Ondrej Lukas created ELY-618: -------------------------------- Summary: Dead code in DEREncoder Key: ELY-618 URL: https://issues.jboss.org/browse/ELY-618 Project: WildFly Elytron Issue Type: Bug Affects Versions: 1.1.0.Beta7 Reporter: Ondrej Lukas Assignee: Darran Lofthouse There is an unintentional dead code in writeTag method of org.wildfly.security.asn1.DEREncoder. Variable {{tagNumber}} can be assigned to 31 as its maximal value from {{int tagNumber = tag & TAG_NUMBER_MASK;}} (because {{TAG_NUMBER_MASK = 0x1f}}) on line 576 [1] which means that condition {{if (tagNumber < 128)}} on line 582 is always true. It causes that else branch is never executed. [1] https://github.com/wildfly-security/wildfly-elytron/blob/4453ea40a7a617b6... -- This message was sent by Atlassian JIRA (v6.4.11#64026)