DbPersistenceService.beginTransaction() should check for isTransactionEnabled
-----------------------------------------------------------------------------
Key: JBPM-833
URL:
http://jira.jboss.com/jira/browse/JBPM-833
Project: JBoss jBPM
Issue Type: Bug
Components: Core Engine
Affects Versions: jBPM jPDL 3.2 beta 2
Environment: jbpm-enterprise.ear Jboss AS 4.0.5GA with ejb3 and JMS.
cvs head version.
Reporter: Chris Russell
Assigned To: Tom Baeyens
Fix For: jBPM jPDL 3.2.1
jbm-console web app calls DbPersistenceService.beginTransaction() directly and so it needs
to test for isTransactionEnabled.
In trying to deploy jbpm-enterprise.ear to jboss as 4.0.5ga I cant figure out how to
properly configure CMT or JTA so I just set in
jbpm.cfg.xml
<field name="isCurrentSessionEnabled"><false /></field>
<field name="isTransactionEnabled"><false /></field>
This allowed me to continue trying to successfully run/deploy the ear and jbpm-console. I
then started getting an Exception from the JbpmPhaseListener. In looking at code I
realized that beginTransaction was not checking the flag. So either make that method
private or it needs to check the flag. I changed it to check the flag and this got me on
to the next set of issues. (Still dont know how to configure transactions properly)
code:
public void beginTransaction() {
//RSC Shouldnt this check for isTransactionEnabled??
if (isTransactionEnabled) {
log.debug("beginning hibernate transaction");
transaction = session.beginTransaction();
} else {
log.debug("DbPersistenceService.beginTransaction() called but
isTransactionEnabled==false");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira