[jboss-jira] [JBoss JIRA] Closed: (JBMICROCONT-102) Still a problem with recursive installs

Still a problem with recursive installs --------------------------------------- Key: JBMICROCONT-102 URL: http://jira.jboss.com/jira/browse/JBMICROCONT-102 Project: JBoss MicroContainer Issue Type: Sub-task Components: Dependency Reporter: Adrian Brock Assigned To: Adrian Brock Fix For: JBossMC_2_0_0M1 Further to the parent problem. There is still a problem with recursive installs where a component (not party to recursion) will be attempted to be installed twice. The fix for the parent was incomplete. We also need to check that a context is still in the state we expect before incrementing the state. This is because the recursive invocation may have already done the increment for us. Here's an example failure: java.lang.IndexOutOfBoundsException: Index: 7, Size: 7 at EDU.oswego.cs.dl.util.concurrent.CopyOnWriteArrayList.rangeCheck(CopyOnWriteArrayList.java:752) at EDU.oswego.cs.dl.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:372) at org.jboss.dependency.plugins.AbstractController.incrementState(AbstractController.java:422) at org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:533) at org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:472) at org.jboss.dependency.plugins.AbstractController.install(AbstractController.java:274) at org.jboss.dependency.plugins.AbstractController.install(AbstractController.java:177) at org.jboss.test.dependency.controller.test.AbstractDependencyTest.assertInstall(AbstractDependencyTest.java:85) at org.jboss.test.dependency.controller.test.RecursiveControllerActionTestCase.testInstall(RecursiveControllerActionTestCase.java:62) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at junit.framework.TestCase.runTest(TestCase.java:154) at junit.framework.TestCase.runBare(TestCase.java:127) at junit.framework.TestResult$1.protect(TestResult.java:106) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.framework.TestResult.run(TestResult.java:109) at junit.framework.TestCase.run(TestCase.java:118) at junit.framework.TestSuite.runTest(TestSuite.java:208) at junit.framework.TestSuite.run(TestSuite.java:203) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22) at junit.extensions.TestSetup$1.protect(TestSetup.java:19) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.extensions.TestSetup.run(TestSetup.java:23) at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:128) at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)