[jboss-jira] [JBoss JIRA] Commented: (JBAS-6842) Unwanted deployment of the shared STLBs

[ https://jira.jboss.org/jira/browse/JBAS-6842?page=com.atlassian.jira.plug... ] jaikiran pai commented on JBAS-6842: ------------------------------------ A bit more details - The OptAnnotationMetaDataDeployer uses the AnnotationEnvironment to look for annotations on classes. The AnnotationEnvironment in the deployment unit is set by the org.jboss.deployers.vfs.plugins.annotations.FilteredAnnotationEnvironmentDeployer which does *not* take into account that the shared-ejbs.jar belongs to the EAR/lib folder of the unit: protected URL[] getUrls(VFSDeploymentUnit unit) throws Exception { List<VirtualFile> classpath = unit.getClassPath(); if (classpath != null && classpath.isEmpty() == false) { List<URL> urls = new ArrayList<URL>(); VirtualFile root = unit.getRoot(); for (VirtualFile cp : classpath) { VirtualFile check = cp; while(check != null && check.equals(root) == false) check = check.getParent(); if (check != null) urls.add(cp.toURL()); } if (urls.isEmpty() == false) { if (log.isTraceEnabled()) log.trace("Explicit urls: " + urls); return urls.toArray(new URL[urls.size()]); } } return new URL[0]; } Effectively it includes classes in that jar for annotation scanning. The Annotation environment deployer is a generic deployer and not specific to EJB3 deployments. IMO, this deployer should be aware of "library-directory" of an deployment (ex: for .ear the default library-directory is "lib"). By definition a library-directory contains only libraries and hence should not be scanned for annotations. So probably, the Annotation environment deployer needs to filter out the library-directory classes during AnnotationEnvironment creation. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira