[jboss-jira] [JBoss JIRA] Commented: (JBRULES-647) RuleModel to populate Descr for rendering to DRL

[ http://jira.jboss.com/jira/browse/JBRULES-647?page=comments#action_12360643 ] Edson Tirelli commented on JBRULES-647: --------------------------------------- I know I pushed for direct ROM->Descr conversion, but I didn't know about the DSL/DRL sentence mixing possibility. I would say now that we should simply: MN: yes its a bit unfortunate - would could drop the DSL for that, or just restrict it in a lot of ways (but either is painful) 1. drop the BRXMLtoDescrConverter 2. make BRLPersistence an interface and rename the current implementation to something like XMLBRLPersistence. MN: yes, thats a better name no matter what. 3. implement a DRLBRLPersistence to dump ROM to DRL format MN: OK, initially this would be one way of course - but eventually round trip (but not that concerned) 4. create a new BRXMLtoDescrConverter that is simply a helper, higher level API that does ROM->DRL->Descr conversion using above class + drl parser. MN: Yes that was my initial idea, but I was badly jetlagged at the time, so I still like your descr idea, but as you say, DSL messes it up. \ What do you think? Well, originally I invented this specifically to spit out DRL to show what it looks like, so I don't see a problem with this as long as its not too hard. I don't see a problem with that approach, I never thought the direct to Descr really helped that much for performance anyway, parsing is very fast, its the compiling that kills us. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira