[jboss-jira] [JBoss JIRA] (JBMESSAGING-1657) IllegalStateException upon cluster fail-over

[ https://issues.jboss.org/browse/JBMESSAGING-1657?page=com.atlassian.jira.... ] Raghavendra Venkatakrishnan commented on JBMESSAGING-1657: ---------------------------------------------------------- Hi Yong and Bela, if (!rsp.wasReceived()) { if (!rsp.wasSuspected()) { throw new IllegalStateException(this + " response not received from " + rsp.getSender() + " - there may be others"); } } Can you let me know whether the above code shall work for all the scenarios. Received a JMS leak in JBoss jms service and when I analysed it narrowed down to the above code in GroupMember.java.I also analysed the other jgroups related code surrounding this issue and if you notice in Rsp.java: public boolean wasReceived() { 66 return received; 67 } 68 69 public void setReceived(boolean received) { 70 this.received=received; 71 if(received) 72 suspected=false; 73 } 74 75 public boolean wasSuspected() { 76 return suspected; 77 } 78 79 public void setSuspected(boolean suspected) { 80 this.suspected=suspected; 81 if(suspected) 82 received=false; 83 } In GroupRequest's execute: public boolean execute(boolean use_anycasting, boolean block_for_results) throws Exception { 247 if(corr == null && transport == null) { 248 if(log.isErrorEnabled()) log.error("both corr and transport are null, cannot send group request"); 249 return false; 250 } 251 252 Vector<Address> targets=null; 253 lock.lock(); 254 try { 255 targets=new Vector<Address>(members); 256 for(Address suspect: suspects) { // mark all suspects in 'received' array 257 Rsp rsp=requests.get(suspect); // rsp shall be null if this requests map does not contain a mapped value for this address suspect or if the map is an empty one and hence suspect shall not be set to true. 258 if(rsp != null) { 259 rsp.setSuspected(true); 260 break; // we can break here because we ensure there are no duplicate members 261 } 262 } 263 } -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira