]
Radoslav Husar edited comment on WFLY-11983 at 6/3/19 9:37 AM:
---------------------------------------------------------------
[~jamezp] On the contrary, this is easy to enforce with basic git functionality called
{{.gitattributes}}. We just need to configure it to always checkout these files with CRLF
line endings regardless of the OS.
However, the core of the problem is in wildfly-core where the scripts are coming from –
opened WFCORE-4502.
was (Author: rhusar):
[~jamezp] On the contrary, this is easy to enforce with basic git functionality called
{{.gitattributes}}. We just need to configure it to always checkout these files with CRLF
line endings regardless of the OS.
However, the core of the problem is in wildfly-core where the scripts are coming from.
Unify line-endings of bat scripts (regression against WF15)
-----------------------------------------------------------
Key: WFLY-11983
URL:
https://issues.jboss.org/browse/WFLY-11983
Project: WildFly
Issue Type: Bug
Components: Scripts
Affects Versions: 16.0.0.Final
Reporter: Marek Kopecky
Assignee: Radoslav Husar
Priority: Critical
Line-endings of bat scripts should be unified. This is regression against WF15.
Some files in WF16 uses CRLF, another LF only. We need to clarify the recommended line
ending and use this line ending in all Windows scripts.
WF16:
{noformat}
$ find | grep bat$ | xargs file
./wsprovide.bat: DOS batch file, ASCII text, with CRLF line terminators
./jboss-cli.bat: DOS batch file, ASCII text
./elytron-tool.bat: DOS batch file, ASCII text
./domain.bat: DOS batch file, ASCII text, with CRLF line terminators
./wsconsume.bat: DOS batch file, ASCII text, with CRLF line terminators
./standalone.bat: DOS batch file, ASCII text, with CRLF line terminators
./vault.bat: DOS batch file, ASCII text, with CRLF line terminators
./domain.conf.bat: ASCII text, with CRLF line terminators
./common.bat: DOS batch file, ASCII text, with CRLF line terminators
./jdr.bat: DOS batch file, ASCII text
./jconsole.bat: DOS batch file, ASCII text
./appclient.bat: DOS batch file, ASCII text, with CRLF line terminators
./appclient.conf.bat: ASCII text, with CRLF line terminators
./standalone.conf.bat: ASCII text, with CRLF line terminators
./add-user.bat: DOS batch file, ASCII text
$
{noformat}
WF15:
{noformat}
$ find | grep bat$ | xargs file
./wsprovide.bat: DOS batch file, ASCII text, with CRLF line terminators
./jboss-cli.bat: DOS batch file, ASCII text, with CRLF line terminators
./elytron-tool.bat: DOS batch file, ASCII text, with CRLF line terminators
./domain.bat: DOS batch file, ASCII text, with CRLF line terminators
./wsconsume.bat: DOS batch file, ASCII text, with CRLF line terminators
./standalone.bat: DOS batch file, ASCII text, with CRLF line terminators
./vault.bat: DOS batch file, ASCII text, with CRLF line terminators
./domain.conf.bat: ASCII text, with CRLF line terminators
./common.bat: DOS batch file, ASCII text, with CRLF line terminators
./jdr.bat: DOS batch file, ASCII text, with CRLF line terminators
./jconsole.bat: DOS batch file, ASCII text, with CRLF line terminators
./appclient.bat: DOS batch file, ASCII text, with CRLF line terminators
./appclient.conf.bat: ASCII text, with CRLF line terminators
./standalone.conf.bat: ASCII text, with CRLF line terminators
./add-user.bat: DOS batch file, ASCII text, with CRLF line terminators
$
{noformat}