[jboss-jira] [JBoss JIRA] (JBCL-185) BaseClassLoader.loadClass() is slow under load

[ https://issues.jboss.org/browse/JBCL-185?page=com.atlassian.jira.plugin.s... ] Aaron Ogburn edited comment on JBCL-185 at 10/1/12 1:20 PM: ------------------------------------------------------------ The reason the class is not cached appears to be the following portion of BaseClassLoaderDomain.loadClass: Thread thread = Thread.currentThread(); ClassLoadingTask task = new ClassLoadingTask(name, classLoader, thread); ClassLoaderManager.scheduleTask(task, loader, false); Class<?> result = ClassLoaderManager.process(thread, task); ClassCacheItem item = globalClassCache.get(path); if (item != null) item.clazz = result; return result; The resulting class is only added to a preexisting ClassCacheItem. No ClassCacheItem was created for this previously on this domain. TRACE logging has shown that the parent domain is finding the loader in this case and creating initially creating/adding a ClassCacheItem here instead through findLoaderInExports. I've attached a test case that I think replicates this issue with a failure to cache in a child domain. It currently fails but the testcase passes after I implement the following change to BaseClassLoaderDomain.loadClass that creates and adds a ClassCacheItem regardless of whether or not an entry already exists: Thread thread = Thread.currentThread(); ClassLoadingTask task = new ClassLoadingTask(name, classLoader, thread); ClassLoaderManager.scheduleTask(task, loader, false); Class<?> result = ClassLoaderManager.process(thread, task); ClassCacheItem item = new ClassCacheItem(loader); item.clazz = result; globalClassCache.put(path, item); if (trace && item.clazz != null) log.trace(this + " cached " + name + " in global class cache "); return result; was (Author: aogburn): The reason the class is not cached appears to be the following portion of BaseClassLoaderDomain.loadClass: Loader loader = findLoader(classLoader, path, allExports, findInParent); if (loader != null) { Thread thread = Thread.currentThread(); ClassLoadingTask task = new ClassLoadingTask(name, classLoader, thread); ClassLoaderManager.scheduleTask(task, loader, false); Class<?> result = ClassLoaderManager.process(thread, task); ClassCacheItem item = globalClassCache.get(path); if (item != null) item.clazz = result; return result; } The resulting class is only added to a preexisting ClassCacheItem. No ClassCacheItem was created for this previously on this domain. TRACE logging has shown that the parent domain is finding the loader in this case and creating initially creating/adding a ClassCacheItem here instead through findLoaderInExports. I've attached a test case that I think replicates this issue with a failure to cache in a child domain. It currently fails but the testcase passes after I implement the following change to BaseClassLoaderDomain.loadClass that creates and adds a ClassCacheItem regardless of whether or not an entry already exists: Thread thread = Thread.currentThread(); ClassLoadingTask task = new ClassLoadingTask(name, classLoader, thread); ClassLoaderManager.scheduleTask(task, loader, false); Class<?> result = ClassLoaderManager.process(thread, task); ClassCacheItem item = new ClassCacheItem(loader); item.clazz = result; globalClassCache.put(path, item); if (trace && item.clazz != null) log.trace(this + " cached " + name + " in global class cache "); return result; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira