[jboss-jira] [JBoss JIRA] (WFCORE-1578) Better check of names of existing resources when adding '{local|remote-destination-outbound-socket-binding'

Better check of names of existing resources when adding '{local|remote-destination-outbound-socket-binding' ----------------------------------------------------------------------------------------------------------- Key: WFCORE-1578 URL: https://issues.jboss.org/browse/WFCORE-1578 Project: WildFly Core Issue Type: Bug Components: Domain Management Affects Versions: 3.0.0.Alpha1 Reporter: Chao Wang Assignee: Chao Wang Priority: Minor Labels: downstream_dependency Original Estimate: 3 days Remaining Estimate: 3 days Lets have some {{/socket-binding-group=standard-sockets/socket-binding}} with particular name. Then when I create some {{/socket-binding-group=standard-sockets/remote-destination-outbound-socket-binding}} or {{/socket-binding-group=standard-sockets/local-destination-outbound-socket-binding}} using same name as of already existing {{socket-binding}} resource, {{add}} operation is successful but when I perform server reload, it crashes as it is not able to parse configuration. See: # Start EAP and log to CLI # create your own {{socket-binding}} resource and {{\{remote|local\}-destination-outbound-socket-binding}} resource with same names and perform reload {code} /socket-binding-group=standard-sockets/socket-binding=myBinding:add() /socket-binding-group=standard-sockets/remote-destination-outbound-socket-binding=myBinding:add(host=localhost,port=8765) or /socket-binding-group=standard-sockets/local-destination-outbound-socket-binding=myBinding:add(socket-binding-ref=http) reload {code} # server crashes with following stacktrace in console log: {code} 17:31:40,447 INFO [org.jboss.as.connector.deployers.jdbc] (MSC service thread 1-7) WFLYJCA0019: Stopped Driver service with driver-name = h2 17:31:40,453 INFO [org.wildfly.extension.undertow] (MSC service thread 1-8) WFLYUT0008: Undertow HTTP listener default suspending 17:31:40,454 INFO [org.wildfly.extension.undertow] (MSC service thread 1-8) WFLYUT0007: Undertow HTTP listener default stopped, was bound to 127.0.0.1:8080 17:31:40,454 INFO [org.wildfly.extension.undertow] (MSC service thread 1-3) WFLYUT0004: Undertow 1.3.21.Final-redhat-1 stopping 17:31:40,458 INFO [org.jboss.as.mail.extension] (MSC service thread 1-7) WFLYMAIL0002: Unbound mail session [java:jboss/mail/Default] 17:31:40,461 INFO [org.jboss.as] (MSC service thread 1-5) WFLYSRV0050: JBoss EAP 7.0.0.GA (WildFly Core 2.1.2.Final-redhat-1) stopped in 22ms 17:31:40,461 INFO [org.jboss.as] (MSC service thread 1-5) WFLYSRV0049: JBoss EAP 7.0.0.GA (WildFly Core 2.1.2.Final-redhat-1) starting 17:31:40,489 ERROR [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0055: Caught exception during boot: org.jboss.as.controller.persistence.ConfigurationPersistenceException: WFLYCTL0085: Failed to parse configuration at org.jboss.as.controller.persistence.XmlConfigurationPersister.load(XmlConfigurationPersister.java:131) at org.jboss.as.server.ServerService.boot(ServerService.java:356) at org.jboss.as.controller.AbstractControllerService$1.run(AbstractControllerService.java:299) at java.lang.Thread.run(Thread.java:745) Caused by: javax.xml.stream.XMLStreamException: ParseError at [row,col]:[410,9] Message: WFLYCTL0042: A socket-binding or a outbound-socket-binding myBinding already declared has already been declared in socket-binding-group standard-sockets at org.jboss.as.server.parsing.StandaloneXml_4.parseSocketBindingGroup(StandaloneXml_4.java:518) at org.jboss.as.server.parsing.StandaloneXml_4.readServerElement(StandaloneXml_4.java:254) at org.jboss.as.server.parsing.StandaloneXml_4.readElement(StandaloneXml_4.java:141) at org.jboss.as.server.parsing.StandaloneXml.readElement(StandaloneXml.java:103) at org.jboss.as.server.parsing.StandaloneXml.readElement(StandaloneXml.java:49) at org.jboss.staxmapper.XMLMapperImpl.processNested(XMLMapperImpl.java:110) at org.jboss.staxmapper.XMLMapperImpl.parseDocument(XMLMapperImpl.java:69) at org.jboss.as.controller.persistence.XmlConfigurationPersister.load(XmlConfigurationPersister.java:123) ... 3 more 17:31:40,490 FATAL [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0056: Server boot has failed in an unrecoverable manner; exiting. See previous messages for details. 17:31:40,491 INFO [org.jboss.as.server] (Thread-2) WFLYSRV0220: Server shutdown has been requested. 17:31:40,496 INFO [org.jboss.as] (MSC service thread 1-2) WFLYSRV0050: JBoss EAP 7.0.0.GA (WildFly Core 2.1.2.Final-redhat-1) stopped in 3ms {code} After this occurs, one needs to fix {{./standalone/configuration/standalone.xml}} manually by removing duplicate resources. If there is a problem for those resources to have same names I would welcome that names are checked during the {{add}} operation already regarding to all resources in {{socket-binding}} and {{\{remote|local\}-destination-outbound-socket-binding}}. Note: not sure whether CLI component is appropriate, please change if there is better component for this.