[
https://issues.jboss.org/browse/JGRP-2409?page=com.atlassian.jira.plugin....
]
Bela Ban edited comment on JGRP-2409 at 11/26/19 4:22 AM:
----------------------------------------------------------
I applied your changes, thanks.
In the future, you can open pull requests if you have more changes. They're easier to
review.
Cheers,
was (Author: belaban):
I applied your changes, thanks,
Add more logging to MERGE3
--------------------------
Key: JGRP-2409
URL:
https://issues.jboss.org/browse/JGRP-2409
Project: JGroups
Issue Type: Enhancement
Affects Versions: 4.1.8
Reporter: Olivier Peyrusse
Assignee: Bela Ban
Priority: Major
Fix For: 4.1.9
MERGE3 comes with a good number of log traces. Combined with logs from TCP, TP, Merger
and other protocols, it provides a good understanding of what is happening in the
application.
Yet, when it comes to the actual process of merge run by {{ViewConsistencyChecker#_run}},
we lack details about what happens before performing the merge. Particularly, we can track
when VIEW_REQ messages are sent but we don't know what happen in the checker when
responses are processed:
- which views were received?
- when are they received?
- what is the final result on which the MERGE3 logic is executed
- is the merge cancelled or aborted?
In my [forked
branch|https://github.com/OPeyrusse/JGroups/tree/add-loggin-to-merge3], I
added 5 traces that helped me understand what was going on in my cluster.
Tell me if it is the right way to suggest improvements.
Regards
--
This message was sent by Atlassian Jira
(v7.13.8#713008)