[jboss-jira] [JBoss JIRA] Assigned: (JBAOP-723) Calling advisor.hasAnnotation(Method m, Class annotation) is unnecessary slow

Calling advisor.hasAnnotation(Method m, Class annotation) is unnecessary slow ------------------------------------------------------------------------------ Key: JBAOP-723 URL: https://jira.jboss.org/jira/browse/JBAOP-723 Project: JBoss AOP Issue Type: Bug Security Level: Public(Everyone can see) Affects Versions: 2.1.0.CR3 Reporter: Carlo de Wolf Assignee: Stale Pedersen Fix For: 2.1.1.GA, 2.2.0.GA The other thing is loading this class at all seems unfortunate. Pseudo call stack (see real stack trace below): 1) LifecycleCallbacks.createLifecycleCallbackInterceptors --> Advisor.hasAnnotation(.. PrePassivate.class) here we have the class 2) Advisor.hasAnnotation --> AnnotationRepositoryToMetaData.hasAnnotation(... PrePassivate.class.getName()) Advisor converts to String, probably because the default impl of AnnotationRepository caches things w/ String keys. But special class AnnotationRepositoryToMetaData does not... 3) AnnotationRepositoryToMetaData.hasAnnotation() --> ClassLoader.loadClass(String) to get back the class we have a ref to a couple frames back. :( "WorkerThread#298[10.16.88.182:54023]" prio=10 tid=0x6534d800 nid=0x56be waiting for monitor entry [0x598ad000..0x598adf30] java.lang.Thread.State: BLOCKED (on object monitor) at org.jboss.classloader.spi.base.BaseClassLoader.loadClass(BaseClassLoader.java:411) - waiting to lock <0x79d9a068> (a org.jboss.classloader.spi.base.BaseClassLoader) at java.lang.ClassLoader.loadClass(ClassLoader.java:252) at org.jboss.ejb3.metadata.annotation.AnnotationRepositoryToMetaData.loadClass(AnnotationRepositoryToMetaData.java:216) at org.jboss.ejb3.metadata.annotation.AnnotationRepositoryToMetaData.hasAnnotation(AnnotationRepositoryToMetaData.java:328) at org.jboss.aop.Advisor.hasAnnotation(Advisor.java:889) at org.jboss.aop.Advisor.hasAnnotation(Advisor.java:865) at org.jboss.ejb3.interceptors.aop.LifecycleCallbacks.createLifecycleCallbackInterceptors(LifecycleCallbacks.java:101) at org.jboss.ejb3.EJBContainer.invokeCallback(EJBContainer.java:1112) at org.jboss.ejb3.stateful.StatefulContainer.invokePrePassivate(StatefulContainer.java:668) at org.jboss.ejb3.stateful.StatefulBeanContext.preReplicate(StatefulBeanContext.java:544) at org.jboss.ejb3.cache.tree.StatefulTreeCache.putInCache(StatefulTreeCache.java:510) at org.jboss.ejb3.cache.tree.StatefulTreeCache.replicate(StatefulTreeCache.java:278) at org.jboss.ejb3.cache.StatefulReplicationInterceptor.invoke(StatefulReplicationInterceptor.java:114)