7:32 p.m.
jbossts-common.jar includes commons-logging Log4JLogger
-------------------------------------------------------
Key: JBTM-200
URL: http://jira.jboss.com/jira/browse/JBTM-200
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public (Everyone can see)
Reporter: Scott M Stark
Assigned To: Mark Little
Fix For: 4.2.3
The jbossts-common.jar jar includes an implementation of the commons-logging Log
interface:
[starksm@succubus lib]$ jar -tf jbossts-common.jar | grep Log4
org/apache/commons/logging/impl/Log4JLogger.class
This cannot be included in jars bundled in jbossas as it conflicts with the commons
logging classes we bundle with the server. Either this needs to be extracted to a jar that
is not included, or simply an external dependency that requires a valid commons logging
jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:48 a.m.
New subject: [JBoss JIRA] Assigned: (JBTM-200) jbossts-common.jar includes commons-logging Log4JLogger
[ http://jira.jboss.com/jira/browse/JBTM-200?page=all ]
Mark Little reassigned JBTM-200:
--------------------------------
Assignee: Jonathan Halliday (was: Mark Little)
jbossts-common.jar includes commons-logging Log4JLogger
-------------------------------------------------------
Key: JBTM-200
URL: http://jira.jboss.com/jira/browse/JBTM-200
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Scott M Stark
Assigned To: Jonathan Halliday
Fix For: 4.2.3
The jbossts-common.jar jar includes an implementation of the commons-logging Log
interface:
[starksm@succubus lib]$ jar -tf jbossts-common.jar | grep Log4
org/apache/commons/logging/impl/Log4JLogger.class
This cannot be included in jars bundled in jbossas as it conflicts with the commons
logging classes we bundle with the server. Either this needs to be extracted to a jar that
is not included, or simply an external dependency that requires a valid commons logging
jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 a.m.
New subject: [JBoss JIRA] Commented: (JBTM-200) jbossts-common.jar includes commons-logging Log4JLogger
[ http://jira.jboss.com/jira/browse/JBTM-200?page=comments#action_12352724 ]
Jonathan Halliday commented on JBTM-200:
----------------------------------------
We need the custom functionality this implementation class gives us, but I don't think
we need to continue to redefine the apache implementation class to get it. I think we can
achieve the same behaviour by having the JBossTS logging setup code dynamically configure
the commons LogFactory attribute org.apache.commons.logging.Log e.g.
rename our org/apache/commons/logging/impl/Log4JLogger -> org/jboss/..../Log4JLogger
then change our factory classes along the lines of:
JakartaRelevelingLogFactory.AbstractLogInterface getLog(Class clazz) {
org.apache.commons.logging.LogFactory.getFactory().setAttribute("org.apache.commons.logging.Log",
org.jboss....Log4JLogger.class.getName());
return new
JakartaRelevelingLogger(org.apache.commons.logging.LogFactory.getLog(clazz));
}
which should allow us to remove the modified apache impl class from the project and hence
the .jar file. I'll test this in more depth early next week.
jbossts-common.jar includes commons-logging Log4JLogger
-------------------------------------------------------
Key: JBTM-200
URL: http://jira.jboss.com/jira/browse/JBTM-200
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Scott M Stark
Assigned To: Jonathan Halliday
Fix For: 4.2.3
The jbossts-common.jar jar includes an implementation of the commons-logging Log
interface:
[starksm@succubus lib]$ jar -tf jbossts-common.jar | grep Log4
org/apache/commons/logging/impl/Log4JLogger.class
This cannot be included in jars bundled in jbossas as it conflicts with the commons
logging classes we bundle with the server. Either this needs to be extracted to a jar that
is not included, or simply an external dependency that requires a valid commons logging
jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:58 a.m.
New subject: [JBoss JIRA] Resolved: (JBTM-200) jbossts-common.jar includes commons-logging Log4JLogger
[ http://jira.jboss.com/jira/browse/JBTM-200?page=all ]
Jonathan Halliday resolved JBTM-200.
------------------------------------
Resolution: Done
jbossts-common.jar includes commons-logging Log4JLogger
-------------------------------------------------------
Key: JBTM-200
URL: http://jira.jboss.com/jira/browse/JBTM-200
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Scott M Stark
Assigned To: Jonathan Halliday
Fix For: 4.2.3
The jbossts-common.jar jar includes an implementation of the commons-logging Log
interface:
[starksm@succubus lib]$ jar -tf jbossts-common.jar | grep Log4
org/apache/commons/logging/impl/Log4JLogger.class
This cannot be included in jars bundled in jbossas as it conflicts with the commons
logging classes we bundle with the server. Either this needs to be extracted to a jar that
is not included, or simply an external dependency that requires a valid commons logging
jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:58 a.m.
New subject: [JBoss JIRA] Commented: (JBTM-200) jbossts-common.jar includes commons-logging Log4JLogger
[ http://jira.jboss.com/jira/browse/JBTM-200?page=comments#action_12352837 ]
Jonathan Halliday commented on JBTM-200:
----------------------------------------
Repackaged Log4JLogger to our own package hierarchy and modified the factory classes
(JakartaLogFactory and JakartaRelevelingLogFactory) to install it via. setAttribute as
above. Tested using TestLevels class. Line number and class name is reported corretly.
org.apache class no longer appears in jbossts-common.jar. Committed as svn rev 9450, so
the fix should be part of TS 4.2.3.CR3 and later releases.
jbossts-common.jar includes commons-logging Log4JLogger
-------------------------------------------------------
Key: JBTM-200
URL: http://jira.jboss.com/jira/browse/JBTM-200
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Scott M Stark
Assigned To: Jonathan Halliday
Fix For: 4.2.3
The jbossts-common.jar jar includes an implementation of the commons-logging Log
interface:
[starksm@succubus lib]$ jar -tf jbossts-common.jar | grep Log4
org/apache/commons/logging/impl/Log4JLogger.class
This cannot be included in jars bundled in jbossas as it conflicts with the commons
logging classes we bundle with the server. Either this needs to be extracted to a jar that
is not included, or simply an external dependency that requires a valid commons logging
jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7022
days inactive
7025
days old
4 comments
3 participants
participants (3)
-
Jonathan Halliday (JIRA) -
Mark Little (JIRA)
-
Scott M Stark (JIRA)