[
http://jira.jboss.com/jira/browse/JBTM-200?page=comments#action_12352724 ]
Jonathan Halliday commented on JBTM-200:
----------------------------------------
We need the custom functionality this implementation class gives us, but I don't think
we need to continue to redefine the apache implementation class to get it. I think we can
achieve the same behaviour by having the JBossTS logging setup code dynamically configure
the commons LogFactory attribute org.apache.commons.logging.Log e.g.
rename our org/apache/commons/logging/impl/Log4JLogger -> org/jboss/..../Log4JLogger
then change our factory classes along the lines of:
JakartaRelevelingLogFactory.AbstractLogInterface getLog(Class clazz) {
org.apache.commons.logging.LogFactory.getFactory().setAttribute("org.apache.commons.logging.Log",
org.jboss....Log4JLogger.class.getName());
return new
JakartaRelevelingLogger(org.apache.commons.logging.LogFactory.getLog(clazz));
}
which should allow us to remove the modified apache impl class from the project and hence
the .jar file. I'll test this in more depth early next week.
jbossts-common.jar includes commons-logging Log4JLogger
-------------------------------------------------------
Key: JBTM-200
URL:
http://jira.jboss.com/jira/browse/JBTM-200
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Scott M Stark
Assigned To: Jonathan Halliday
Fix For: 4.2.3
The jbossts-common.jar jar includes an implementation of the commons-logging Log
interface:
[starksm@succubus lib]$ jar -tf jbossts-common.jar | grep Log4
org/apache/commons/logging/impl/Log4JLogger.class
This cannot be included in jars bundled in jbossas as it conflicts with the commons
logging classes we bundle with the server. Either this needs to be extracted to a jar that
is not included, or simply an external dependency that requires a valid commons logging
jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira