[ https://issues.jboss.org/browse/AS7-4828?page=com.atlassian.jira.plugin.s... ] Paul Ferraro reassigned AS7-4828: --------------------------------- Assignee: Richard Achmatowicz (was: Paul Ferraro) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-4828?page=com.atlassian.jira.plugin.s... ] Richard Achmatowicz commented on AS7-4828: ------------------------------------------ Replaced the String representations of property values with the ModelNode {"value" => "the property value"} and updated the SimpleAttributeDefinition VALUE, used to handle property values only, to allow expressions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-4828?page=com.atlassian.jira.plugin.s... ] Richard Achmatowicz commented on AS7-4828: ------------------------------------------ Because this change introduces expressions in 7.2.0.Alpha1 and not in 7.1.x, we need to add "reject expression" transformers to the management model to reject expressions in the case that an 7.2.0.Alpha1 domain controller is used in combination with a 7.1.x host controller. Pull request will be modified. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-4828?page=com.atlassian.jira.plugin.s... ] Richard Achmatowicz commented on AS7-4828: ------------------------------------------ Well, it does for the attributes default-stack, site, rack, machine, but CommonAttributes.VALUE is marked as setAllowExpression(false). But this then would expect me to believe that if an expression were passed in and processed by VALUE.validateAndSet, it would be rejected. On the other hand, expressions seem to be getting through to the JGroups level based on JBPAPP-9504. Going to investigate. It may be that CommonAttributes.VALUE is not getting called at some point in the processing as there are several ways in which protocol properties can be passed in. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-4828?page=com.atlassian.jira.plugin.s... ] Richard Achmatowicz edited comment on AS7-4828 at 8/27/12 4:23 PM: ------------------------------------------------------------------- Well, it does for the attributes default-stack, site, rack, machine, but CommonAttributes.VALUE is marked as setAllowExpression(false). This is that attribute is intended to govern the values of properties. But this then would expect me to believe that if an expression were passed in and processed by VALUE.validateAndSet, it would be rejected. On the other hand, expressions seem to be getting through to the JGroups level based on JBPAPP-9504. Going to investigate. It may be that CommonAttributes.VALUE is not getting called at some point in the processing as there are several ways in which protocol properties can be passed in. was (Author: rachmato): Well, it does for the attributes default-stack, site, rack, machine, but CommonAttributes.VALUE is marked as setAllowExpression(false). But this then would expect me to believe that if an expression were passed in and processed by VALUE.validateAndSet, it would be rejected. On the other hand, expressions seem to be getting through to the JGroups level based on JBPAPP-9504. Going to investigate. It may be that CommonAttributes.VALUE is not getting called at some point in the processing as there are several ways in which protocol properties can be passed in. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-4828?page=com.atlassian.jira.plugin.s... ] Brian Stansberry commented on AS7-4828: --------------------------------------- At this point, work on 7.1.3 is stopped, except for 3 Blocker issues. Better IMO to focus on master, and making sure the transformation stuff won't break slaves running EAP 6.0.0. Even if the AS7-4828 stuff were ported to the 7.1 branch, the transformers will still need to deal with slaves on 6.0.0. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira