[ http://jira.jboss.com/jira/browse/JBAOP-373?page=comments#action_12355188 ] Kabir Khan commented on JBAOP-373: ---------------------------------- JoinPointInfo and subclasses contain important internal information. Now that we are using it as parameters for before/after/throwing type advices we need to make sure that the user does not change this information. The names I have used suck, so they should be changed to something better (not feeling inspired at the moment) when we come to do something with them -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAOP-373?page=all ] Kabir Khan updated JBAOP-373: ----------------------------- Fix Version/s: 2.0.0.alpha5 (was: 2.0.0.alpha4) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAOP-373?page=all ] Kabir Khan updated JBAOP-373: ----------------------------- Priority: Blocker (was: Major) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAOP-373?page=comments#action_12364765 ] Flavia Rainone commented on JBAOP-373: -------------------------------------- We can alternatively replace @JoinPoint by @JoinPointBean. That would be consistent to the way we refer to Invocation and JoinPointInfo hirearchies in the documentation, and would help us make the interface names the cleanest possible (FieldRead, FieldWrite, MethodCall, MethodExecution, etc). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAOP-373?page=comments#action_12364971 ] Kabir Khan commented on JBAOP-373: ---------------------------------- Hi Flavia, I noticed our naming is a bit off, but please read to the end before changing anything! Part 1: Construction.getConstructor() ConstructorCall.getConstructor() ConstructorExecution.getConstructor() MethodCall.getMethod() vs FieldAccess.getAdvisedField() (I think this should be renamed getField()) MethodExecution.getAdvisedMethod() (I think this should be renamed getMethod()) Part 2: MethodCalledByMethod.getCallingMethod() and ConstructorCalledByMethod.getCallingMethod() vs MethodCalledByConstructor.getCalling() and MethodCalledByConstructor.getCalling() (I think these should be renamed getCallingConstructor()) I realise I am probably the one who came up with these names, but since you are looking at it would you mind taking a look? If these cannot be renamed, in other words if these methods exist in 1.5.x and are being called, then I think we will need to rename the methods in the interfaces and create duplicate methods in the implementing classes. For example: interface MethodExecution { Method getMethod(); } class MethodInfo implements MethodExecution { ... //keep this public Method getAdvisedMethod() { return advisedMethod; } //add this public Method getMethod() { return advisedMethod; } } I am not 100% sure if this is public API, so this might not be necessary. let's sync up tomorrow when you get online -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAOP-373?page=comments#action_12365003 ] Kabir Khan commented on JBAOP-373: ---------------------------------- Which tests do you mean? This stuff hasn't really been released so far, so changing the API should be ok? I had a look through 1.5.x and could not really find much usage of this outside of the "internal" code. Some things like EJB 3 do use the XXXInfo classes though, so I think we should add this. I will take a look at this now -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAOP-373?page=all ] Flavia Rainone closed JBAOP-373. -------------------------------- Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira