12:45 p.m.
Mike Brock created JBWEB-238:
--------------------------------
Summary: HTTP Upgrade API Broken
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:47 p.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Mike Brock updated JBWEB-238:
-----------------------------
Attachment: JBossWeb.patch
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:24 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Remy Maucherat commented on JBWEB-238:
--------------------------------------
I dislike this change (and the patch is kinda hacky, way more likely to cause problem than
fix anything) since it pretty much goes against the event API intended behavior. So you
shouldn't plan on supporting the oldest drafts (I see 00 is affected, but 07 already
uses a safer process) in the current AS 7 branch since I am not going to put in something
too risky.
I am also not convinced the older websocket upgrades fit into the HTTP spec, since 101
does sound like a "no content" status code.
Looking at the 00 spec, it does not look like very good HTTP:
GET /demo HTTP/1.1
Host: example.com
Connection: Upgrade
Sec-WebSocket-Key2: 12998 5 Y3 1 .P00
Sec-WebSocket-Protocol: sample
Upgrade: WebSocket
Sec-WebSocket-Key1: 4 @1 46546xW%0l 1 5
Origin: http://example.com
^n:ds[4U
And the response is:
HTTP/1.1 101 WebSocket Protocol Handshake
Upgrade: WebSocket
Connection: Upgrade
Sec-WebSocket-Origin: http://example.com
Sec-WebSocket-Location: ws://example.com/demo
Sec-WebSocket-Protocol: sample
8jKS'y:G*Co,Wxa-
There is no content delimitation at all, so this is not a valid HTTP request/response
unless the connection is closed to indicate the end of the content (the servlet itself
must also know by itself how many bytes it needs to read otherwise it is certain to
block). I would prefer not adding support for something broken.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:29 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Remy Maucherat commented on JBWEB-238:
--------------------------------------
From what I can see, this got fixed in websocket draft 04.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:51 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Mike Brock commented on JBWEB-238:
----------------------------------
By not supporting it, we will be casting aside a great number of mobile devices that only
support Hybi-00. The latest version of Safari only supports Hybi-00. We will then support
significantly less of a cross-section than our competitors do.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:17 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Remy Maucherat commented on JBWEB-238:
--------------------------------------
My biggest problem is the HTTP looks broken :( Are you sure that these really early
clients are going to understand the HTTP responses from AS right anyway ? It's a bit
more freeform than the binary blobs that were included in the spec "document"
back then.
OTOH, I don't see anything in the response header here ...
HTTP/1.1 101 WebSocket Protocol Handshake
Upgrade: WebSocket
Connection: Upgrade
Sec-WebSocket-Origin: http://example.com
Sec-WebSocket-Location: ws://example.com/demo
Sec-WebSocket-Protocol: sample
... that depends on the "^n:ds[4U" thingie from the request "body",
which means that strictly speaking the response "body" can be generated later (=
in another event after the BEGIN, like a READ with "^n:ds[4U"). Since this is
not HTTP, it's not unreasonable, but it does increase complexity of the servlet. I
don't know if the IO works with that at the moment, though, I'd need to test it.
Also, it has been stated that the old websocket protocol versions were insecure, I
remember Firefox blacklisted websocket at the time for example. Is it really a good idea
to support all of them ? (I try to avoid the security people now ...)
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:29 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Mike Brock commented on JBWEB-238:
----------------------------------
Yes. I'm sure clients can understand it. I have a patched version of AS with which
I've been testing iPhones, iPads, Android Tablets, Safari, etc. all week.
I don't think these changes increase the complexity at all from the Servlet point of
view. That's why my patch adds an overloaded sendUpgrade method.
Also, most people will use higher level frameworks like Errai or Stilts or Atmosphere. So
most users won't care about this. :(
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:37 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Mike Brock edited comment on JBWEB-238 at 4/13/12 12:37 PM:
------------------------------------------------------------
Yes. I'm sure clients can understand it. I have a patched version of AS with which
I've been testing iPhones, iPads, Android Tablets, Safari, etc. all week.
I don't think these changes increase the complexity at all from the Servlet point of
view. That's why my patch adds an overloaded sendUpgrade method.
Also, most people will use higher level frameworks like Errai or Stilts or Atmosphere. So
most users won't care about this. :)
was (Author: cbrock):
Yes. I'm sure clients can understand it. I have a patched version of AS with which
I've been testing iPhones, iPads, Android Tablets, Safari, etc. all week.
I don't think these changes increase the complexity at all from the Servlet point of
view. That's why my patch adds an overloaded sendUpgrade method.
Also, most people will use higher level frameworks like Errai or Stilts or Atmosphere. So
most users won't care about this. :(
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:39 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Mike Brock commented on JBWEB-238:
----------------------------------
If you look at this:
https://github.com/mikebrock/jboss-websockets/tree/master/src/main/java/o...
You will see that with this change, I was able to very elegantly support all popular
versions of the spec with automatic protocol detection. If you want, I have a war file
here, you can use for deploying to JBoss 7 -- assuming you have this patch -- where you
can test WebSockets yourself. I will attach.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:41 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Mike Brock updated JBWEB-238:
-----------------------------
Attachment: cdidemo2.war
A demo that relies on the aforementioned patch and uses
https://github.com/mikebrock/jboss-websockets/tree/master/src/main/java/o...
to achieve websockets support across different version fo the WebSockets spec.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:43 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Remy Maucherat commented on JBWEB-238:
--------------------------------------
I won't support it, sorry. But you probably misunderstood my comment.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:45 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Mike Brock commented on JBWEB-238:
----------------------------------
Okay then, I'll advise our users to use Glassfish.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:47 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Mike Brock edited comment on JBWEB-238 at 4/13/12 12:45 PM:
------------------------------------------------------------
Okay then, I'll advise our users to use Glassfish. How ridiculous.
was (Author: cbrock):
Okay then, I'll advise our users to use Glassfish.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:49 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Remy Maucherat commented on JBWEB-238:
--------------------------------------
Why not Jetty ? :)
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:51 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Mike Brock commented on JBWEB-238:
----------------------------------
I'm done with this conversation.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:51 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Mike Brock updated JBWEB-238:
-----------------------------
Comment: was deleted
(was: I'm done with this conversation. )
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:53 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Mike Brock commented on JBWEB-238:
----------------------------------
I thin it is wrong-headed to not support this. You've just basically refused to
support every iOS device and many Android devices for no good reason other than you
don't think it looks like "broken HTTP". Well, good for you. Some us
ACTUALLY are trying to compete in a market where supporting as many clients as possible
actually MATTERS.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:53 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Mike Brock edited comment on JBWEB-238 at 4/13/12 12:52 PM:
------------------------------------------------------------
I think it is wrong-headed to not support this. You've just basically refused to
support every iOS device and many Android devices for no good reason other than you
don't think it looks like "broken HTTP". Well, good for you. Some us
ACTUALLY are trying to compete in a market where supporting as many clients as possible
actually MATTERS.
was (Author: cbrock):
I thin it is wrong-headed to not support this. You've just basically refused to
support every iOS device and many Android devices for no good reason other than you
don't think it looks like "broken HTTP". Well, good for you. Some us
ACTUALLY are trying to compete in a market where supporting as many clients as possible
actually MATTERS.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:55 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Remy Maucherat commented on JBWEB-238:
--------------------------------------
Ok. I'd need to test things before I can comment more anyway.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:25 p.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Remy Maucherat commented on JBWEB-238:
--------------------------------------
After verifying in the HTTP spec, all 1xx status codes indeed have no entity body,
that's what I remembered but I wasn't sure yet. So adding the body parameter in
the sendUpgrade method is wrong. Similarly, your patch adds hacks to disable length
delimitation on input. Neither of this is nice, which is why I cannot commit your patch.
OTOH, it is possible to consider that this "entity body" of the response is part
of the upgraded protocol, as I mentioned in a previous comment (essentially, doing a
separate write after the sendUpgrade()). Similarly, it would be possible to do reads for
the request body if it had proper content delimitation, like a content-length. After the
upgrade, it is always possible to read it, so that's the solution I recommend since
the response header doesn't contain the handshake, which makes this trick doable.
I am attaching an example that works, reading the input content for the handshake, then
writing output data. It's a bit inconvinient, but it works, and that's the best I
can do.
As for future proofing other protocol upgrades, I trust they would read the HTTP
specification this time. (ok, won't happen probably)
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:27 p.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Remy Maucherat updated JBWEB-238:
---------------------------------
Attachment: Upgrade00ServletTest.java
Read and write the handshake after calling sendUpgrade() should work
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:45 p.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Bruno Oliveira commented on JBWEB-238:
--------------------------------------
Remy, I must agree with Lincoln and Mike, it's not just about follow the standards, we
must to support websockets on Aerogear and we can't ignore mobile devices or new
technologies, trust me.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:54 p.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Remy Maucherat resolved JBWEB-238.
----------------------------------
Resolution: Rejected
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:54 p.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Remy Maucherat closed JBWEB-238.
--------------------------------
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:03 p.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
David Lloyd reopened JBWEB-238:
-------------------------------
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:30 p.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Mike Brock commented on JBWEB-238:
----------------------------------
With Remy's proposed solution this is what tcpdump observed on the socket:
{noformat}
3"u03"u.HTTP/1.1 101 Switching Protocols
Server: Apache-Coyote/1.1
Upgrade: WebSocket
Connection: Upgrade
Sec-WebSocket-Protocol: J.REP1.0/ErraiBus
Sec-WebSocket-Origin: http://localhost:8080
Sec-WebSocket-Location: ws://localhost:8080/cdidemo2/in.erraiBusWS
Date: Fri, 13 Apr 2012 20:27:51 GMT
16:27:52.046258 IP localhost,unused.51722 > localhost,unused.http-alt: Flags [P.], seq
269:475, ack 314, win 40830, options [nop,nop,TS val 857896241 ecr 857896240], length 206
{noformat}
The magic string is not there. It appears Safari hung up before it had a chance to read
it.
Now, with my patch applied:
{noformat}
3$$.3$$.HTTP/1.1 101 Switching Protocols
Server: Apache-Coyote/1.1
Upgrade: WebSocket
Connection: Upgrade
Sec-WebSocket-Protocol: J.REP1.0/ErraiBus
Sec-WebSocket-Origin: http://localhost:8080
Sec-WebSocket-Location: ws://localhost:8080/cdidemo2/in.erraiBusWS
Date: Fri, 13 Apr 2012 20:29:42 GMT
g......./^-.....
16:29:42.778277 IP localhost,unused.51774 > localhost,unused.http-alt: Flags [P.], seq
288:491, ack 314, win 40830, options [nop,nop,TS val 858006737 ecr 858006732], length 203
{noformat}
Hey, there it is!
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:52 p.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Remy Maucherat commented on JBWEB-238:
--------------------------------------
Yes, I got that, you said it expected it in the same read.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:56 p.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
David Lloyd commented on JBWEB-238:
-----------------------------------
I think the interesting question will be, "in the same read as what?" - Surely
Safari can't expect all HTTP reply headers to appear in a single read. If you go over
the MTU you're guaranteed to have more than one read no matter what. So is it the
same read as the final CRLF after the headers, or something else perhaps?
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:10 p.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Remy Maucherat commented on JBWEB-238:
--------------------------------------
Yes, it does, that's what Mike said (and he did post his network capture, which I
didn't really need since he was clear). The HTTP header and the handshake must be in
the same packet. So the early protocol and the implementation are both bad apparently.
I need to add a hook to allow reading on the GET (although it shouldn't), and keep the
hook to commit and send the response header. Lame.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:01 p.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
David Lloyd commented on JBWEB-238:
-----------------------------------
It may be a coincidence/red herring. Yes, Remy's solution does send the handshake
bytes in a separate TCP message. However the problem appears to be something else - the
server sends a FIN before it could ever know the client's opinion of the reply. Remy,
do you know of some reason this would happen on an Upgraded socket?
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:49 p.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Remy Maucherat updated JBWEB-238:
---------------------------------
Attachment: (was: Upgrade00ServletTest.java)
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6 p.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Remy Maucherat updated JBWEB-238:
---------------------------------
Attachment: Upgrade00ServletTest.java
With the additional startUpgrade method.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:24 p.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Mike Brock commented on JBWEB-238:
----------------------------------
Okay. I will test this.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:19 p.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Mike Brock commented on JBWEB-238:
----------------------------------
Okay, I can confirm that your patch resolves the issue. Thank you. I think you can mark
this resolved. It passes all my tests.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:18 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
David Lloyd commented on JBWEB-238:
-----------------------------------
I feel a group hug coming on... come on... let's bring it in!
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:48 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Remy Maucherat commented on JBWEB-238:
--------------------------------------
Meh, this is still hacking.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Mike Brock commented on JBWEB-238:
----------------------------------
I like the way you've created a demarcation with startUpgrade() and sendUpgrade().
Whatever you do, I think you should keep that.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:24 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Remy Maucherat commented on JBWEB-238:
--------------------------------------
I added it, so I'm not going to remove it.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:15 a.m.
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Remy Maucherat resolved JBWEB-238.
----------------------------------
Fix Version/s: JBossWeb-7.0.15.GA
Resolution: Done
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Fix For: JBossWeb-7.0.15.GA
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5222
days inactive
5227
days old
38 comments
4 participants
participants (4)
-
Bruno Oliveira (JIRA) -
David Lloyd (JIRA)
-
Mike Brock (JIRA)
-
Remy Maucherat (JIRA)