[jboss-jira] [JBoss JIRA] (JBWEB-238) HTTP Upgrade API Broken
[
https://issues.jboss.org/browse/JBWEB-238?page=com.atlassian.jira.plugin....
]
Remy Maucherat commented on JBWEB-238:
--------------------------------------
Yes, it does, that's what Mike said (and he did post his network capture, which I
didn't really need since he was clear). The HTTP header and the handshake must be in
the same packet. So the early protocol and the implementation are both bad apparently.
I need to add a hook to allow reading on the GET (although it shouldn't), and keep the
hook to commit and send the response header. Lame.
HTTP Upgrade API Broken
-----------------------
Key: JBWEB-238
URL: https://issues.jboss.org/browse/JBWEB-238
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossWeb-7.0.13.GA
Environment: Any
Reporter: Mike Brock
Assignee: Remy Maucherat
Attachments: cdidemo2.war, JBossWeb.patch, Upgrade00ServletTest.java
The HTTP Upgrade API currently does not permit reading and writing to the
ServetOutputStream and ServletInputStream during the initial negotiation. All of the data
is swallowed until after the negotiation and head exchange.
Unfortunately this is insufficient as some WebSocket Draft Specification rely on data
within the body of the request and response as part of the handshake.
The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira