[JBoss JIRA] Created: (JBREM-648) Client.disconnect without clearing ConnectionListeners will cause NPEs
1:54 p.m.
Client.disconnect without clearing ConnectionListeners will cause NPEs
----------------------------------------------------------------------
Key: JBREM-648
URL: http://jira.jboss.com/jira/browse/JBREM-648
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public (Everyone can see)
Reporter: Clebert Suconic
Assigned To: Tom Elrod
ConnectionValidator should be stoped when disconnected is called.
ConnectionValidator::run will fail at this line if ConnectionValidator is not stopped:
public void run()
{
try
{
boolean isValid = checkConnection(client.getInvoker().getLocator(),
client.getConfiguration());
The fix should be simple though:
public void disconnect()
{
if (invoker != null)
{
if(enableLease)
{
invoker.terminateLease(sessionId);
enableLease = false;
}
if (validator!=null) // /this is the fix.....
{
validator.stop();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:59 p.m.
New subject: [JBoss JIRA] Updated: (JBREM-648) Client.disconnect without clearing ConnectionListeners will cause NPEs
[ http://jira.jboss.com/jira/browse/JBREM-648?page=all ]
Clebert Suconic updated JBREM-648:
----------------------------------
Priority: Critical (was: Major)
This is critical for Messaging team.
Client.disconnect without clearing ConnectionListeners will cause
NPEs
----------------------------------------------------------------------
Key: JBREM-648
URL: http://jira.jboss.com/jira/browse/JBREM-648
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Clebert Suconic
Assigned To: Tom Elrod
Priority: Critical
ConnectionValidator should be stoped when disconnected is called.
ConnectionValidator::run will fail at this line if ConnectionValidator is not stopped:
public void run()
{
try
{
boolean isValid = checkConnection(client.getInvoker().getLocator(),
client.getConfiguration());
The fix should be simple though:
public void disconnect()
{
if (invoker != null)
{
if(enableLease)
{
invoker.terminateLease(sessionId);
enableLease = false;
}
if (validator!=null) // /this is the fix.....
{
validator.stop();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:07 p.m.
New subject: [JBoss JIRA] Updated: (JBREM-648) Client.disconnect without clearing ConnectionListeners will cause NPEs
[ http://jira.jboss.com/jira/browse/JBREM-648?page=all ]
Clebert Suconic updated JBREM-648:
----------------------------------
Attachment: Client.java
Client.disconnect without clearing ConnectionListeners will cause
NPEs
----------------------------------------------------------------------
Key: JBREM-648
URL: http://jira.jboss.com/jira/browse/JBREM-648
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Clebert Suconic
Assigned To: Tom Elrod
Priority: Critical
Attachments: Client.java
ConnectionValidator should be stoped when disconnected is called.
ConnectionValidator::run will fail at this line if ConnectionValidator is not stopped:
public void run()
{
try
{
boolean isValid = checkConnection(client.getInvoker().getLocator(),
client.getConfiguration());
The fix should be simple though:
public void disconnect()
{
if (invoker != null)
{
if(enableLease)
{
invoker.terminateLease(sessionId);
enableLease = false;
}
if (validator!=null) // /this is the fix.....
{
validator.stop();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:09 p.m.
New subject: [JBoss JIRA] Updated: (JBREM-648) Client.disconnect without clearing ConnectionListeners will cause NPEs
[ http://jira.jboss.com/jira/browse/JBREM-648?page=all ]
Clebert Suconic updated JBREM-648:
----------------------------------
Attachment: ConnectionValidator.java
Client.disconnect without clearing ConnectionListeners will cause
NPEs
----------------------------------------------------------------------
Key: JBREM-648
URL: http://jira.jboss.com/jira/browse/JBREM-648
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Clebert Suconic
Assigned To: Tom Elrod
Priority: Critical
Attachments: Client.java, ConnectionValidator.java
ConnectionValidator should be stoped when disconnected is called.
ConnectionValidator::run will fail at this line if ConnectionValidator is not stopped:
public void run()
{
try
{
boolean isValid = checkConnection(client.getInvoker().getLocator(),
client.getConfiguration());
The fix should be simple though:
public void disconnect()
{
if (invoker != null)
{
if(enableLease)
{
invoker.terminateLease(sessionId);
enableLease = false;
}
if (validator!=null) // /this is the fix.....
{
validator.stop();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:11 p.m.
New subject: [JBoss JIRA] Commented: (JBREM-648) Client.disconnect without clearing ConnectionListeners will cause NPEs
[ http://jira.jboss.com/jira/browse/JBREM-648?page=comments#action_12348389 ]
Clebert Suconic commented on JBREM-648:
---------------------------------------
I have attached a fix based on 2.2.0.Alpha2.
It solved my problem
Client.disconnect without clearing ConnectionListeners will cause
NPEs
----------------------------------------------------------------------
Key: JBREM-648
URL: http://jira.jboss.com/jira/browse/JBREM-648
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Clebert Suconic
Assigned To: Tom Elrod
Priority: Critical
Attachments: Client.java, ConnectionValidator.java
ConnectionValidator should be stoped when disconnected is called.
ConnectionValidator::run will fail at this line if ConnectionValidator is not stopped:
public void run()
{
try
{
boolean isValid = checkConnection(client.getInvoker().getLocator(),
client.getConfiguration());
The fix should be simple though:
public void disconnect()
{
if (invoker != null)
{
if(enableLease)
{
invoker.terminateLease(sessionId);
enableLease = false;
}
if (validator!=null) // /this is the fix.....
{
validator.stop();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:12 a.m.
New subject: [JBoss JIRA] Commented: (JBREM-648) Client.disconnect without clearing ConnectionListeners will cause NPEs
[ http://jira.jboss.com/jira/browse/JBREM-648?page=comments#action_12348476 ]
Tim Fox commented on JBREM-648:
-------------------------------
I don't think the fix is valid. (Not 100% anyway)
Invoking ConnectionValidator::stop() wil cause the timer task to be cancelled. But if it
is already running then the ping could occur after the stop() has been executed.
stop() needs to block until currently executing timer task to finish executing before
returning
Client.disconnect without clearing ConnectionListeners will cause
NPEs
----------------------------------------------------------------------
Key: JBREM-648
URL: http://jira.jboss.com/jira/browse/JBREM-648
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Clebert Suconic
Assigned To: Tom Elrod
Priority: Critical
Attachments: Client.java, ConnectionValidator.java
ConnectionValidator should be stoped when disconnected is called.
ConnectionValidator::run will fail at this line if ConnectionValidator is not stopped:
public void run()
{
try
{
boolean isValid = checkConnection(client.getInvoker().getLocator(),
client.getConfiguration());
The fix should be simple though:
public void disconnect()
{
if (invoker != null)
{
if(enableLease)
{
invoker.terminateLease(sessionId);
enableLease = false;
}
if (validator!=null) // /this is the fix.....
{
validator.stop();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:53 a.m.
New subject: [JBoss JIRA] Commented: (JBREM-648) Client.disconnect without clearing ConnectionListeners will cause NPEs
[ http://jira.jboss.com/jira/browse/JBREM-648?page=comments#action_12348487 ]
Tom Elrod commented on JBREM-648:
----------------------------------
Have now corrected that as well.
Client.disconnect without clearing ConnectionListeners will cause
NPEs
----------------------------------------------------------------------
Key: JBREM-648
URL: http://jira.jboss.com/jira/browse/JBREM-648
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Clebert Suconic
Assigned To: Tom Elrod
Priority: Critical
Attachments: Client.java, ConnectionValidator.java
ConnectionValidator should be stoped when disconnected is called.
ConnectionValidator::run will fail at this line if ConnectionValidator is not stopped:
public void run()
{
try
{
boolean isValid = checkConnection(client.getInvoker().getLocator(),
client.getConfiguration());
The fix should be simple though:
public void disconnect()
{
if (invoker != null)
{
if(enableLease)
{
invoker.terminateLease(sessionId);
enableLease = false;
}
if (validator!=null) // /this is the fix.....
{
validator.stop();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:34 p.m.
New subject: [JBoss JIRA] Updated: (JBREM-648) Client.disconnect without clearing ConnectionListeners will cause NPEs
[ http://jira.jboss.com/jira/browse/JBREM-648?page=all ]
Tom Elrod updated JBREM-648:
-----------------------------
Fix Version/s: 2.2.0.Beta1 (Bluto)
Affects Version/s: 2.2.0.Alpha4
Client.disconnect without clearing ConnectionListeners will cause
NPEs
----------------------------------------------------------------------
Key: JBREM-648
URL: http://jira.jboss.com/jira/browse/JBREM-648
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.2.0.Alpha4
Reporter: Clebert Suconic
Assigned To: Tom Elrod
Priority: Critical
Fix For: 2.2.0.Beta1 (Bluto)
Attachments: Client.java, ConnectionValidator.java
ConnectionValidator should be stoped when disconnected is called.
ConnectionValidator::run will fail at this line if ConnectionValidator is not stopped:
public void run()
{
try
{
boolean isValid = checkConnection(client.getInvoker().getLocator(),
client.getConfiguration());
The fix should be simple though:
public void disconnect()
{
if (invoker != null)
{
if(enableLease)
{
invoker.terminateLease(sessionId);
enableLease = false;
}
if (validator!=null) // /this is the fix.....
{
validator.stop();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:34 p.m.
New subject: [JBoss JIRA] Commented: (JBREM-648) Client.disconnect without clearing ConnectionListeners will cause NPEs
[ http://jira.jboss.com/jira/browse/JBREM-648?page=comments#action_12349114 ]
Tom Elrod commented on JBREM-648:
----------------------------------
Clebert, are the changes looking ok for you? If so, I will close this issue.
Client.disconnect without clearing ConnectionListeners will cause
NPEs
----------------------------------------------------------------------
Key: JBREM-648
URL: http://jira.jboss.com/jira/browse/JBREM-648
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.2.0.Alpha4
Reporter: Clebert Suconic
Assigned To: Tom Elrod
Priority: Critical
Fix For: 2.2.0.Beta1 (Bluto)
Attachments: Client.java, ConnectionValidator.java
ConnectionValidator should be stoped when disconnected is called.
ConnectionValidator::run will fail at this line if ConnectionValidator is not stopped:
public void run()
{
try
{
boolean isValid = checkConnection(client.getInvoker().getLocator(),
client.getConfiguration());
The fix should be simple though:
public void disconnect()
{
if (invoker != null)
{
if(enableLease)
{
invoker.terminateLease(sessionId);
enableLease = false;
}
if (validator!=null) // /this is the fix.....
{
validator.stop();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:44 p.m.
New subject: [JBoss JIRA] Resolved: (JBREM-648) Client.disconnect without clearing ConnectionListeners will cause NPEs
[ http://jira.jboss.com/jira/browse/JBREM-648?page=all ]
Tom Elrod resolved JBREM-648.
------------------------------
Resolution: Done
Client.disconnect without clearing ConnectionListeners will cause
NPEs
----------------------------------------------------------------------
Key: JBREM-648
URL: http://jira.jboss.com/jira/browse/JBREM-648
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.2.0.Alpha4
Reporter: Clebert Suconic
Assigned To: Tom Elrod
Priority: Critical
Fix For: 2.2.0.Beta1 (Bluto)
Attachments: Client.java, ConnectionValidator.java
ConnectionValidator should be stoped when disconnected is called.
ConnectionValidator::run will fail at this line if ConnectionValidator is not stopped:
public void run()
{
try
{
boolean isValid = checkConnection(client.getInvoker().getLocator(),
client.getConfiguration());
The fix should be simple though:
public void disconnect()
{
if (invoker != null)
{
if(enableLease)
{
invoker.terminateLease(sessionId);
enableLease = false;
}
if (validator!=null) // /this is the fix.....
{
validator.stop();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:31 a.m.
New subject: [JBoss JIRA] Closed: (JBREM-648) Client.disconnect without clearing ConnectionListeners will cause NPEs
[ http://jira.jboss.com/jira/browse/JBREM-648?page=all ]
David Lloyd closed JBREM-648.
-----------------------------
Client.disconnect without clearing ConnectionListeners will cause
NPEs
----------------------------------------------------------------------
Key: JBREM-648
URL: http://jira.jboss.com/jira/browse/JBREM-648
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.2.0.Alpha4
Reporter: Clebert Suconic
Assigned To: Tom Elrod
Priority: Critical
Fix For: 2.2.0.Beta1 (Bluto)
Attachments: Client.java, ConnectionValidator.java
ConnectionValidator should be stoped when disconnected is called.
ConnectionValidator::run will fail at this line if ConnectionValidator is not stopped:
public void run()
{
try
{
boolean isValid = checkConnection(client.getInvoker().getLocator(),
client.getConfiguration());
The fix should be simple though:
public void disconnect()
{
if (invoker != null)
{
if(enableLease)
{
invoker.terminateLease(sessionId);
enableLease = false;
}
if (validator!=null) // /this is the fix.....
{
validator.stop();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6890
days inactive
7181
days old
10 comments
4 participants
participants (4)
-
Clebert Suconic (JIRA) -
David Lloyd (JIRA) -
Tim Fox (JIRA)
-
Tom Elrod (JIRA)