[jboss-jira] [JBoss JIRA] Commented: (JBREM-648) Client.disconnect without clearing ConnectionListeners will cause NPEs
[ http://jira.jboss.com/jira/browse/JBREM-648?page=comments#action_12348476 ]
Tim Fox commented on JBREM-648:
-------------------------------
I don't think the fix is valid. (Not 100% anyway)
Invoking ConnectionValidator::stop() wil cause the timer task to be cancelled. But if it
is already running then the ping could occur after the stop() has been executed.
stop() needs to block until currently executing timer task to finish executing before
returning
Client.disconnect without clearing ConnectionListeners will cause
NPEs
----------------------------------------------------------------------
Key: JBREM-648
URL: http://jira.jboss.com/jira/browse/JBREM-648
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Clebert Suconic
Assigned To: Tom Elrod
Priority: Critical
Attachments: Client.java, ConnectionValidator.java
ConnectionValidator should be stoped when disconnected is called.
ConnectionValidator::run will fail at this line if ConnectionValidator is not stopped:
public void run()
{
try
{
boolean isValid = checkConnection(client.getInvoker().getLocator(),
client.getConfiguration());
The fix should be simple though:
public void disconnect()
{
if (invoker != null)
{
if(enableLease)
{
invoker.terminateLease(sessionId);
enableLease = false;
}
if (validator!=null) // /this is the fix.....
{
validator.stop();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira