[ https://issues.jboss.org/browse/AS7-5063?page=com.atlassian.jira.plugin.s... ] Scott Marlow commented on AS7-5063: ----------------------------------- We can introduce an AS7 EclipseLink adaptor that will pass this property on the PersistenceProvider.createContainerEntityManagerFactory(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-5063?page=com.atlassian.jira.plugin.s... ] Craig Ringer commented on AS7-5063: ----------------------------------- I implemented one as part of the integration I've been working on (https://github.com/ringerc/as7-eclipselink-integration), but it doesn't seem to get activated via its META-INF/services/org.jboss.as.jpa.spi.PersistenceProviderAdaptor entry. I haven't worked out why yet, still delving in the AS7 jpa init code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-5063?page=com.atlassian.jira.plugin.s... ] Scott Marlow commented on AS7-5063: ----------------------------------- Craig, do you want contribute your integration changes (the ones that are needed) as a patch to AS7? Would need to change the package to org.jboss.as.jpa.eclipselink as a start. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-5063?page=com.atlassian.jira.plugin.s... ] Craig Ringer edited comment on AS7-5063 at 8/24/12 5:51 AM: ------------------------------------------------------------ I'd be happy to contribute it, but most of the actual code was written by others, I just packaged it up into a self-contained module with a tool to auto-assemble an EclipseLink module and wrote the AS7 persistence unit integration skeleton. We'd need permission from Rich DiCroce (https://community.jboss.org/people/rcd), who wrote JBossArchiveFactoryImpl.java and VFSArchive.java. I don't know the origin of JBossLogger.java as Rich had already published it on his howto when I picked it up and packaged it; I presume that was Rich too. As for the package name, embarrassingly it's wrong anyway; it should've been au.id.ringerc, so it's not exactly a hassle to change it. I'll re-test auto-activation on the latest 7.2, but I already know part of why it wasn't working properly. It seems that EclipseLink can't accept eclipselink.archive.factory as an EntityManagerFactory parameter via PersistenceUnitProperties; it needs it to be a system property. was (Author: ringerc): I'd be happy to contribute it, but most of the actual code was written by others, I just packaged it up. We'd also need permission from Rich DiCroce (https://community.jboss.org/people/rcd), who wrote JBossArchiveFactoryImpl.java and VFSArchive.java. I don't know the origin of JBossLogger.java as Rich had already published it on his howto when I picked it up and packaged it. As for the package name, embarrassingly it's wrong anyway; it should've been au.id.ringerc, so it's not exactly a hassle to change it. I'll re-test auto-activation on the latest 7.2, but I already know part of why it wasn't working properly. It seems that EclipseLink can't accept eclipselink.archive.factory as an EntityManagerFactory parameter via PersistenceUnitProperties; it needs it to be a system property. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-5063?page=com.atlassian.jira.plugin.s... ] Rich DiCroce commented on AS7-5063: ----------------------------------- I'm happy to contribute my code, and I've just signed the contributor agreement. It's currently pending approval by the project lead. As Craig said, VFSArchive, JBossArchiveFactoryImpl, and JBossLogger are mine, although I'm not sure if they're all needed now. I think I remember seeing a change that makes JBoss return file URLs to the JPA provider, in which case the VFS stuff may not be needed anymore. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-5063?page=com.atlassian.jira.plugin.s... ] Scott Marlow commented on AS7-5063: ----------------------------------- If we avoid adding actual EclipseLink (static) class references to the AS EclipseLink persistence provider, that makes it easier to use it with multiple versions of EclipseLink (so the provider doesn't depend on a specific AS EclipseLink module name). That is why I'm not yet sure where the Logger class should go. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-5063?page=com.atlassian.jira.plugin.s... ] Scott Marlow commented on AS7-5063: ----------------------------------- Our current Hibernate adapters also have a similar dependency (they depend on specific Hibernate 3.x or 4.x modules). Its not a huge problem currently but if the related EclipseLink classes later change (in an incompatible fashion), the adapter Logger will not work with the later EclipseLink version. Its not a blocker but something to think about (which I have been doing lately for the other adapters). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-5063?page=com.atlassian.jira.plugin.s... ] Craig Ringer commented on AS7-5063: ----------------------------------- Note that EclipseLinkPersistenceProviderAdapter also has a static reference to org.eclipse.persistence.Version - it's fully qualified in the code, not an import. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-5063?page=com.atlassian.jira.plugin.s... ] Scott Marlow commented on AS7-5063: ----------------------------------- Of course there is also the workaround of include the adapter jars with the application (I think that would also work). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-5063?page=com.atlassian.jira.plugin.s... ] Rich DiCroce commented on AS7-5063: ----------------------------------- I've just discovered a nasty EclipseLink bug. There are more details here (http://www.eclipse.org/forums/index.php/m/905614/), but the short version is that there's a race condition in EclipseLink's JPQL parser that can occur when a persistence unit is first initialized. My project has a pair of @Singleton @Startup EJBs that both need to query the database as part of their @PostConstruct, and they hit this bug very consistently on AS 7.1.1.Final. The guy who started the linked forum thread said he was going to file a bug report. I asked whether he actually did that, because I can't find one. If he didn't or he doesn't answer, I'll create a new issue in Eclipse's bug tracker. In the meantime, I've added a hack to work around the issue (source available at the link) that could be packaged as part of the integration module. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-5063?page=com.atlassian.jira.plugin.s... ] Craig Ringer edited comment on AS7-5063 at 8/30/12 11:58 PM: ------------------------------------------------------------- Rich, does the workaround for bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=383199 help? Try setting: <property name="eclipselink.deploy-on-startup" value="True" /> in persistence.xml or via the integration class. It's needed for JPA spec compliant static metamodel too, so I think it should be set by default. was (Author: ringerc): Rich, does the workaround for bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=383199 help? Try setting: <property name="eclipselink.deploy-on-startup" value="True" /> in persistence.xml or via the integration classe. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-5063?page=com.atlassian.jira.plugin.s... ] Rich DiCroce commented on AS7-5063: ----------------------------------- I filed a bug report for EclipseLink regarding the race condition: https://bugs.eclipse.org/bugs/show_bug.cgi?id=388852 Apparently, although no bug report existed in the EclipseLink tracker, Oracle did have it in their tracker for TopLink, which is based on EclipseLink. The bug is fixed in EclipseLink trunk and the fix will be in the 2.4.1 release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-5063?page=com.atlassian.jira.plugin.s... ] Rich DiCroce commented on AS7-5063: ----------------------------------- Yes, I noticed 2.4.1 was released. Unfortunately, I can't verify that the issue is fixed because the project I was using EclipseLink on has been put on hold and I've been reassigned to a project that uses Hibernate (ugh). I agree it seems reasonable to only support 2.4.1+ in the integration module, although 2.3.x could probably be supported as well since the problem was in the new JPQL parser, which was added in 2.4.0 if I remember correctly. Scott, any progress on the dependency issue? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-5063?page=com.atlassian.jira.plugin.s... ] Rich DiCroce commented on AS7-5063: ----------------------------------- I carved out some time and retested with EclipseLink 2.4.1 and a recent JBoss 7.2.0 snapshot (build 1246). I have confirmed that the race condition is fixed. I also took the jboss.as.jpa.vfs flag (AS7-5062) for a spin. Looks like that works as well, although there I have a project-specific issue I'm going to have to fix before I can use it. Scott, is there any reason VFS URLs are better than FILE URLs? If not, I'd say we can lose the VFS integration and just set the flag to false in the integration module. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira