[jboss-jira] [JBoss JIRA] (AS7-5063) AS7 should pass the property "eclipselink.target-server = JBoss" to persistence providers, or at least EclipseLink

[ https://issues.jboss.org/browse/AS7-5063?page=com.atlassian.jira.plugin.s... ] Craig Ringer commented on AS7-5063: ----------------------------------- I've signed the contributor agreement for my portion - which is really just the trivial adapter code in EclipseLinkPersistenceProviderAdaptor.java, the trivial module.xml, and the somewhat complicated Maven build that won't get used in AS7's build anyway. I think the logging integration is vital. Without it AS7's logs are immensely spammy and really hard to manage. It can't really be pushed into EclipseLink's codebase, as (a) we've missed the 2.4 release window and (b) it depends on JBoss Logging, so it's no better to have it in EclipseLink than in AS7. I don't see a big problem with depending on the public EclipseLink logging classes, as they'll exist for at least the whole 2.4 series, and they're public API that isn't very likely to go away. If it does then - as with the Hibernate modules - the module might want to be split by version. Bundling EclipseLink in the deployment is more of a problem. If EclipseLink is in the deployment, but no module for EclipseLink its self exists, it's my understanding that the integration would't find the EclipseLink logging classes when JBossLogger was instantiated by EclipseLink. Is there any way to let the module see the application classpath so it can use the application's EclipseLink? And should it? What then happens if both an EclipseLink module and a bundled copy in an app are present? How does this compare to other providers? If you bundle OpenJPA or Hibernate in your app? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira