javadocs for XmlHelper?
by Galder Zamarreno
Hi,
XmlHelper methods don't have any Javadocs which means that unless you
read through
the implementation, you can't know whether they can return null or
not, or whether they
return empty strings...etc.
I think we should write them so that the rest of the code does not
over/under checks the values
retrieved from XML.
Example: String readStringContents()
Looking at the implementation, I can see null will never be returned
from the method call. I have to
check for either empty or non empty Strings.
Cheers,
17 years, 4 months
Cutting JBC Cayenne 1.4.1.SP4
by Manik Surtani
Guys,
The 1.4.0 branch is pretty stable [1] at the moment and we have some
important fixes [2] there.
Outstanding, waiting for closure are:
JBCACHE-1048 (Brian, is this important for 1.4.1.SP4?)
JBCACHE-1103 (Jimmy, any feedback on this, did you get feedback on
this fix?)
JBCACHE-1067 - I still haven't confirmed whether this is a bug in the
first place; may defer this)
Hopefully once we have these closed we can look at cutting this release.
Cheers,
Manik
[1] http://cruisecontrol.jboss.com/cc/buildresults/jboss-cache-
testsuite-140
[2] http://tinyurl.com/28ox9f
--
Manik Surtani
Lead, JBoss Cache
JBoss, a division of Red Hat
17 years, 4 months
poll: java tag for shortcut set up methods created only for UT purposes?
by Galder Zamarreno
Hi,
Quite often when contributing in JBoss projects, I create extra
protected methods (i.e. setters)
to make my life a lot simpler when coding unit tests. People have
different opinions (such as
the messaging guys who believe every single UT should be coded to the
public API), but I
personally believe that you shouldn't be necessarily forced to set up
a complete environment
to run a specific UT. There're a lot of situations where it makes
sense to do this, but others where
not, and in the latter, having "shortcut" set up methods helps.
Sometimes, this "shortcut" methods are already there but other times
are not, hence my tendency
to create these protected methods. Now, wouldn't it be nice if
there's a Java tag
that could be applied to this methods to indicate that:
"this method is only here to make my unit-testing-coding-life easier
and so, should only be called from
unit tests, not from production code"
I had a quick look around and could not find anything. Do people
agree/disagree with creating such tag?
Cheers,
Galder
17 years, 4 months