8:14 p.m.
Tagged and *almost* ready for QA.
There are 2 AOP tests that seem to fail quite consistently, apart
from that it is looking pretty stable.
Ben, do you think you'd have a moment to have a quick look? I can't
imagine what has changed on the AOP side of things on this branch.
The tests are
org.jboss.cache.aop.collection.CachedListImplAopTest
org.jboss.cache.aop.ReplicatedSerializableAopTest
Thanks,
--
Manik Surtani
Lead, JBoss Cache
JBoss, a division of Red Hat
Email: manik(a)jboss.org
Telephone: +44 7786 702 706
MSN: manik(a)surtani.org
Yahoo/AIM/Skype: maniksurtani
9:23 a.m.
Manik,
Upon a closer look, the reason that it is failing now is because from PojoCache, we allow
to replicate non-Seriliazable object if we use JBossSerialization. But it seems now that
TreeCacheMarshaller140 (line 318) has tightened up the criteria to throw exception when it
is non-Serializable. So what's your suggestion?
-Ben
-----Original Message-----
From: Manik Surtani [mailto:manik@jboss.org]
Sent: Wednesday, January 31, 2007 10:14 AM
To: jbosscache-dev(a)lists.jboss.org; Ben Wang
Subject: JBossCache_1_4_1_SP1 tagged
Tagged and *almost* ready for QA.
There are 2 AOP tests that seem to fail quite consistently, apart from that it is looking
pretty stable.
Ben, do you think you'd have a moment to have a quick look? I can't imagine what
has changed on the AOP side of things on this branch.
The tests are
org.jboss.cache.aop.collection.CachedListImplAopTest
org.jboss.cache.aop.ReplicatedSerializableAopTest
Thanks,
--
Manik Surtani
Lead, JBoss Cache
JBoss, a division of Red Hat
Email: manik(a)jboss.org
Telephone: +44 7786 702 706
MSN: manik(a)surtani.org
Yahoo/AIM/Skype: maniksurtani
11:04 a.m.
When did you introduce this use of non-serializable objects? The
exception on line 318 in the TreeCacheMarshaller has been around
since 1.4.0.GA.
Anyway, I can change this in TCM based on whether jboss serialization
is being used, it's easy enough and does make sense.
--
Manik Surtani
Lead, JBoss Cache
JBoss, a division of Red Hat
Email: manik(a)jboss.org
Telephone: +44 7786 702 706
MSN: manik(a)surtani.org
Yahoo/AIM/Skype: maniksurtani
On 31 Jan 2007, at 15:23, Ben Wang wrote:
Manik,
Upon a closer look, the reason that it is failing now is because
from PojoCache, we allow to replicate non-Seriliazable object if we
use JBossSerialization. But it seems now that
TreeCacheMarshaller140 (line 318) has tightened up the criteria to
throw exception when it is non-Serializable. So what's your
suggestion?
-Ben
-----Original Message-----
From: Manik Surtani [mailto:manik@jboss.org]
Sent: Wednesday, January 31, 2007 10:14 AM
To: jbosscache-dev(a)lists.jboss.org; Ben Wang
Subject: JBossCache_1_4_1_SP1 tagged
Tagged and *almost* ready for QA.
There are 2 AOP tests that seem to fail quite consistently, apart
from that it is looking pretty stable.
Ben, do you think you'd have a moment to have a quick look? I
can't imagine what has changed on the AOP side of things on this
branch.
The tests are
org.jboss.cache.aop.collection.CachedListImplAopTest
org.jboss.cache.aop.ReplicatedSerializableAopTest
Thanks,
--
Manik Surtani
Lead, JBoss Cache
JBoss, a division of Red Hat
Email: manik(a)jboss.org
Telephone: +44 7786 702 706
MSN: manik(a)surtani.org
Yahoo/AIM/Skype: maniksurtani
11:06 a.m.
Done. Simply changed
... else if (o instanceof Serializable) ...
to
... else if (o instanceof Serializable ||
ObjectSerializationFactory.useJBossSerialization())...
and it works fine now.
Re-tagging. I think this is good to go to QA now, since these were
the only failures.
--
Manik Surtani
Lead, JBoss Cache
JBoss, a division of Red Hat
Email: manik(a)jboss.org
Telephone: +44 7786 702 706
MSN: manik(a)surtani.org
Yahoo/AIM/Skype: maniksurtani
On 31 Jan 2007, at 15:23, Ben Wang wrote:
Manik,
Upon a closer look, the reason that it is failing now is because
from PojoCache, we allow to replicate non-Seriliazable object if we
use JBossSerialization. But it seems now that
TreeCacheMarshaller140 (line 318) has tightened up the criteria to
throw exception when it is non-Serializable. So what's your
suggestion?
-Ben
-----Original Message-----
From: Manik Surtani [mailto:manik@jboss.org]
Sent: Wednesday, January 31, 2007 10:14 AM
To: jbosscache-dev(a)lists.jboss.org; Ben Wang
Subject: JBossCache_1_4_1_SP1 tagged
Tagged and *almost* ready for QA.
There are 2 AOP tests that seem to fail quite consistently, apart
from that it is looking pretty stable.
Ben, do you think you'd have a moment to have a quick look? I
can't imagine what has changed on the AOP side of things on this
branch.
The tests are
org.jboss.cache.aop.collection.CachedListImplAopTest
org.jboss.cache.aop.ReplicatedSerializableAopTest
Thanks,
--
Manik Surtani
Lead, JBoss Cache
JBoss, a division of Red Hat
Email: manik(a)jboss.org
Telephone: +44 7786 702 706
MSN: manik(a)surtani.org
Yahoo/AIM/Skype: maniksurtani
6:07 p.m.
Cool!
-----Original Message-----
From: Manik Surtani [mailto:manik@jboss.org]
Sent: Thursday, February 01, 2007 1:07 AM
To: Ben Wang
Cc: jbosscache-dev(a)lists.jboss.org
Subject: Re: JBossCache_1_4_1_SP1 tagged
Done. Simply changed
... else if (o instanceof Serializable) ...
to
... else if (o instanceof Serializable ||
ObjectSerializationFactory.useJBossSerialization())...
and it works fine now.
Re-tagging. I think this is good to go to QA now, since these were the only failures.
--
Manik Surtani
Lead, JBoss Cache
JBoss, a division of Red Hat
Email: manik(a)jboss.org
Telephone: +44 7786 702 706
MSN: manik(a)surtani.org
Yahoo/AIM/Skype: maniksurtani
On 31 Jan 2007, at 15:23, Ben Wang wrote:
Manik,
Upon a closer look, the reason that it is failing now is because from
PojoCache, we allow to replicate non-Seriliazable object if we use
JBossSerialization. But it seems now that TreeCacheMarshaller140 (line
318) has tightened up the criteria to throw exception when it is
non-Serializable. So what's your suggestion?
-Ben
-----Original Message-----
From: Manik Surtani [mailto:manik@jboss.org]
Sent: Wednesday, January 31, 2007 10:14 AM
To: jbosscache-dev(a)lists.jboss.org; Ben Wang
Subject: JBossCache_1_4_1_SP1 tagged
Tagged and *almost* ready for QA.
There are 2 AOP tests that seem to fail quite consistently, apart from
that it is looking pretty stable.
Ben, do you think you'd have a moment to have a quick look? I can't
imagine what has changed on the AOP side of things on this branch.
The tests are
org.jboss.cache.aop.collection.CachedListImplAopTest
org.jboss.cache.aop.ReplicatedSerializableAopTest
Thanks,
--
Manik Surtani
Lead, JBoss Cache
JBoss, a division of Red Hat
Email: manik(a)jboss.org
Telephone: +44 7786 702 706
MSN: manik(a)surtani.org
Yahoo/AIM/Skype: maniksurtani
6534
days inactive
6535
days old
jbosscache-dev@lists.jboss.org
4 comments
2 participants
participants (2)
-
Ben Wang -
Manik Surtani