Hi, XmlHelper methods don't have any Javadocs which means that unless you read through the implementation, you can't know whether they can return null or not, or whether they return empty strings...etc. I think we should write them so that the rest of the code does not over/under checks the values retrieved from XML. Example: String readStringContents() Looking at the implementation, I can see null will never be returned from the method call. I have to check for either empty or non empty Strings. Cheers, _______________________________________________ jbosscache-dev mailing list jbosscache-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jbosscache-dev