[jbosstools-commits] JBoss Tools SVN: r5475 - in trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common: model/ui/attribute/adapter and 1 other directories.
Author: dgolovin
Date: 2007-12-28 20:43:13 -0500 (Fri, 28 Dec 2007)
New Revision: 5475
Modified:
trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/editor/form/SamplePropertyForm.java
trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/editor/form/SampleTreeForm.java
trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/model/ui/attribute/adapter/JavaClassNewValueProvider.java
trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/model/ui/attribute/editor/MutableMultipleChoiceFieldEditor.java
Log:
Code Cleanup. Several PMD violations
http://pmd.sourceforge.net/rules/design.html#ConstructorCallsOverridableM... were
fixed.
Modified:
trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/editor/form/SamplePropertyForm.java
===================================================================
---
trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/editor/form/SamplePropertyForm.java 2007-12-28
17:21:29 UTC (rev 5474)
+++
trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/editor/form/SamplePropertyForm.java 2007-12-29
01:43:13 UTC (rev 5475)
@@ -41,7 +41,7 @@
public SamplePropertyForm() {
settings = new WhiteSettings();
- support = new SampleXAttributeSupport(getSettings());
+ support = new SampleXAttributeSupport(settings);
support.addPropertyChangeListener(this);
}
Modified:
trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/editor/form/SampleTreeForm.java
===================================================================
---
trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/editor/form/SampleTreeForm.java 2007-12-28
17:21:29 UTC (rev 5474)
+++
trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/editor/form/SampleTreeForm.java 2007-12-29
01:43:13 UTC (rev 5475)
@@ -47,7 +47,7 @@
public SampleTreeForm() {
tree = new XModelObjectTreeViewComponent();
- setHeadingText("Tree Form");
+ headingText = "Tree Form";
setCollapsable(Boolean.FALSE.booleanValue());
createActionMapping();
}
Modified:
trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/model/ui/attribute/adapter/JavaClassNewValueProvider.java
===================================================================
---
trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/model/ui/attribute/adapter/JavaClassNewValueProvider.java 2007-12-28
17:21:29 UTC (rev 5474)
+++
trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/model/ui/attribute/adapter/JavaClassNewValueProvider.java 2007-12-29
01:43:13 UTC (rev 5475)
@@ -18,7 +18,7 @@
XModel model;
public JavaClassNewValueProvider() {
- setModel(PreferenceModelUtilities.getPreferenceModel());
+ model = PreferenceModelUtilities.getPreferenceModel();
}
public void setModel(XModel model) {
Modified:
trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/model/ui/attribute/editor/MutableMultipleChoiceFieldEditor.java
===================================================================
---
trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/model/ui/attribute/editor/MutableMultipleChoiceFieldEditor.java 2007-12-28
17:21:29 UTC (rev 5474)
+++
trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/model/ui/attribute/editor/MutableMultipleChoiceFieldEditor.java 2007-12-29
01:43:13 UTC (rev 5475)
@@ -34,20 +34,16 @@
private SpecialWizard change;
public MutableMultipleChoiceFieldEditor() {
- initBar();
+ this(null);
}
public MutableMultipleChoiceFieldEditor(IWidgetSettings settings) {
super(settings);
- initBar();
- bar.setWidgetSettings(settings);
- }
-
- void initBar() {
bar.setCommands(commands);
bar.getLayout().direction = SWT.VERTICAL;
bar.getLayout().setMargins(0, 0, 0, 0);
bar.addCommandBarListener(this);
+ bar.setWidgetSettings(settings);
}
public void setChange(SpecialWizard change) {