[jbosstools-commits] JBoss Tools SVN: r25061 - trunk/usage/plugins/org.jboss.tools.usage/src/org/jboss/tools/usage/preferences.

Author: adietish Date: 2010-09-21 11:22:34 -0400 (Tue, 21 Sep 2010) New Revision: 25061 Modified: trunk/usage/plugins/org.jboss.tools.usage/src/org/jboss/tools/usage/preferences/GlobalUsageSettings.java Log: usage remoting plugin now disables reporting if the remote prop is NOT FOUND / UNREACHABLE / KEY MISSPELLED / VALUE MISSPELLED. It only reports if the remote property is found and is enabled! Modified: trunk/usage/plugins/org.jboss.tools.usage/src/org/jboss/tools/usage/preferences/GlobalUsageSettings.java =================================================================== --- trunk/usage/plugins/org.jboss.tools.usage/src/org/jboss/tools/usage/preferences/GlobalUsageSettings.java 2010-09-21 15:22:15 UTC (rev 25060) +++ trunk/usage/plugins/org.jboss.tools.usage/src/org/jboss/tools/usage/preferences/GlobalUsageSettings.java 2010-09-21 15:22:34 UTC (rev 25061) @@ -34,8 +34,12 @@ public static final String REMOTEPROPS_USAGE_REPORTING_ENABLED_KEY = USAGE_REPORTING_ENABLED_KEY + "="; //$NON-NLS-1$ - private static final boolean USAGE_REPORTING_ENABLED_DEFAULT = true; + /** the enablement default for the local instance */ + private static final boolean INSTANCE_USAGE_REPORTING_ENABLED_DEFAULT = true; + /** the enablement default for all instances */ + private static final boolean ALLINSTANCES_USAGE_REPORTING_ENABLED_DEFAULT = false; + /** the delimiter that delimits the key/value-pairs */ private static final char VALUE_DELIMITER = '\n'; @@ -72,12 +76,12 @@ Map<String, String> valueMap = remoteMap.getValueMap(); String isEnabled = valueMap.get(REMOTEPROPS_USAGE_REPORTING_ENABLED_KEY); if (isEnabled == null) { - return USAGE_REPORTING_ENABLED_DEFAULT; + return ALLINSTANCES_USAGE_REPORTING_ENABLED_DEFAULT; } return Boolean.valueOf(isEnabled); } catch (Exception e) { - return USAGE_REPORTING_ENABLED_DEFAULT; + return ALLINSTANCES_USAGE_REPORTING_ENABLED_DEFAULT; } } @@ -92,7 +96,7 @@ private boolean isInstanceReportingEnabled() { return Boolean.valueOf( System.getProperty(USAGE_REPORTING_ENABLED_KEY, - String.valueOf(USAGE_REPORTING_ENABLED_DEFAULT))); + String.valueOf(INSTANCE_USAGE_REPORTING_ENABLED_DEFAULT))); } protected HttpRemotePropertiesProvider createRemoteMap(String url, char valueDelimiter, Plugin plugin,