June 2017 - jbossts-issues - Jboss List Archives

[JBoss JIRA] (JBTM-2904) ConnectionManager no longer uses the underlying XADataSource's credentials when none are provided in its Properties

by Andy Wilkinson (JIRA)

[ https://issues.jboss.org/browse/JBTM-2904?page=com.atlassian.jira.plugin.... ] Andy Wilkinson commented on JBTM-2904: -------------------------------------- Thank you, and apologies for not spotting the original issue. > ConnectionManager no longer uses the underlying XADataSource's credentials when none are provided in its Properties > ------------------------------------------------------------------------------------------------------------------- > > Key: JBTM-2904 > URL: https://issues.jboss.org/browse/JBTM-2904 > Project: JBoss Transaction Manager > Issue Type: Bug > Affects Versions: 5.5.7.Final > Reporter: Andy Wilkinson > > I believe that [this commit|https://github.com/jbosstm/narayana/commit/789a02b78c8ffe5a7a07960...] has introduced a regression in how {{ConnectionManager}} handles credentials. Previously, if the {{Properties}} contained an {{XADataSource}} and no credentials, the data source's default credentials would be used, i.e. {{XADataSource.getXAConnection()}} would be called by {{ProvidedXADataSourceConnection}}. With the aforelinked change, {{ConnectionManager}} now coerces {{null}} credentials to empty strings. As a result {{XADataSource.getXAConnection(String, String)}} is called by {{ProvidedXADataSourceConnection}} with the empty credentials. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 5 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2904) ConnectionManager no longer uses the underlying XADataSource's credentials when none are provided in its Properties

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/JBTM-2904?page=com.atlassian.jira.plugin.... ] Tom Jenkinson resolved JBTM-2904. --------------------------------- Resolution: Duplicate Issue [~awilkinson] - should be fixed (as of very recently) here: JBTM-2902, if not, please do re-open > ConnectionManager no longer uses the underlying XADataSource's credentials when none are provided in its Properties > ------------------------------------------------------------------------------------------------------------------- > > Key: JBTM-2904 > URL: https://issues.jboss.org/browse/JBTM-2904 > Project: JBoss Transaction Manager > Issue Type: Bug > Affects Versions: 5.5.7.Final > Reporter: Andy Wilkinson > > I believe that [this commit|https://github.com/jbosstm/narayana/commit/789a02b78c8ffe5a7a07960...] has introduced a regression in how {{ConnectionManager}} handles credentials. Previously, if the {{Properties}} contained an {{XADataSource}} and no credentials, the data source's default credentials would be used, i.e. {{XADataSource.getXAConnection()}} would be called by {{ProvidedXADataSourceConnection}}. With the aforelinked change, {{ConnectionManager}} now coerces {{null}} credentials to empty strings. As a result {{XADataSource.getXAConnection(String, String)}} is called by {{ProvidedXADataSourceConnection}} with the empty credentials. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 5 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2904) ConnectionManager no longer uses the underlying XADataSource's credentials when none are provided in its Properties

by Andy Wilkinson (JIRA)

Andy Wilkinson created JBTM-2904: ------------------------------------ Summary: ConnectionManager no longer uses the underlying XADataSource's credentials when none are provided in its Properties Key: JBTM-2904 URL: https://issues.jboss.org/browse/JBTM-2904 Project: JBoss Transaction Manager Issue Type: Bug Affects Versions: 5.5.7.Final Reporter: Andy Wilkinson I believe that [this commit|https://github.com/jbosstm/narayana/commit/789a02b78c8ffe5a7a07960...] has introduced a regression in how {{ConnectionManager}} handles credentials. Previously, if the {{Properties}} contained an {{XADataSource}} and no credentials, the data source's default credentials would be used, i.e. {{XADataSource.getXAConnection()}} would be called by {{ProvidedXADataSourceConnection}}. With the aforelinked change, {{ConnectionManager}} now coerces {{null}} credentials to empty strings. As a result {{XADataSource.getXAConnection(String, String)}} is called by {{ProvidedXADataSourceConnection}} with the empty credentials. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 5 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2903) Improve JMS integration to be able to control connections more smartly

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/JBTM-2903?page=com.atlassian.jira.plugin.... ] Tom Jenkinson commented on JBTM-2903: ------------------------------------- Please can you add a stack trace showing the commit call failing? I am wondering when commit comes after ENDRSCAN. > Improve JMS integration to be able to control connections more smartly > ---------------------------------------------------------------------- > > Key: JBTM-2903 > URL: https://issues.jboss.org/browse/JBTM-2903 > Project: JBoss Transaction Manager > Issue Type: Bug > Reporter: Gytis Trikleris > Assignee: Gytis Trikleris > > Currently JMS integration opens a connection on getXAResources call and closes it on TMENDSCAN call. With a latest changes to XARecoveryModule, this connection management doesn't work any more, because connection might be closed before the commit call and result in a failure. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 5 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2903) Improve JMS integration to be able to control connections more smartly

by Gytis Trikleris (JIRA)

[ https://issues.jboss.org/browse/JBTM-2903?page=com.atlassian.jira.plugin.... ] Issue was automatically transitioned when Gytis Trikleris created pull request #1185 in GitHub ---------------------------------------------------------------------------------------------- Status: Pull Request Sent (was: Open) > Improve JMS integration to be able to control connections more smartly > ---------------------------------------------------------------------- > > Key: JBTM-2903 > URL: https://issues.jboss.org/browse/JBTM-2903 > Project: JBoss Transaction Manager > Issue Type: Bug > Reporter: Gytis Trikleris > Assignee: Gytis Trikleris > > Currently JMS integration opens a connection on getXAResources call and closes it on TMENDSCAN call. With a latest changes to XARecoveryModule, this connection management doesn't work any more, because connection might be closed before the commit call and result in a failure. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 5 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2903) Improve JMS integration to be able to control connections more smartly

by Gytis Trikleris (JIRA)

[ https://issues.jboss.org/browse/JBTM-2903?page=com.atlassian.jira.plugin.... ] Gytis Trikleris moved SB-91 to JBTM-2903: ----------------------------------------- Project: JBoss Transaction Manager (was: Spring Boot & Cloud) Key: JBTM-2903 (was: SB-91) > Improve JMS integration to be able to control connections more smartly > ---------------------------------------------------------------------- > > Key: JBTM-2903 > URL: https://issues.jboss.org/browse/JBTM-2903 > Project: JBoss Transaction Manager > Issue Type: Bug > Reporter: Gytis Trikleris > Assignee: Gytis Trikleris > > Currently JMS integration opens a connection on getXAResources call and closes it on TMENDSCAN call. With a latest changes to XARecoveryModule, this connection management doesn't work any more, because connection might be closed before the commit call and result in a failure. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 5 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2901) XARecoveryModule second pass shouldn't be executed if the state is not BETWEEN_PASSES

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/JBTM-2901?page=com.atlassian.jira.plugin.... ] Tom Jenkinson updated JBTM-2901: -------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done Hi Mike, I marked as resolved as you merged the PR. Feel free to re-open if necessary. > XARecoveryModule second pass shouldn't be executed if the state is not BETWEEN_PASSES > ------------------------------------------------------------------------------------- > > Key: JBTM-2901 > URL: https://issues.jboss.org/browse/JBTM-2901 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: Recovery > Reporter: Gytis Trikleris > Assignee: Michael Musgrove > Fix For: 5.next > > -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 5 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2901) XARecoveryModule second pass shouldn't be executed if the state is not BETWEEN_PASSES

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/JBTM-2901?page=com.atlassian.jira.plugin.... ] Tom Jenkinson updated JBTM-2901: -------------------------------- Fix Version/s: 5.next > XARecoveryModule second pass shouldn't be executed if the state is not BETWEEN_PASSES > ------------------------------------------------------------------------------------- > > Key: JBTM-2901 > URL: https://issues.jboss.org/browse/JBTM-2901 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: Recovery > Reporter: Gytis Trikleris > Assignee: Michael Musgrove > Fix For: 5.next > > -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 5 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2902) Transactional driver connections do not handle empty credentials correctly

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/JBTM-2902?page=com.atlassian.jira.plugin.... ] Tom Jenkinson updated JBTM-2902: -------------------------------- Fix Version/s: 5.next > Transactional driver connections do not handle empty credentials correctly > -------------------------------------------------------------------------- > > Key: JBTM-2902 > URL: https://issues.jboss.org/browse/JBTM-2902 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: Transactional Driver > Reporter: Gytis Trikleris > Assignee: Gytis Trikleris > Fix For: 5.next > > > Transactional driver connections only check for null credentials. If they are empty strings they are used as actual username and password, which is incorrect. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 5 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2902) Transactional driver connections do not handle empty credentials correctly

by Gytis Trikleris (JIRA)

[ https://issues.jboss.org/browse/JBTM-2902?page=com.atlassian.jira.plugin.... ] Gytis Trikleris updated JBTM-2902: ---------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done > Transactional driver connections do not handle empty credentials correctly > -------------------------------------------------------------------------- > > Key: JBTM-2902 > URL: https://issues.jboss.org/browse/JBTM-2902 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: Transactional Driver > Reporter: Gytis Trikleris > Assignee: Gytis Trikleris > > Transactional driver connections only check for null credentials. If they are empty strings they are used as actual username and password, which is incorrect. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 6 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

jbossts-issues June 2017