December 2019 - jbossts-issues - Jboss List Archives

[JBoss JIRA] (JBTM-3222) Local LRA lookup should just use the Uid part of the LRA

by Michael Musgrove (Jira)

[ https://issues.jboss.org/browse/JBTM-3222?page=com.atlassian.jira.plugin.... ] Michael Musgrove updated JBTM-3222: ----------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done > Local LRA lookup should just use the Uid part of the LRA > -------------------------------------------------------- > > Key: JBTM-3222 > URL: https://issues.jboss.org/browse/JBTM-3222 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.10.0.Final > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Major > Fix For: 5.next > > > The LRA implementation identifies LRA's by their full JAX-RS resource path (aka URI). [Remark we use the full resource path in order to determine which host owns the LRA]. But when these URI's are calculated sometimes the base URI ends up as localhost and other times as 127.0.0.1 (or :1). The code in the coordinator that wants to know if it owns an LRA should avoid checking the whole path and instead just rely on the Uid part of the resource path (com.arjuna.ats.arjuna.common.Uid). This is safe since the URI is globally unique. Note that this technique only works for LRA ids created by narayana which is fine because the code that does the lookup is only interested in whether the local coordinator created the LRA (tangentially related but it is also noteworthy that we are not targeting interoperability in LRA version 1.0 > The particular code that does the lookup is in LRAService#getTransaction(). -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 12 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3212) Ensure that an LRA timeout timer is restarted after a crash

by Michael Musgrove (Jira)

[ https://issues.jboss.org/browse/JBTM-3212?page=com.atlassian.jira.plugin.... ] Michael Musgrove resolved JBTM-3212. ------------------------------------ Resolution: Done > Ensure that an LRA timeout timer is restarted after a crash > ----------------------------------------------------------- > > Key: JBTM-3212 > URL: https://issues.jboss.org/browse/JBTM-3212 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.9.8.Final > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Blocker > > LRAs can be timed out. After a crash the time should be restarted. Currently this functionality is marked as a TODO item: > > https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinator-j... > and > https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinator-j... -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 12 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3225) Decide whether we should make the internal LRA client API not auto closable

by Michael Musgrove (Jira)

Michael Musgrove created JBTM-3225: -------------------------------------- Summary: Decide whether we should make the internal LRA client API not auto closable Key: JBTM-3225 URL: https://issues.jboss.org/browse/JBTM-3225 Project: JBoss Transaction Manager Issue Type: Task Components: LRA Affects Versions: 5.10.0.Final Reporter: Michael Musgrove Assignee: Michael Musgrove Fix For: 5.next The LRA implementation contains an internal client API called io.narayana.lra.client.NarayanaLRAClient which implements java.io.Closeable. A recent PR (see issue https://issues.jboss.org/browse/JBTM-3212) made the implementation of the close method a NOOP (since there is no longer any need for cleanup actions). But the method was left empty since there is a possibility that is will be needed in LRA version 1.x where a LRA client API will be added and since there are existing users of the client API. This task is a reminder to revisit the decision to remove java.io.Closeable prior to releasing an implementation of [version 1.0 of the LRA specification|https://github.com/eclipse/microprofile-lra/issues?q=is%3Ao...]. -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 12 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3222) Local LRA lookup should just use the Uid part of the LRA

by Michael Musgrove (Jira)

[ https://issues.jboss.org/browse/JBTM-3222?page=com.atlassian.jira.plugin.... ] Michael Musgrove updated JBTM-3222: ----------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/jbosstm/narayana/pull/1530 > Local LRA lookup should just use the Uid part of the LRA > -------------------------------------------------------- > > Key: JBTM-3222 > URL: https://issues.jboss.org/browse/JBTM-3222 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.10.0.Final > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Major > Fix For: 5.next > > > The LRA implementation identifies LRA's by their full JAX-RS resource path (aka URI). [Remark we use the full resource path in order to determine which host owns the LRA]. But when these URI's are calculated sometimes the base URI ends up as localhost and other times as 127.0.0.1 (or :1). The code in the coordinator that wants to know if it owns an LRA should avoid checking the whole path and instead just rely on the Uid part of the resource path (com.arjuna.ats.arjuna.common.Uid). This is safe since the URI is globally unique. Note that this technique only works for LRA ids created by narayana which is fine because the code that does the lookup is only interested in whether the local coordinator created the LRA (tangentially related but it is also noteworthy that we are not targeting interoperability in LRA version 1.0 > The particular code that does the lookup is in LRAService#getTransaction(). -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 12 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3224) Wrong formatting of error message when object store can't be initialized

by Thomas Jenkinson (Jira)

[ https://issues.jboss.org/browse/JBTM-3224?page=com.atlassian.jira.plugin.... ] Thomas Jenkinson updated JBTM-3224: ----------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done [~ochaloup] sorry, I should have resolved this when I merged it. Resolving now, please re-open if that is not correct. > Wrong formatting of error message when object store can't be initialized > ------------------------------------------------------------------------ > > Key: JBTM-3224 > URL: https://issues.jboss.org/browse/JBTM-3224 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: Transaction Core > Affects Versions: 5.10.0.Final > Reporter: Ondrej Chaloupka > Assignee: Ondrej Chaloupka > Priority: Minor > Fix For: 5.next > > > There is a wrong formatting of error message for init error of object store. This is output currently: > {code} > Caused by: com.arjuna.ats.arjuna.exceptions.FatalError: ARJUNA012391: Could not initialize object store {0} of type {1} > at org.jboss.jts//com.arjuna.ats.arjuna.objectstore.StoreManager.initStore(StoreManager.java:160) > at org.jboss.jts//com.arjuna.ats.arjuna.objectstore.StoreManager.getActionStore(StoreManager.java:111) > at org.jboss.jts//com.arjuna.ats.arjuna.objectstore.StoreManager.getRecoveryStore(StoreManager.java:68) > {code} > Coming from: > https://github.com/jbosstm/narayana/blob/5.10.0.Final/ArjunaCore/arjuna/c... > Desired state is to get the store and type to be printed. -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 12 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3224) Wrong formatting of error message when object store can't be initialized

by Thomas Jenkinson (Jira)

[ https://issues.jboss.org/browse/JBTM-3224?page=com.atlassian.jira.plugin.... ] Thomas Jenkinson updated JBTM-3224: ----------------------------------- Fix Version/s: 5.next > Wrong formatting of error message when object store can't be initialized > ------------------------------------------------------------------------ > > Key: JBTM-3224 > URL: https://issues.jboss.org/browse/JBTM-3224 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: Transaction Core > Affects Versions: 5.10.0.Final > Reporter: Ondrej Chaloupka > Assignee: Ondrej Chaloupka > Priority: Minor > Fix For: 5.next > > > There is a wrong formatting of error message for init error of object store. This is output currently: > {code} > Caused by: com.arjuna.ats.arjuna.exceptions.FatalError: ARJUNA012391: Could not initialize object store {0} of type {1} > at org.jboss.jts//com.arjuna.ats.arjuna.objectstore.StoreManager.initStore(StoreManager.java:160) > at org.jboss.jts//com.arjuna.ats.arjuna.objectstore.StoreManager.getActionStore(StoreManager.java:111) > at org.jboss.jts//com.arjuna.ats.arjuna.objectstore.StoreManager.getRecoveryStore(StoreManager.java:68) > {code} > Coming from: > https://github.com/jbosstm/narayana/blob/5.10.0.Final/ArjunaCore/arjuna/c... > Desired state is to get the store and type to be printed. -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 12 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

jbossts-issues December 2019