June 2019 - jbossts-issues - Jboss List Archives

[JBoss JIRA] (JBTM-3147) WS-AT participant which timeouts on prepare is not aborted and cancel is not retried but both are put to heuristic state

by Ondrej Chaloupka (Jira)

[ https://issues.jboss.org/browse/JBTM-3147?page=com.atlassian.jira.plugin.... ] Ondrej Chaloupka updated JBTM-3147: ----------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done > WS-AT participant which timeouts on prepare is not aborted and cancel is not retried but both are put to heuristic state > ------------------------------------------------------------------------------------------------------------------------ > > Key: JBTM-3147 > URL: https://issues.jboss.org/browse/JBTM-3147 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: XTS > Reporter: Ondrej Chaloupka > Assignee: Ondrej Chaloupka > Priority: Major > Fix For: 5.9.5.Final > > > When {{prepare}} on WS-AT participant timeouts (e.g. because of a communication error) such participant is marked as heuristic. That's not correct as timeouted communication during prepare is expected to be aborted. > This behaviour is confirmed by comments in the source code and tests expect such behaviour. > Unfortunately the returned error code makes opposite (marking participant as heuristic). The return code should do what the comment asks > https://github.com/jbosstm/narayana/blob/5.9.5.Final/XTS/WSCF/classes/com... > {quote} > // if prepare timed out then we return error so it goes back on the > // prepare list and is rolled back > {quote} > The same is correct for the {{cancel}} call on communication error. When cancel is called then it's expected to be retried and correct return code is needed to be returned. > See comment on the durable 2PC participant at https://github.com/jbosstm/narayana/blob/5.9.5.Final/XTS/WSTX/classes/com... > {quote} > // log an error here -- if the participant is dead it will retry anyway > {quote} -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 5 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3147) WS-AT participant which timeouts on prepare is not aborted and cancel is not retried but both are put to heuristic state

by Ondrej Chaloupka (Jira)

[ https://issues.jboss.org/browse/JBTM-3147?page=com.atlassian.jira.plugin.... ] Ondrej Chaloupka updated JBTM-3147: ----------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/jbosstm/narayana/pull/1391 > WS-AT participant which timeouts on prepare is not aborted and cancel is not retried but both are put to heuristic state > ------------------------------------------------------------------------------------------------------------------------ > > Key: JBTM-3147 > URL: https://issues.jboss.org/browse/JBTM-3147 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: XTS > Reporter: Ondrej Chaloupka > Assignee: Ondrej Chaloupka > Priority: Major > Fix For: 5.9.5.Final > > > When {{prepare}} on WS-AT participant timeouts (e.g. because of a communication error) such participant is marked as heuristic. That's not correct as timeouted communication during prepare is expected to be aborted. > This behaviour is confirmed by comments in the source code and tests expect such behaviour. > Unfortunately the returned error code makes opposite (marking participant as heuristic). The return code should do what the comment asks > https://github.com/jbosstm/narayana/blob/5.9.5.Final/XTS/WSCF/classes/com... > {quote} > // if prepare timed out then we return error so it goes back on the > // prepare list and is rolled back > {quote} > The same is correct for the {{cancel}} call on communication error. When cancel is called then it's expected to be retried and correct return code is needed to be returned. > See comment on the durable 2PC participant at https://github.com/jbosstm/narayana/blob/5.9.5.Final/XTS/WSTX/classes/com... > {quote} > // log an error here -- if the participant is dead it will retry anyway > {quote} -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 5 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3152) XTS over SSL Quickstart Failure

by Michael Musgrove (Jira)

[ https://issues.jboss.org/browse/JBTM-3152?page=com.atlassian.jira.plugin.... ] Michael Musgrove reassigned JBTM-3152: -------------------------------------- Assignee: Ondrej Chaloupka > XTS over SSL Quickstart Failure > ------------------------------- > > Key: JBTM-3152 > URL: https://issues.jboss.org/browse/JBTM-3152 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: Demonstrator > Affects Versions: 5.9.5.Final > Reporter: Michael Musgrove > Assignee: Ondrej Chaloupka > Priority: Major > Fix For: 5.9.5.Final > > > CI job narayana-quickstarts XTS over SSL Quickstart is failing regularly because the server is not reporting 'Transaction succeeded!': > > Doing the test by requesting 'http://localhost:8180/WSATSimpleServletClient' > > + curl -X GET http://localhost:8180/WSATSimpleServletClient > > + grep 'Transaction succeeded!' > See for example build: > http://narayanaci1.eng.hst.ams2.redhat.com/job/narayana-quickstarts/285/ -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3151) Fix for JBTM-3146 causes a regression when building with JDK 11

by Michael Musgrove (Jira)

[ https://issues.jboss.org/browse/JBTM-3151?page=com.atlassian.jira.plugin.... ] Michael Musgrove edited comment on JBTM-3151 at 6/3/19 11:33 AM: ----------------------------------------------------------------- The [PR 1454|https://github.com/jbosstm/narayana/pull/1454] reverts the fix for https://issues.jboss.org/browse/JBTM-3146 was (Author: mmusgrov): The PR reverts the fix for https://issues.jboss.org/browse/JBTM-3146 > Fix for JBTM-3146 causes a regression when building with JDK 11 > ---------------------------------------------------------------- > > Key: JBTM-3151 > URL: https://issues.jboss.org/browse/JBTM-3151 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: Build System > Affects Versions: 5.9.5.Final > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Major > Fix For: 5.next > > > The fix for JBTM-3146 (Better support for Quarkus) uses byte code inject at build time and this fails on JDK 11: > [ERROR] Failed to execute goal org.jboss.maven.plugins:maven-injection-plugin:1.0.2:bytecode (default) on project common: Unable to resolve method [com.arjuna.common.util.ConfigurationInfo#getSourceId]: java.io.IOException: invalid constant type: 18 -> [Help 1] -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3151) Fix for JBTM-3146 causes a regression when building with JDK 11

by Michael Musgrove (Jira)

[ https://issues.jboss.org/browse/JBTM-3151?page=com.atlassian.jira.plugin.... ] Michael Musgrove updated JBTM-3151: ----------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done > Fix for JBTM-3146 causes a regression when building with JDK 11 > ---------------------------------------------------------------- > > Key: JBTM-3151 > URL: https://issues.jboss.org/browse/JBTM-3151 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: Build System > Affects Versions: 5.9.5.Final > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Major > Fix For: 5.next > > > The fix for JBTM-3146 (Better support for Quarkus) uses byte code inject at build time and this fails on JDK 11: > [ERROR] Failed to execute goal org.jboss.maven.plugins:maven-injection-plugin:1.0.2:bytecode (default) on project common: Unable to resolve method [com.arjuna.common.util.ConfigurationInfo#getSourceId]: java.io.IOException: invalid constant type: 18 -> [Help 1] -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3151) Fix for JBTM-3146 causes a regression when building with JDK 11

by Michael Musgrove (Jira)

[ https://issues.jboss.org/browse/JBTM-3151?page=com.atlassian.jira.plugin.... ] Michael Musgrove updated JBTM-3151: ----------------------------------- Status: Pull Request Sent (was: Open) The PR reverts the fix for https://issues.jboss.org/browse/JBTM-3146 > Fix for JBTM-3146 causes a regression when building with JDK 11 > ---------------------------------------------------------------- > > Key: JBTM-3151 > URL: https://issues.jboss.org/browse/JBTM-3151 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: Build System > Affects Versions: 5.9.5.Final > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Major > Fix For: 5.next > > > The fix for JBTM-3146 (Better support for Quarkus) uses byte code inject at build time and this fails on JDK 11: > [ERROR] Failed to execute goal org.jboss.maven.plugins:maven-injection-plugin:1.0.2:bytecode (default) on project common: Unable to resolve method [com.arjuna.common.util.ConfigurationInfo#getSourceId]: java.io.IOException: invalid constant type: 18 -> [Help 1] -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3152) XTS over SSL Quickstart Failure

by Michael Musgrove (Jira)

Michael Musgrove created JBTM-3152: -------------------------------------- Summary: XTS over SSL Quickstart Failure Key: JBTM-3152 URL: https://issues.jboss.org/browse/JBTM-3152 Project: JBoss Transaction Manager Issue Type: Bug Components: Demonstrator Affects Versions: 5.9.5.Final Reporter: Michael Musgrove Fix For: 5.9.5.Final CI job narayana-quickstarts XTS over SSL Quickstart is failing regularly because the server is not reporting 'Transaction succeeded!': > Doing the test by requesting 'http://localhost:8180/WSATSimpleServletClient' > + curl -X GET http://localhost:8180/WSATSimpleServletClient > + grep 'Transaction succeeded!' See for example build: http://narayanaci1.eng.hst.ams2.redhat.com/job/narayana-quickstarts/285/ -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3146) Better support for Quarkus

by Michael Musgrove (Jira)

[ https://issues.jboss.org/browse/JBTM-3146?page=com.atlassian.jira.plugin.... ] Issue was automatically transitioned when Michael Musgrove created pull request #1454 in GitHub ----------------------------------------------------------------------------------------------- Status: Pull Request Sent (was: Reopened) > Better support for Quarkus > -------------------------- > > Key: JBTM-3146 > URL: https://issues.jboss.org/browse/JBTM-3146 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: Common > Affects Versions: 5.9.5.Final > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Major > Fix For: 5.next > > > To facilitate use of Narayana with containers such as Quarkus we want to minimise things like XML parsing and java archive parsing. The two main enhancements that would be useful in this respect are: > * to inject build information into a java class (via the org.jboss.maven.plugins:maven-injection-plugin plugin); > * to avoid the need for runtime parsing of XML properties it would be useful to allow the properties factory delegate to be supplied externally -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3146) Better support for Quarkus

by Michael Musgrove (Jira)

[ https://issues.jboss.org/browse/JBTM-3146?page=com.atlassian.jira.plugin.... ] Michael Musgrove reopened JBTM-3146: ------------------------------------ Reopening since fix fails on JDK11. The original changes need to be backed out. > Better support for Quarkus > -------------------------- > > Key: JBTM-3146 > URL: https://issues.jboss.org/browse/JBTM-3146 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: Common > Affects Versions: 5.9.5.Final > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Major > Fix For: 5.next > > > To facilitate use of Narayana with containers such as Quarkus we want to minimise things like XML parsing and java archive parsing. The two main enhancements that would be useful in this respect are: > * to inject build information into a java class (via the org.jboss.maven.plugins:maven-injection-plugin plugin); > * to avoid the need for runtime parsing of XML properties it would be useful to allow the properties factory delegate to be supplied externally -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3148) Remote JTA EJB transaction context propagation fails to correctly run 1PC

by Ondrej Chaloupka (Jira)

[ https://issues.jboss.org/browse/JBTM-3148?page=com.atlassian.jira.plugin.... ] Ondrej Chaloupka updated JBTM-3148: ----------------------------------- Summary: Remote JTA EJB transaction context propagation fails to correctly run 1PC (was: Remote JTA EJB tramsaction context propagation with fails to correctly run 1PC) > Remote JTA EJB transaction context propagation fails to correctly run 1PC > ------------------------------------------------------------------------- > > Key: JBTM-3148 > URL: https://issues.jboss.org/browse/JBTM-3148 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: JTA > Affects Versions: 5.9.5.Final > Reporter: Ondrej Chaloupka > Assignee: Ondrej Chaloupka > Priority: Major > > Remote JTA EJB transaction propagation works with the remote EJB XAResource as with any other resource which is JVM-local. As the first server uses only on participant (the remoting EJB XAResource) then the 1PC. When a failure happens at the remote side during the commit {{EJB remote XAResource.commit}} we can't define outcome. > Consider: > # first server calls a second server > # the first server uses as the resource only the remote call to the second server > # transaction context is propagated and used at the second server > # the second server makes some changes in database and sends data to JMS broker (2 {{XAResource}}s) > # 1PC is used to run commit on the only XAResource at the first server which is EJB remote {{XAResource}} > # the second server is called with one phase commit > # the calls is transformed to {{SubordinateAtomicAction#doOnePhaseCommit}} which runs {{AtomicAction#End}} to call 2PC on resources > # prepare on database resource and JMS resource is run > # commit runs on the database resource, then... > # JVM crashes before JMS broker is committed > # (or JMS broker is not accessible because because of a networking issue and exception on RA commit is thrown) > In case of the JVM crash heuristic outcome is saved to the object store at the first server. Administrator is expected to check what happened as the global transaction outcome is unknown. The 1PC doesn't save anything to Narayana object store. The database on the second server was committed while JMS delivery failed to commit. > The picture at the [forum discussion|https://developer.jboss.org/thread/279243] depicts the situation > https://developer.jboss.org/servlet/JiveServlet/showImage/2-989167-320301... > Heuristic outcome for remote JTA subordinate 1PC by https://issues.jboss.org/browse/JBTM-2443 > In case of the RA connection failure and in case the RA throws {{XAException.XAER_RMFAIL}} (or RETRY) - which is expected outcome when 2PC should be retried with recovery - the remote side obtains error information but 1PC only informs about error but has no record saved in the object store. Thus the transaction record is forgotten. > That's not right as the JMS RA is held in prepared state. As it's part of the subordinate transaction (at the second server) it will be never finished (responsibility of finishing subordinate transaction is for the parent transaction). As the first server (the parent one) did not save any data there is nobody to finish transaction to commit. > One option is to force the commit to return heuristic for administrator to finish the doubtful resource. Make it working the same way as the JVM crash scenario works (see above JBTM-2443). > The other option could be not permitting the 1PC for remote JTA subordinate XAResources at all. -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 6 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

jbossts-issues June 2019