July 2019 - jbossts-issues - Jboss List Archives

[JBoss JIRA] (JBTM-3161) Nested LRA doesn't start in the Spring Boot + JAX-RS application

by Matej Kralik (Jira)

[ https://issues.jboss.org/browse/JBTM-3161?page=com.atlassian.jira.plugin.... ] Matej Kralik updated JBTM-3161: ------------------------------- Component/s: LRA > Nested LRA doesn't start in the Spring Boot + JAX-RS application > ---------------------------------------------------------------- > > Key: JBTM-3161 > URL: https://issues.jboss.org/browse/JBTM-3161 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Reporter: Matej Kralik > Priority: Critical > Attachments: flight.zip > > > For demonstrating purpose, I migrated flight service from [narayana quickstart|https://github.com/jbosstm/quickstart/tree/master/rts/lra/flig...] to the Spring Boot application and uploaded it to the attachment. > When I stop debugger in the original swarm flight service (FlightParticipant [line 64|https://github.com/jbosstm/quickstart/blob/3b848517086c2abc32bff6895b2...]), the *_@HeaderParam(LRA_HTTP_CONTEXT_HEADER) String lraId_*, is new for that service. When I stop debugger in the SpringBoot+JAX-RS, the lraId is the same as for a parent. It looks that the _ServerLRAFilter_ doesn't start the new LRA. > I add a breakpoint to the *_ServerLRAFilter.filter(...)_* to see when the filter is applied and create new LRA before the JAX-RS method. When I call original swarm flight service, the filter is used however when I call SpringBoot flight service, the filter is not used so it looks that the filter is not used at all in the SpringBoot+JAX-RS application. -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3163) AfterLRA notifications are delivered twice

by Martin Stefanko (Jira)

[ https://issues.jboss.org/browse/JBTM-3163?page=com.atlassian.jira.plugin.... ] Martin Stefanko commented on JBTM-3163: --------------------------------------- [~mmusgrov] This blocks the work on non-JAX-RS participants implementation so I think Major priority is appropriate. > AfterLRA notifications are delivered twice > ------------------------------------------ > > Key: JBTM-3163 > URL: https://issues.jboss.org/browse/JBTM-3163 > Project: JBoss Transaction Manager > Issue Type: Task > Components: LRA > Affects Versions: 5.9.5.Final > Reporter: Martin Stefanko > Assignee: Martin Stefanko > Priority: Major > Original Estimate: 1 hour > Time Spent: 1 hour > Remaining Estimate: 0 minutes > > @AfterLRA notifications recently introduced in the specification are being delivered twice when the LRA is finished. > There is actually a TCK test testing this for non JAX-RS participant so this is blocking [PR 1450|https://github.com/jbosstm/narayana/pull/1450]. > The failing TCK test `TckParticipantTests#validWebApplicationExceptionReturnedTest` asserts now that `@AfterLRA` method is called once after the LRA is finished - https://github.com/eclipse/microprofile-lra/blob/master/tck/src/main/java.... This means that the specification prohibits that AfterLRA method is called more than once for one LRA. > This isn't failing current TCK as the assert is present in the non-JAX-RS TCK ([PR 1450|https://github.com/jbosstm/narayana/pull/1450]) -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3163) AfterLRA notifications are delivered twice

by Michael Musgrove (Jira)

[ https://issues.jboss.org/browse/JBTM-3163?page=com.atlassian.jira.plugin.... ] Michael Musgrove commented on JBTM-3163: ---------------------------------------- bq. The failing TCK test `TckParticipantTests#validWebApplicationExceptionReturnedTest` asserts now that `@AfterLRA` method is called once after the LRA is finished Doesn't this mean the test is wrong (or the spec is wrong for not being explicit here). The semantics are "at least once" so multiple attempts to deliver the notification should be allowed since delivery is not always guaranteed in an HTTP environment. We can fix the code so that it only delivers the notification once on each recovery pass but it is not Major priority. > AfterLRA notifications are delivered twice > ------------------------------------------ > > Key: JBTM-3163 > URL: https://issues.jboss.org/browse/JBTM-3163 > Project: JBoss Transaction Manager > Issue Type: Task > Components: LRA > Affects Versions: 5.9.5.Final > Reporter: Martin Stefanko > Assignee: Martin Stefanko > Priority: Major > Original Estimate: 1 hour > Time Spent: 1 hour > Remaining Estimate: 0 minutes > > @AfterLRA notifications recently introduced in the specification are being delivered twice when the LRA is finished. > There is actually a TCK test testing this for non JAX-RS participant so this is blocking [PR 1450|https://github.com/jbosstm/narayana/pull/1450]. > The failing TCK test `TckParticipantTests#validWebApplicationExceptionReturnedTest` asserts now that `@AfterLRA` method is called once after the LRA is finished - https://github.com/eclipse/microprofile-lra/blob/master/tck/src/main/java.... This means that the specification prohibits that AfterLRA method is called more than once for one LRA. > This isn't failing current TCK as the assert is present in the non-JAX-RS TCK ([PR 1450|https://github.com/jbosstm/narayana/pull/1450]) -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3163) AfterLRA notifications are delivered twice

by Martin Stefanko (Jira)

[ https://issues.jboss.org/browse/JBTM-3163?page=com.atlassian.jira.plugin.... ] Martin Stefanko edited comment on JBTM-3163 at 7/29/19 3:53 AM: ---------------------------------------------------------------- In [LRAService|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-co...] we have currently in the method [endLRA()|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coor...] calls: * on line [241|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinat...] - transaction.end() which calls -> [Transaction#doEnd|https://github.com/jbosstm/narayana/blob/master/rts/lra...] which on line [444|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinat...] calls [LRAService#finished|https://github.com/jbosstm/narayana/blob/master/rts/l...] * on line [250|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinat...] - call to [LRAService#finished|https://github.com/jbosstm/narayana/blob/master/rts/l...] again [LRAService#finished|https://github.com/jbosstm/narayana/blob/master/rts/l...] makes the final AfterLRA calls on line [152|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinat...] was (Author: mstefank): In [LRAService|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-co...] we have currently in the method [endLRA()|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coor...] calls: * on line [241|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinat...] - transaction.end() which calls -> [`Transaction#doEnd`|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinator/src/main/java/io/narayana/lra/coordinator/domain/model/Transaction.java#L351] which on line [444|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinat...] calls [`LRAService#finished`|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinator/src/main/java/io/narayana/lra/coordinator/domain/service/LRAService.java#L145] * on line [250|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinat...] - call to [`LRAService#finished`|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinator/src/main/java/io/narayana/lra/coordinator/domain/service/LRAService.java#L145] again [`LRAService#finished`|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinator/src/main/java/io/narayana/lra/coordinator/domain/service/LRAService.java#L145] makes the final AfterLRA calls on line [152|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinat...] > AfterLRA notifications are delivered twice > ------------------------------------------ > > Key: JBTM-3163 > URL: https://issues.jboss.org/browse/JBTM-3163 > Project: JBoss Transaction Manager > Issue Type: Task > Components: LRA > Affects Versions: 5.9.5.Final > Reporter: Martin Stefanko > Assignee: Martin Stefanko > Priority: Major > Original Estimate: 1 hour > Time Spent: 1 hour > Remaining Estimate: 0 minutes > > @AfterLRA notifications recently introduced in the specification are being delivered twice when the LRA is finished. > There is actually a TCK test testing this for non JAX-RS participant so this is blocking [PR 1450|https://github.com/jbosstm/narayana/pull/1450]. > The failing TCK test `TckParticipantTests#validWebApplicationExceptionReturnedTest` asserts now that `@AfterLRA` method is called once after the LRA is finished - https://github.com/eclipse/microprofile-lra/blob/master/tck/src/main/java.... This means that the specification prohibits that AfterLRA method is called more than once for one LRA. > This isn't failing current TCK as the assert is present in the non-JAX-RS TCK ([PR 1450|https://github.com/jbosstm/narayana/pull/1450]) -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3163) AfterLRA notifications are delivered twice

by Martin Stefanko (Jira)

[ https://issues.jboss.org/browse/JBTM-3163?page=com.atlassian.jira.plugin.... ] Martin Stefanko commented on JBTM-3163: --------------------------------------- In [LRAService|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-co...] we have currently in the method [endLRA()|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coor...] calls: * on line [241|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinat...] - transaction.end() which calls -> [`Transaction#doEnd`|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinator/src/main/java/io/narayana/lra/coordinator/domain/model/Transaction.java#L351] which on line [444|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinat...] calls [`LRAService#finished`|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinator/src/main/java/io/narayana/lra/coordinator/domain/service/LRAService.java#L145] * on line [250|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinat...] - call to [`LRAService#finished`|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinator/src/main/java/io/narayana/lra/coordinator/domain/service/LRAService.java#L145] again [`LRAService#finished`|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinator/src/main/java/io/narayana/lra/coordinator/domain/service/LRAService.java#L145] makes the final AfterLRA calls on line [152|https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinat...] > AfterLRA notifications are delivered twice > ------------------------------------------ > > Key: JBTM-3163 > URL: https://issues.jboss.org/browse/JBTM-3163 > Project: JBoss Transaction Manager > Issue Type: Task > Components: LRA > Affects Versions: 5.9.5.Final > Reporter: Martin Stefanko > Assignee: Martin Stefanko > Priority: Major > Original Estimate: 1 hour > Time Spent: 1 hour > Remaining Estimate: 0 minutes > > @AfterLRA notifications recently introduced in the specification are being delivered twice when the LRA is finished. > There is actually a TCK test testing this for non JAX-RS participant so this is blocking [PR 1450|https://github.com/jbosstm/narayana/pull/1450]. > The failing TCK test `TckParticipantTests#validWebApplicationExceptionReturnedTest` asserts now that `@AfterLRA` method is called once after the LRA is finished - https://github.com/eclipse/microprofile-lra/blob/master/tck/src/main/java.... This means that the specification prohibits that AfterLRA method is called more than once for one LRA. > This isn't failing current TCK as the assert is present in the non-JAX-RS TCK ([PR 1450|https://github.com/jbosstm/narayana/pull/1450]) -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3163) AfterLRA notifications are delivered twice

by Martin Stefanko (Jira)

[ https://issues.jboss.org/browse/JBTM-3163?page=com.atlassian.jira.plugin.... ] Martin Stefanko updated JBTM-3163: ---------------------------------- Description: @AfterLRA notifications recently introduced in the specification are being delivered twice when the LRA is finished. There is actually a TCK test testing this for non JAX-RS participant so this is blocking [PR 1450|https://github.com/jbosstm/narayana/pull/1450]. The failing TCK test `TckParticipantTests#validWebApplicationExceptionReturnedTest` asserts now that `@AfterLRA` method is called once after the LRA is finished - https://github.com/eclipse/microprofile-lra/blob/master/tck/src/main/java.... This means that the specification prohibits that AfterLRA method is called more than once for one LRA. This isn't failing current TCK as the assert is present in the non-JAX-RS TCK ([PR 1450|https://github.com/jbosstm/narayana/pull/1450]) was: @AfterLRA notifications recently introduced in the specification are being delivered twice when the LRA is finished. There is actually a TCK test testing this for non JAX-RS participant so this is blocking [PR 1450|https://github.com/jbosstm/narayana/pull/1450]. The failing TCK test `TckParticipantTests#validWebApplicationExceptionReturnedTest` asserts now that `@AfterLRA` method is called once after the LRA is finished - https://github.com/eclipse/microprofile-lra/blob/master/tck/src/main/java.... This means that the specification prohibits that AfterLRA method is called more than once for one LRA. This isn't failing current TCK as the assert is present in the non-JAX-RS TCK ([PR 1450|https://github.com/jbosstm/narayana/pull/1450] > AfterLRA notifications are delivered twice > ------------------------------------------ > > Key: JBTM-3163 > URL: https://issues.jboss.org/browse/JBTM-3163 > Project: JBoss Transaction Manager > Issue Type: Task > Components: LRA > Affects Versions: 5.9.5.Final > Reporter: Martin Stefanko > Assignee: Martin Stefanko > Priority: Major > Original Estimate: 1 hour > Time Spent: 1 hour > Remaining Estimate: 0 minutes > > @AfterLRA notifications recently introduced in the specification are being delivered twice when the LRA is finished. > There is actually a TCK test testing this for non JAX-RS participant so this is blocking [PR 1450|https://github.com/jbosstm/narayana/pull/1450]. > The failing TCK test `TckParticipantTests#validWebApplicationExceptionReturnedTest` asserts now that `@AfterLRA` method is called once after the LRA is finished - https://github.com/eclipse/microprofile-lra/blob/master/tck/src/main/java.... This means that the specification prohibits that AfterLRA method is called more than once for one LRA. > This isn't failing current TCK as the assert is present in the non-JAX-RS TCK ([PR 1450|https://github.com/jbosstm/narayana/pull/1450]) -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3163) AfterLRA notifications are delivered twice

by Martin Stefanko (Jira)

[ https://issues.jboss.org/browse/JBTM-3163?page=com.atlassian.jira.plugin.... ] Martin Stefanko updated JBTM-3163: ---------------------------------- Description: @AfterLRA notifications recently introduced in the specification are being delivered twice when the LRA is finished. There is actually a TCK test testing this for non JAX-RS participant so this is blocking [PR 1450|https://github.com/jbosstm/narayana/pull/1450]. The failing TCK test `TckParticipantTests#validWebApplicationExceptionReturnedTest` asserts now that `@AfterLRA` method is called once after the LRA is finished - https://github.com/eclipse/microprofile-lra/blob/master/tck/src/main/java.... This means that the specification prohibits that AfterLRA method is called more than once for one LRA. This isn't failing current TCK as the assert is present in the non-JAX-RS TCK ([PR 1450|https://github.com/jbosstm/narayana/pull/1450] was: @AfterLRA notifications recently introduced in the specification are being delivered twice when the LRA is finished. There is actually a TCK test testing this for non JAX-RS participant so this is blocking [PR 1450|https://github.com/jbosstm/narayana/pull/1450]. The failing TCK test `TckParticipantTests#validWebApplicationExceptionReturnedTest` asserts now that `@AfterLRA` method is called once after the LRA is finished - https://github.com/eclipse/microprofile-lra/blob/master/tck/src/main/java.... This means that the specification prohibits that AfterLRA method is called more than once for one LRA. > AfterLRA notifications are delivered twice > ------------------------------------------ > > Key: JBTM-3163 > URL: https://issues.jboss.org/browse/JBTM-3163 > Project: JBoss Transaction Manager > Issue Type: Task > Components: LRA > Affects Versions: 5.9.5.Final > Reporter: Martin Stefanko > Assignee: Martin Stefanko > Priority: Major > Original Estimate: 1 hour > Time Spent: 1 hour > Remaining Estimate: 0 minutes > > @AfterLRA notifications recently introduced in the specification are being delivered twice when the LRA is finished. > There is actually a TCK test testing this for non JAX-RS participant so this is blocking [PR 1450|https://github.com/jbosstm/narayana/pull/1450]. > The failing TCK test `TckParticipantTests#validWebApplicationExceptionReturnedTest` asserts now that `@AfterLRA` method is called once after the LRA is finished - https://github.com/eclipse/microprofile-lra/blob/master/tck/src/main/java.... This means that the specification prohibits that AfterLRA method is called more than once for one LRA. > This isn't failing current TCK as the assert is present in the non-JAX-RS TCK ([PR 1450|https://github.com/jbosstm/narayana/pull/1450] -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3163) AfterLRA notifications are delivered twice

by Martin Stefanko (Jira)

[ https://issues.jboss.org/browse/JBTM-3163?page=com.atlassian.jira.plugin.... ] Martin Stefanko updated JBTM-3163: ---------------------------------- Description: @AfterLRA notifications recently introduced in the specification are being delivered twice when the LRA is finished. There is actually a TCK test testing this for non JAX-RS participant so this is blocking [PR 1450|https://github.com/jbosstm/narayana/pull/1450]. The failing TCK test `TckParticipantTests#validWebApplicationExceptionReturnedTest` asserts now that `@AfterLRA` method is called once after the LRA is finished - https://github.com/eclipse/microprofile-lra/blob/master/tck/src/main/java.... This means that the specification prohibits that AfterLRA method is called more than once for one LRA. was: @AfterLRA notifications recently introduced in the specification are being delivered twice when the LRA is finished. There is actually a TCK test testing this for non JAX-RS participant so this is blocking [PR 1450|https://github.com/jbosstm/narayana/pull/1450]. > AfterLRA notifications are delivered twice > ------------------------------------------ > > Key: JBTM-3163 > URL: https://issues.jboss.org/browse/JBTM-3163 > Project: JBoss Transaction Manager > Issue Type: Task > Components: LRA > Affects Versions: 5.9.5.Final > Reporter: Martin Stefanko > Assignee: Martin Stefanko > Priority: Major > Original Estimate: 1 hour > Time Spent: 1 hour > Remaining Estimate: 0 minutes > > @AfterLRA notifications recently introduced in the specification are being delivered twice when the LRA is finished. > There is actually a TCK test testing this for non JAX-RS participant so this is blocking [PR 1450|https://github.com/jbosstm/narayana/pull/1450]. > The failing TCK test `TckParticipantTests#validWebApplicationExceptionReturnedTest` asserts now that `@AfterLRA` method is called once after the LRA is finished - https://github.com/eclipse/microprofile-lra/blob/master/tck/src/main/java.... This means that the specification prohibits that AfterLRA method is called more than once for one LRA. -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3163) AfterLRA notifications are delivered twice

by Martin Stefanko (Jira)

[ https://issues.jboss.org/browse/JBTM-3163?focusedWorklogId=12447543&page=... ] Martin Stefanko logged work on JBTM-3163: ----------------------------------------- Author: Martin Stefanko Created on: 29/Jul/19 1:42 AM Start Date: 29/Jul/19 1:42 AM Worklog Time Spent: 1 hour Issue Time Tracking ------------------- Remaining Estimate: 0 minutes (was: 1 hour) Time Spent: 1 hour Worklog Id: (was: 12447543) > AfterLRA notifications are delivered twice > ------------------------------------------ > > Key: JBTM-3163 > URL: https://issues.jboss.org/browse/JBTM-3163 > Project: JBoss Transaction Manager > Issue Type: Task > Components: LRA > Affects Versions: 5.9.5.Final > Reporter: Martin Stefanko > Assignee: Martin Stefanko > Priority: Major > Original Estimate: 1 hour > Time Spent: 1 hour > Remaining Estimate: 0 minutes > > @AfterLRA notifications recently introduced in the specification are being delivered twice when the LRA is finished. > There is actually a TCK test testing this for non JAX-RS participant so this is blocking [PR 1450|https://github.com/jbosstm/narayana/pull/1450]. -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3163) AfterLRA notifications are delivered twice

by Anonymous (Jira)

[ https://issues.jboss.org/browse/JBTM-3163?page=com.atlassian.jira.plugin.... ] Issue was automatically transitioned when Martin Stefanko created pull request #1468 in GitHub ---------------------------------------------------------------------------------------------- Status: Pull Request Sent (was: Open) > AfterLRA notifications are delivered twice > ------------------------------------------ > > Key: JBTM-3163 > URL: https://issues.jboss.org/browse/JBTM-3163 > Project: JBoss Transaction Manager > Issue Type: Task > Components: LRA > Affects Versions: 5.9.5.Final > Reporter: Martin Stefanko > Assignee: Martin Stefanko > Priority: Major > Original Estimate: 1 hour > Remaining Estimate: 1 hour > > @AfterLRA notifications recently introduced in the specification are being delivered twice when the LRA is finished. > There is actually a TCK test testing this for non JAX-RS participant so this is blocking [PR 1450|https://github.com/jbosstm/narayana/pull/1450]. -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

jbossts-issues July 2019