June 2020 - jbossts-issues - Jboss List Archives

[JBoss JIRA] (JBTM-3324) Fix the findings of the static code analysis by Coverity

by Ondrej Chaloupka (Jira)

[ https://issues.redhat.com/browse/JBTM-3324?page=com.atlassian.jira.plugin... ] Ondrej Chaloupka updated JBTM-3324: ----------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/jbosstm/narayana/pull/1630 > Fix the findings of the static code analysis by Coverity > -------------------------------------------------------- > > Key: JBTM-3324 > URL: https://issues.redhat.com/browse/JBTM-3324 > Project: JBoss Transaction Manager > Issue Type: Bug > Affects Versions: 5.10.4.Final > Reporter: Ondrej Chaloupka > Assignee: Ondrej Chaloupka > Priority: Minor > > I've checked the new records found by Coverity static analysis tool (one running by EAP QE team, with more info on internal page https://mojo.redhat.com/docs/DOC-180330). > There are two bugs that should be considered to be fixed,: > * {{RecoveryManager#terminate}} changes the recovery manager instance to {{null}}. But the {{_recoveryManager}} is a static variable which should be synchorinzed on class not on the instance. Especially when {{#manager(boolean}} method is {{public static}}, see https://github.com/jbosstm/narayana/blob/5.10.5.Final/ArjunaCore/arjuna/c... > * If the {{XAResourceRecord}} is called with {{params != null}} then the check verifies if the params length is with equal or more than the value of constant {{XACONNECTION}}. If the constant {{XACONNECTION}} is zero then for empty params array the access to {{params[0]}} will fail with {{ArrayIndexOutOfBoundsException}}, see https://github.com/jbosstm/narayana/blob/5.10.5.Final/ArjunaJTA/jta/class... > Plus few minor ones. -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3324) Fix the findings of the static code analysis by Coverity

by Ondrej Chaloupka (Jira)

Ondrej Chaloupka created JBTM-3324: -------------------------------------- Summary: Fix the findings of the static code analysis by Coverity Key: JBTM-3324 URL: https://issues.redhat.com/browse/JBTM-3324 Project: JBoss Transaction Manager Issue Type: Bug Affects Versions: 5.10.4.Final Reporter: Ondrej Chaloupka Assignee: Ondrej Chaloupka I've checked the new records found by Coverity static analysis tool (one running by EAP QE team, with more info on internal page https://mojo.redhat.com/docs/DOC-180330). There are two bugs that should be considered to be fixed,: * {{RecoveryManager#terminate}} changes the recovery manager instance to {{null}}. But the {{_recoveryManager}} is a static variable which should be synchorinzed on class not on the instance. Especially when {{#manager(boolean}} method is {{public static}}, see https://github.com/jbosstm/narayana/blob/5.10.5.Final/ArjunaCore/arjuna/c... * If the {{XAResourceRecord}} is called with {{params != null}} then the check verifies if the params length is with equal or more than the value of constant {{XACONNECTION}}. If the constant {{XACONNECTION}} is zero then for empty params array the access to {{params[0]}} will fail with {{ArrayIndexOutOfBoundsException}}, see https://github.com/jbosstm/narayana/blob/5.10.5.Final/ArjunaJTA/jta/class... Plus few minor ones. -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3323) LRA server filter is registered twice

by Martin Stefanko (Jira)

[ https://issues.redhat.com/browse/JBTM-3323?page=com.atlassian.jira.plugin... ] Martin Stefanko updated JBTM-3323: ---------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/jbosstm/narayana/pull/1629 > LRA server filter is registered twice > ------------------------------------- > > Key: JBTM-3323 > URL: https://issues.redhat.com/browse/JBTM-3323 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.10.5.Final > Reporter: Michael Musgrove > Assignee: Martin Stefanko > Priority: Critical > Fix For: 5.next > > > The LRA ServerLRAFilter is being registered twice, once implicitly because ServerLRAFilter is a Provider, and once explicitly in FilterRegistration. Resteasy ignores the second registration but this is not the case for other JAX-RS implementations such as Apache CXF and the endpoints may be registered twice. In particular this can result in 2 LRAs being created for the same client request. -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3323) LRA server filter is registered twice

by Martin Stefanko (Jira)

[ https://issues.redhat.com/browse/JBTM-3323?page=com.atlassian.jira.plugin... ] Martin Stefanko reassigned JBTM-3323: ------------------------------------- Assignee: Martin Stefanko (was: Michael Musgrove) > LRA server filter is registered twice > ------------------------------------- > > Key: JBTM-3323 > URL: https://issues.redhat.com/browse/JBTM-3323 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.10.5.Final > Reporter: Michael Musgrove > Assignee: Martin Stefanko > Priority: Critical > Fix For: 5.next > > > The LRA ServerLRAFilter is being registered twice, once implicitly because ServerLRAFilter is a Provider, and once explicitly in FilterRegistration. Resteasy ignores the second registration but this is not the case for other JAX-RS implementations such as Apache CXF and the endpoints may be registered twice. In particular this can result in 2 LRAs being created for the same client request. -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3323) LRA server filter is registered twice

by Michael Musgrove (Jira)

Michael Musgrove created JBTM-3323: -------------------------------------- Summary: LRA server filter is registered twice Key: JBTM-3323 URL: https://issues.redhat.com/browse/JBTM-3323 Project: JBoss Transaction Manager Issue Type: Bug Components: LRA Affects Versions: 5.10.5.Final Reporter: Michael Musgrove Assignee: Michael Musgrove Fix For: 5.next The LRA ServerLRAFilter is being registered twice, once implicitly because ServerLRAFilter is a Provider, and once explicitly in FilterRegistration. Resteasy ignores the second registration but this is not the case for other JAX-RS implementations such as Apache CXF and the endpoints may be registered twice. In particular this can result in 2 LRAs being created for the same client request. -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3322) Quickstart shell scripts should consider MFACTOR for any used timeout

by Ondrej Chaloupka (Jira)

[ https://issues.redhat.com/browse/JBTM-3322?page=com.atlassian.jira.plugin... ] Ondrej Chaloupka updated JBTM-3322: ----------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/jbosstm/quickstart/pull/285 > Quickstart shell scripts should consider MFACTOR for any used timeout > --------------------------------------------------------------------- > > Key: JBTM-3322 > URL: https://issues.redhat.com/browse/JBTM-3322 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: Quickstarts > Affects Versions: 5.10.4.Final > Reporter: Ondrej Chaloupka > Assignee: Ondrej Chaloupka > Priority: Major > > Some of the Narayana quickstarts uses the shell scripts to run the quickstarts. > Some of them use the {{sleep}} or waiting for some time to get response. Any of these attempts which are using timeout to wait/sleep should be using factor of timeout that could be set in jenkins job which starts the quickstarts scripts. > For the Narayana CI AMS the we hit failures where server is not started fast enough and failure occurs. > E.g. in the next snippet the LRA thorntail was not able to start in 10 seconds > {code} > + echo '===== starting service on port 8082' > ===== starting service on port 8082 > + service_pid=22993 > + sleep 10 > + java -Djava.net.preferIPv4Stack=true -Djava.net.preferIPv4Addresses -Dthorntail.http.port=8082 -Dlra.http.port=8080 -Dthorntail.transactions.object-store-path=../txlogs -jar target/lra-participant-example-thorntail.jar > 2020-05-19 07:31:21,337 WARN [org.jboss.as.dependency.private] (MSC service thread 1-6) WFLYSRV0018: Deployment "deployment.lra-coordinator.war" is using a private module ("org.jboss.jts") which may be changed or removed in future versions without notice. > 2020-05-19 07:31:21,353 INFO [org.jboss.weld.deployer] (MSC service thread 1-7) WFLYWELD0003: Processing weld deployment lra-coordinator.war > 2020-05-19 07:31:28,225 INFO [org.jboss.as] (MSC service thread 1-2) WFLYSRV0049: Thorntail 2.6.0.Final (WildFly Core 10.0.3.Final) starting > 2020-05-19 07:31:28,268 INFO [org.wildfly.swarm] (MSC service thread 1-2) THORN0019: Install MSC service for command line args: [] > 2020-05-19 07:31:29,370 INFO [org.wildfly.extension.undertow] (MSC service thread 1-4) WFLYUT0012: Started server default-server. > 2020-05-19 07:31:30,942 INFO [org.wildfly.extension.undertow] (MSC service thread 1-4) WFLYUT0018: Host default-host starting > + '[' '' = true ']' > + echo '===== testing service' > + test_service '1 completed and 0 compensated' > ===== testing service > + curl -4 -X PUT -I http://localhost:8082/cdi > % Total % Received % Xferd Average Speed Time Time Time Current > Dload Upload Total Spent Left Speed > 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 > 0 74 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 > HTTP/1.1 404 Not Found > ... > 2020-05-19 07:31:32,469 INFO [org.jboss.as.server] (main) WFLYSRV0010: Deployed "lra-participant-example.war" (runtime-name : "lra-participant-example.war") > 2020-05-19 07:31:32,475 INFO [org.wildfly.swarm] (main) THORN99999: Thorntail is Ready > {code} -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3322) Quickstart shell scripts should consider MFACTOR for any used timeout

by Ondrej Chaloupka (Jira)

Ondrej Chaloupka created JBTM-3322: -------------------------------------- Summary: Quickstart shell scripts should consider MFACTOR for any used timeout Key: JBTM-3322 URL: https://issues.redhat.com/browse/JBTM-3322 Project: JBoss Transaction Manager Issue Type: Bug Components: Quickstarts Affects Versions: 5.10.4.Final Reporter: Ondrej Chaloupka Assignee: Ondrej Chaloupka Some of the Narayana quickstarts uses the shell scripts to run the quickstarts. Some of them use the {{sleep}} or waiting for some time to get response. Any of these attempts which are using timeout to wait/sleep should be using factor of timeout that could be set in jenkins job which starts the quickstarts scripts. For the Narayana CI AMS the we hit failures where server is not started fast enough and failure occurs. E.g. in the next snippet the LRA thorntail was not able to start in 10 seconds {code} + echo '===== starting service on port 8082' ===== starting service on port 8082 + service_pid=22993 + sleep 10 + java -Djava.net.preferIPv4Stack=true -Djava.net.preferIPv4Addresses -Dthorntail.http.port=8082 -Dlra.http.port=8080 -Dthorntail.transactions.object-store-path=../txlogs -jar target/lra-participant-example-thorntail.jar 2020-05-19 07:31:21,337 WARN [org.jboss.as.dependency.private] (MSC service thread 1-6) WFLYSRV0018: Deployment "deployment.lra-coordinator.war" is using a private module ("org.jboss.jts") which may be changed or removed in future versions without notice. 2020-05-19 07:31:21,353 INFO [org.jboss.weld.deployer] (MSC service thread 1-7) WFLYWELD0003: Processing weld deployment lra-coordinator.war 2020-05-19 07:31:28,225 INFO [org.jboss.as] (MSC service thread 1-2) WFLYSRV0049: Thorntail 2.6.0.Final (WildFly Core 10.0.3.Final) starting 2020-05-19 07:31:28,268 INFO [org.wildfly.swarm] (MSC service thread 1-2) THORN0019: Install MSC service for command line args: [] 2020-05-19 07:31:29,370 INFO [org.wildfly.extension.undertow] (MSC service thread 1-4) WFLYUT0012: Started server default-server. 2020-05-19 07:31:30,942 INFO [org.wildfly.extension.undertow] (MSC service thread 1-4) WFLYUT0018: Host default-host starting + '[' '' = true ']' + echo '===== testing service' + test_service '1 completed and 0 compensated' ===== testing service + curl -4 -X PUT -I http://localhost:8082/cdi % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 74 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 HTTP/1.1 404 Not Found ... 2020-05-19 07:31:32,469 INFO [org.jboss.as.server] (main) WFLYSRV0010: Deployed "lra-participant-example.war" (runtime-name : "lra-participant-example.war") 2020-05-19 07:31:32,475 INFO [org.wildfly.swarm] (main) THORN99999: Thorntail is Ready {code} -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 6 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

jbossts-issues June 2020