com.arjuna.ats.internal.jdbc.DynamicClass.shutdownDataSource(XADataSource) is never called ------------------------------------------------------------------------------------------ Key: JBTM-531 URL: https://issues.jboss.org/browse/JBTM-531 Project: JBoss Transaction Manager Issue Type: Bug Security Level: Public(Everyone can see) Components: Resource Manager Affects Versions: 4.5.0, 4.6.0 Reporter: Mauro Molinari Assignee: Tom Jenkinson Priority: Critical Fix For: 6.0.0.Final com.arjuna.ats.internal.jdbc.DynamicClass.shutdownDataSource(XADataSource) is never called by com.arjuna.ats.internal.jdbc.DirectRecoverableConnection. From what I could understand (but I'm not sure of this), after calling com.arjuna.ats.internal.jdbc.DirectRecoverableConnection.closeCloseCurrentConnection() the DirectRecoverableConnection won't be used anymore, so that method could be a good candidate to call _dynamicConnection.shutDownDataSource(_theDataSource) and to null both _dynamicConnection and _theDataSource. This problem could be quite severe, because if the XADataSource needs to be shut down in order to release resources, this could lead to leaks. Moreover, I was wondering if a caching of the dynamic class wouldn't be a good idea... as of now, a NEW XA data source is created every time a new connection is requested... and this could be expensive...