February 2011 - jbossts-issues - Jboss List Archives

[JBoss JIRA] Created: (JBTM-634) Make sources and javadoc available

by Thomas Diesler (JIRA)

Make sources and javadoc available ---------------------------------- Key: JBTM-634 URL: https://jira.jboss.org/jira/browse/JBTM-634 Project: JBoss Transaction Manager Issue Type: Sub-task Security Level: Public (Everyone can see) Reporter: Thomas Diesler IDEs like Eclipse and IntelliJ allow you to download sources and javadoc automatically from the maven repo Please make these available for the jbossjta releases -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

3
11
0 / 0

[JBoss JIRA] Created: (JBTM-633) Generate meaningful POM

by Thomas Diesler (JIRA)

Generate meaningful POM ----------------------- Key: JBTM-633 URL: https://jira.jboss.org/jira/browse/JBTM-633 Project: JBoss Transaction Manager Issue Type: Sub-task Security Level: Public (Everyone can see) Reporter: Thomas Diesler The POM should contain meaningful information, like dependencies, SVN location, etc Currently this probably generated by deploy:deploy-file <project> <modelVersion>4.0.0</modelVersion> <groupId>jboss.jbossts</groupId> <artifactId>jbossjta</artifactId> <version>4.4.0.GA</version> </project> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

3
9
0 / 0

[JBoss JIRA] Created: (JBTM-631) Generate proper maven artefacts

by Thomas Diesler (JIRA)

Generate proper maven artefacts ------------------------------- Key: JBTM-631 URL: https://jira.jboss.org/jira/browse/JBTM-631 Project: JBoss Transaction Manager Issue Type: Task Security Level: Public (Everyone can see) Reporter: Thomas Diesler The artefacts under jbossts (http://repository.jboss.org/maven2/jboss/jbossts/jbossjta) don't seem to be in sync with the project releases. * jbossjta-4.4.0.GA being the latest -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

3
6
0 / 0

[JBoss JIRA] Created: (JBTM-659) support ipv6

by Jonathan Halliday (JIRA)

support ipv6 ------------ Key: JBTM-659 URL: https://jira.jboss.org/jira/browse/JBTM-659 Project: JBoss Transaction Manager Issue Type: Feature Request Security Level: Public (Everyone can see) Components: Testing Reporter: Jonathan Halliday Assignee: Jonathan Halliday Fix For: 4.10.0 The changes to Uid in JBTM-522 pave the way for full IPv6 support in the codebase. Although ad-hoc testing gives good results, we really need to modify the test setup and servers to ensure a reasonable subset of tests are run on IPv6. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 3 months

5
22
0 / 0

[JBoss JIRA] Created: (JBTM-783) Test crash recovery when client, partiicpant and coordinator are deployed piecemeal

by Andrew Dinn (JIRA)

Test crash recovery when client, partiicpant and coordinator are deployed piecemeal ----------------------------------------------------------------------------------- Key: JBTM-783 URL: https://jira.jboss.org/browse/JBTM-783 Project: JBoss Transaction Manager Issue Type: Task Security Level: Public (Everyone can see) Components: XTS Affects Versions: 4.12.0 Reporter: Andrew Dinn Assignee: Andrew Dinn Fix For: 4.13.0 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 3 months

4
10
0 / 0

[JBoss JIRA] Created: (JBTM-576) update unit tests

by Jonathan Halliday (JIRA)

update unit tests ----------------- Key: JBTM-576 URL: https://jira.jboss.org/jira/browse/JBTM-576 Project: JBoss Transaction Manager Issue Type: Task Security Level: Public (Everyone can see) Components: Testing Affects Versions: 4.7.0 Reporter: Jonathan Halliday Assignee: Jonathan Halliday Fix For: 4.8.0 There are many unit tests that have lain dormant for some time. Convert them from DTF/junit3 to junit4, wire them to the build and make them pass. This will be done incrementally, one module at a time, following the dependency chain e.g. common, ArjunaCore/arjuna, ArjunaCore/txoj, ... JTA/, .../JTS/... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 3 months

4
14
0 / 0

[JBoss JIRA] Created: (JBTM-522) Update UID to support ipv6 and ipv4

by Mark Little (JIRA)

Update UID to support ipv6 and ipv4 ----------------------------------- Key: JBTM-522 URL: https://jira.jboss.org/jira/browse/JBTM-522 Project: JBoss Transaction Manager Issue Type: Task Security Level: Public (Everyone can see) Components: Transaction Core Affects Versions: 4.6.0 Reporter: Mark Little Assignee: Mark Little Fix For: 5.0.0 It's possible to have a version that supports both v4 and v6. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 3 months

5
14
0 / 0

[JBoss JIRA] Created: (JBTM-531) com.arjuna.ats.internal.jdbc.DynamicClass.shutdownDataSource(XADataSource) is never called

by Mauro Molinari (JIRA)

com.arjuna.ats.internal.jdbc.DynamicClass.shutdownDataSource(XADataSource) is never called ------------------------------------------------------------------------------------------ Key: JBTM-531 URL: https://jira.jboss.org/jira/browse/JBTM-531 Project: JBoss Transaction Manager Issue Type: Bug Security Level: Public (Everyone can see) Components: JTA Affects Versions: 4.6.0, 4.5.0 Reporter: Mauro Molinari Priority: Critical com.arjuna.ats.internal.jdbc.DynamicClass.shutdownDataSource(XADataSource) is never called by com.arjuna.ats.internal.jdbc.DirectRecoverableConnection. >From what I could understand (but I'm not sure of this), after calling com.arjuna.ats.internal.jdbc.DirectRecoverableConnection.closeCloseCurrentConnection() the DirectRecoverableConnection won't be used anymore, so that method could be a good candidate to call _dynamicConnection.shutDownDataSource(_theDataSource) and to null both _dynamicConnection and _theDataSource. This problem could be quite severe, because if the XADataSource needs to be shut down in order to release resources, this could lead to leaks. Moreover, I was wondering if a caching of the dynamic class wouldn't be a good idea... as of now, a NEW XA data source is created every time a new connection is requested... and this could be expensive... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 6 months

3
5
0 / 0

[JBoss JIRA] Created: (JBTM-764) ConnectionImple/RecoverableConnection leak in ConnectionManager because of the pooling

by Mauro Molinari (JIRA)

ConnectionImple/RecoverableConnection leak in ConnectionManager because of the pooling -------------------------------------------------------------------------------------- Key: JBTM-764 URL: https://jira.jboss.org/browse/JBTM-764 Project: JBoss Transaction Manager Issue Type: Bug Security Level: Public (Everyone can see) Components: JTA Affects Versions: 4.6.1 Environment: JBossTS JTA embedded in a webapp with Spring Reporter: Mauro Molinari Priority: Critical This is indirectly related to JBTM-529. Suppose you are using JBossTS JTA within your webapp, configured using Spring and using the DynamicClass mechanism to get connections. Suppose you're doing connection pooling under JBossTS: that is, the DynamicClass implementation is pooling XA connections from the actual XADataSource provided by the DBMS JDBC driver. This is a different approach from the one described in JBTM-529 and we switched to this one because of the problems encountered with JBTM-529, thinking that it could be a more correct approach. In this scenario, the client application code is doing the following: - start a transaction - request a new JDBC connection: this can be done either by using the DriverManager or by using Spring SimpleDriverDataSource; JBossTS JTA TransactionalDriver actually creates a new ConnectionImple, which asks the DynamicClass implementation to get a new XAConnection and gets a physical JDBC connection from that XAConnection; because of the XAConnection pooling provided by the DynamicClass implementation, this XAConnection might be a new one or a reused one, but I think this is not relevant to the problem - do what you have to do with the connection - close the connection: this causes the invocation of ConnectionImple.close - do other things within the transaction - commit the transaction Now, what I see is this: com.arjuna.ats.internal.jdbc.ConnectionImple.close() does the following check: if (!_recoveryConnection.inuse()) { ConnectionManager.remove(this); // finalize? } The problem is that since the transaction is still active, _recoveryConnection.inuse() returns true, because it checks for the XAResource associated with it: in the case of DirectRecoverableConnection, this is done when com.arjuna.ats.internal.jdbc.DirectRecoverableConnection.reset() is invoked, that is when the RecoverableConnection is closed, and so when the transaction terminates. The ultimate effect is that the ConnectionImple is never removed from the caching map of ConnectionManager, because it should have been when the connection was closed, BUT at that time it was not because its RecoverableConnection was in use. What we're actually seeing in our application is that com.arjuna.ats.internal.jdbc.ConnectionManager._connections grows indefinitely. This causes a memory leak and severe performance problems, also because the test for cache hits in ConnectionManager is made using a linear iteration over the map (this could be improved a lot). The workaround is to disable connection pooling within the transaction by using the patch from JBTM-529 (but also please see my last comment, too!). To fix the problem I think that some approaches could be followed: - the easiest one is to remove the old connections without any associated transaction when iterating over _connections: that is, if I'm checking a connection conn which has tx1 == null, I could remove conn from _connections; in this way I'm sure that sooner or later a ConnectionImple, which hasn't been removed from that map previously, will be when another connection is requested - implement com.arjuna.ats.internal.jdbc.ConnectionImple.equals(Object) and hashCode() so that the call to _connections.put(conn, conn) will "replace any old (closed) connection which had the same connection information", as the inline documentation says; this is not true right now, because equality is based on identity; this might be the less invasive solution, but I don't know how easy it would be to do and if there may be regressions in other areas - provide a mechanism to invoke com.arjuna.ats.internal.jdbc.ConnectionManager.remove(ConnectionImple) for all the ConnectionImple objects bound to a transaction when this is completed (committed or rolled back) In any case, a smarter use of _connections would be useful for performance (using a Transaction=>ConnectionImple mapping, for instance...). I would also consider the complete removal of in-transaction connection pooling: after all, every production use of JBossTS JTA will certainly use some sort of connection pooling by its own, so the benefits of using another level of pooling could be negligible. Even worse, performance could be compromised if the search for the hit in the pool is not efficient. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 6 months

2
7
0 / 0

[JBoss JIRA] Created: (JBTM-789) Potential connection leak

by Mauro Molinari (JIRA)

Potential connection leak ------------------------- Key: JBTM-789 URL: https://jira.jboss.org/browse/JBTM-789 Project: JBoss Transaction Manager Issue Type: Bug Security Level: Public (Everyone can see) Components: JTA Environment: JBoss Transactions 4.11, Tomcat, Spring Reporter: Mauro Molinari I recently upgraded JBossTS from 4.6.1 GA to 4.11 Final. I see that bug JBTM-532 that I opened against 4.5 and 4.6 should have been fixed in 4.8.0. However, I have a doubt on the current (4.11) implementation of com.arjuna.ats.internal.jdbc.ConnectionImple.close(). I mean, if _theModifier is null, a comment says: "no indication about connections, so assume close immediately". However in this case only _theConnection is closed and set to null, while _recoveryConnection.closeCloseCurrentConnection() is not called. I think this may lead to connection leaks. What I would expect is that if _theModifier is null, a log entry were added but nothing else were done; in particular I would expect not to return and let the following "if (!delayClose)" (towards the end of the method) close the connections immediately (both _theConnection and _recoveryConnection). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 6 months

3
11
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

jbossts-issues February 2011