[JBoss JIRA] Created: (JBTM-850) Remove old ant build system in Narayana
by Tom Jenkinson (JIRA)
Remove old ant build system in Narayana
---------------------------------------
Key: JBTM-850
URL: https://issues.jboss.org/browse/JBTM-850
Project: JBoss Transaction Manager
Issue Type: Task
Security Level: Public (Everyone can see)
Reporter: Tom Jenkinson
Assignee: Tom Jenkinson
Priority: Minor
Fix For: 5.0.0.M1
To save the requirement of maintaining too build systems in Narayana we should remove the old Ant build system.
This may also need removing for the qa/ module.
*Potential* matches are:
./maven/build.xml
./ArjunaJTS/orbportability/build.xml
./ArjunaJTS/jtax/build.xml
./ArjunaJTS/trailmap/build.xml
./ArjunaJTS/build.xml
./ArjunaJTS/sharedbuild.xml
./ArjunaJTS/jts/build.xml
./ArjunaJTS/jacorb/idl/build.xml
./txbridge/demo/build.xml
./txbridge/build.xml
./txbridge/tests/build.xml
./ArjunaCore/txoj/build.xml
./ArjunaCore/build.xml
./ArjunaCore/arjuna/build.xml
./qa/build.xml
./qa/tests/build-jta.xml
./qa/tests/build-core.xml
./qa/tests/build-jts.xml
./qa/tests/product/build.xml
./build-release-pkgs.xml
./atsintegration/docbuild/build.xml
./atsintegration/build.xml
./common/build.xml
./antbuildsystem/build.xml
./ArjunaJTA/jdbc/build.xml
./ArjunaJTA/build.xml
./ArjunaJTA/jta/build.xml
./build.xml
./XTS/WSTX/build.xml
./XTS/bridge/build.xml
./XTS/sar/build.xml
./XTS/sar/tests/build.xml
./XTS/localjunit/build.xml
./XTS/WSCF/build.xml
./XTS/interop/WSTX11-interop/build.xml
./XTS/interop/WSTFSC07-interop/build.xml
./XTS/recovery/build.xml
./XTS/WS-T/build.xml
./XTS/demo/xts-build.xml
./XTS/demo/build.xml
./XTS/build.xml
./XTS/WSAS/build.xml
./XTS/WS-C/build.xml
./XTS/sharedbuild.xml
./rhq-plugin/build.xml
./docs/build.xml
./sharedbuild.xml
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 10 months
[JBoss JIRA] Created: (JBTM-576) update unit tests
by Jonathan Halliday (JIRA)
update unit tests
-----------------
Key: JBTM-576
URL: https://jira.jboss.org/jira/browse/JBTM-576
Project: JBoss Transaction Manager
Issue Type: Task
Security Level: Public (Everyone can see)
Components: Testing
Affects Versions: 4.7.0
Reporter: Jonathan Halliday
Assignee: Jonathan Halliday
Fix For: 4.8.0
There are many unit tests that have lain dormant for some time. Convert them from DTF/junit3 to junit4, wire them to the build and make them pass.
This will be done incrementally, one module at a time, following the dependency chain e.g. common, ArjunaCore/arjuna, ArjunaCore/txoj, ... JTA/, .../JTS/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 12 months
[JBoss JIRA] Created: (JBTM-531) com.arjuna.ats.internal.jdbc.DynamicClass.shutdownDataSource(XADataSource) is never called
by Mauro Molinari (JIRA)
com.arjuna.ats.internal.jdbc.DynamicClass.shutdownDataSource(XADataSource) is never called
------------------------------------------------------------------------------------------
Key: JBTM-531
URL: https://jira.jboss.org/jira/browse/JBTM-531
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: JTA
Affects Versions: 4.6.0, 4.5.0
Reporter: Mauro Molinari
Priority: Critical
com.arjuna.ats.internal.jdbc.DynamicClass.shutdownDataSource(XADataSource) is never called by com.arjuna.ats.internal.jdbc.DirectRecoverableConnection.
>From what I could understand (but I'm not sure of this), after calling com.arjuna.ats.internal.jdbc.DirectRecoverableConnection.closeCloseCurrentConnection() the DirectRecoverableConnection won't be used anymore, so that method could be a good candidate to call _dynamicConnection.shutDownDataSource(_theDataSource) and to null both _dynamicConnection and _theDataSource.
This problem could be quite severe, because if the XADataSource needs to be shut down in order to release resources, this could lead to leaks.
Moreover, I was wondering if a caching of the dynamic class wouldn't be a good idea... as of now, a NEW XA data source is created every time a new connection is requested... and this could be expensive...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] Created: (JBTM-764) ConnectionImple/RecoverableConnection leak in ConnectionManager because of the pooling
by Mauro Molinari (JIRA)
ConnectionImple/RecoverableConnection leak in ConnectionManager because of the pooling
--------------------------------------------------------------------------------------
Key: JBTM-764
URL: https://jira.jboss.org/browse/JBTM-764
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: JTA
Affects Versions: 4.6.1
Environment: JBossTS JTA embedded in a webapp with Spring
Reporter: Mauro Molinari
Priority: Critical
This is indirectly related to JBTM-529.
Suppose you are using JBossTS JTA within your webapp, configured using Spring and using the DynamicClass mechanism to get connections.
Suppose you're doing connection pooling under JBossTS: that is, the DynamicClass implementation is pooling XA connections from the actual XADataSource provided by the DBMS JDBC driver. This is a different approach from the one described in JBTM-529 and we switched to this one because of the problems encountered with JBTM-529, thinking that it could be a more correct approach.
In this scenario, the client application code is doing the following:
- start a transaction
- request a new JDBC connection: this can be done either by using the DriverManager or by using Spring SimpleDriverDataSource; JBossTS JTA TransactionalDriver actually creates a new ConnectionImple, which asks the DynamicClass implementation to get a new XAConnection and gets a physical JDBC connection from that XAConnection; because of the XAConnection pooling provided by the DynamicClass implementation, this XAConnection might be a new one or a reused one, but I think this is not relevant to the problem
- do what you have to do with the connection
- close the connection: this causes the invocation of ConnectionImple.close
- do other things within the transaction
- commit the transaction
Now, what I see is this: com.arjuna.ats.internal.jdbc.ConnectionImple.close() does the following check:
if (!_recoveryConnection.inuse())
{
ConnectionManager.remove(this); // finalize?
}
The problem is that since the transaction is still active, _recoveryConnection.inuse() returns true, because it checks for the XAResource associated with it: in the case of DirectRecoverableConnection, this is done when com.arjuna.ats.internal.jdbc.DirectRecoverableConnection.reset() is invoked, that is when the RecoverableConnection is closed, and so when the transaction terminates.
The ultimate effect is that the ConnectionImple is never removed from the caching map of ConnectionManager, because it should have been when the connection was closed, BUT at that time it was not because its RecoverableConnection was in use.
What we're actually seeing in our application is that com.arjuna.ats.internal.jdbc.ConnectionManager._connections grows indefinitely. This causes a memory leak and severe performance problems, also because the test for cache hits in ConnectionManager is made using a linear iteration over the map (this could be improved a lot).
The workaround is to disable connection pooling within the transaction by using the patch from JBTM-529 (but also please see my last comment, too!).
To fix the problem I think that some approaches could be followed:
- the easiest one is to remove the old connections without any associated transaction when iterating over _connections: that is, if I'm checking a connection conn which has tx1 == null, I could remove conn from _connections; in this way I'm sure that sooner or later a ConnectionImple, which hasn't been removed from that map previously, will be when another connection is requested
- implement com.arjuna.ats.internal.jdbc.ConnectionImple.equals(Object) and hashCode() so that the call to _connections.put(conn, conn) will "replace any old (closed) connection which had the same connection information", as the inline documentation says; this is not true right now, because equality is based on identity; this might be the less invasive solution, but I don't know how easy it would be to do and if there may be regressions in other areas
- provide a mechanism to invoke com.arjuna.ats.internal.jdbc.ConnectionManager.remove(ConnectionImple) for all the ConnectionImple objects bound to a transaction when this is completed (committed or rolled back)
In any case, a smarter use of _connections would be useful for performance (using a Transaction=>ConnectionImple mapping, for instance...).
I would also consider the complete removal of in-transaction connection pooling: after all, every production use of JBossTS JTA will certainly use some sort of connection pooling by its own, so the benefits of using another level of pooling could be negligible. Even worse, performance could be compromised if the search for the hit in the pool is not efficient.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months