[JBoss JIRA] (JBTM-1031) == replaced with equals() in objects comparison where appropriate
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1031?page=com.atlassian.jira.plugin.... ]
Paul Robinson updated JBTM-1031:
--------------------------------
Summary: == replaced with equals() in objects comparison where appropriate (was: Search for "<String.class> == <String.class>" bugs)
> == replaced with equals() in objects comparison where appropriate
> -----------------------------------------------------------------
>
> Key: JBTM-1031
> URL: https://issues.jboss.org/browse/JBTM-1031
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: XTS
> Reporter: Paul Robinson
> Assignee: Gytis Trikleris
> Priority: Minor
> Fix For: 5.0.0.M2
>
> Time Spent: 1 hour, 20 minutes
> Remaining Estimate: 0 minutes
>
> A recent bug in XTS recovery was caused by the use of == to compare Strings. String#equals(...) should have been used.
> We need to search the XTS codebase for other occurrences of this type of bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 2 months
[JBoss JIRA] (JBTM-1420) org.apache.commons.io.output.DeferredFileOutputStream class not found
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1420?page=com.atlassian.jira.plugin.... ]
Paul Robinson updated JBTM-1420:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> org.apache.commons.io.output.DeferredFileOutputStream class not found
> ---------------------------------------------------------------------
>
> Key: JBTM-1420
> URL: https://issues.jboss.org/browse/JBTM-1420
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Testing, TXFramework
> Reporter: Gytis Trikleris
> Assignee: Paul Robinson
> Priority: Critical
> Fix For: 5.0.0.M2
>
> Original Estimate: 1 day
> Time Spent: 1 hour, 35 minutes
> Remaining Estimate: 0 minutes
>
> See: http://172.17.131.2/job/narayana/139
> {noformat}
> Tests in error:
> clientDrivenCommitTest(org.jboss.narayana.txframework.functional.rest.at.simpleEJB.ClientTXInterceptorTest): java.lang.NoClassDefFoundError: org/apache/commons/io/output/DeferredFileOutputStream
> multipleInvokeTest(org.jboss.narayana.txframework.functional.rest.at.simpleEJB.IndirectTXManagementTest): org/apache/commons/io/output/DeferredFileOutputStream
> clientDrivenRollbackTest(org.jboss.narayana.txframework.functional.rest.at.simpleEJB.IndirectTXManagementTest): org/apache/commons/io/output/DeferredFileOutputStream
> participantDrivenRollbackTest(org.jboss.narayana.txframework.functional.rest.at.simpleEJB.IndirectTXManagementTest): org/apache/commons/io/output/DeferredFileOutputStream
> clientDrivenCommitTest(org.jboss.narayana.txframework.functional.rest.at.simpleEJB.IndirectTXManagementTest): org/apache/commons/io/output/DeferredFileOutputStream
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 2 months
[JBoss JIRA] (JBTM-1420) org.apache.commons.io.output.DeferredFileOutputStream class not found
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1420?page=com.atlassian.jira.plugin.... ]
Paul Robinson logged work on JBTM-1420:
---------------------------------------
Author: Paul Robinson
Created on: 16/Jan/13 3:56 AM
Start Date: 16/Jan/13 3:56 AM
Worklog Time Spent: 5 minutes
Issue Time Tracking
-------------------
Remaining Estimate: 0 minutes (was: 6 hours, 30 minutes)
Time Spent: 1 hour, 35 minutes (was: 1 hour, 30 minutes)
Worklog Id: (was: 12428406)
> org.apache.commons.io.output.DeferredFileOutputStream class not found
> ---------------------------------------------------------------------
>
> Key: JBTM-1420
> URL: https://issues.jboss.org/browse/JBTM-1420
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Testing, TXFramework
> Reporter: Gytis Trikleris
> Assignee: Paul Robinson
> Priority: Critical
> Fix For: 5.0.0.M2
>
> Original Estimate: 1 day
> Time Spent: 1 hour, 35 minutes
> Remaining Estimate: 0 minutes
>
> See: http://172.17.131.2/job/narayana/139
> {noformat}
> Tests in error:
> clientDrivenCommitTest(org.jboss.narayana.txframework.functional.rest.at.simpleEJB.ClientTXInterceptorTest): java.lang.NoClassDefFoundError: org/apache/commons/io/output/DeferredFileOutputStream
> multipleInvokeTest(org.jboss.narayana.txframework.functional.rest.at.simpleEJB.IndirectTXManagementTest): org/apache/commons/io/output/DeferredFileOutputStream
> clientDrivenRollbackTest(org.jboss.narayana.txframework.functional.rest.at.simpleEJB.IndirectTXManagementTest): org/apache/commons/io/output/DeferredFileOutputStream
> participantDrivenRollbackTest(org.jboss.narayana.txframework.functional.rest.at.simpleEJB.IndirectTXManagementTest): org/apache/commons/io/output/DeferredFileOutputStream
> clientDrivenCommitTest(org.jboss.narayana.txframework.functional.rest.at.simpleEJB.IndirectTXManagementTest): org/apache/commons/io/output/DeferredFileOutputStream
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 2 months
[JBoss JIRA] (JBTM-1293) ATBridgeTest#testSimple counter isn't incremented
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1293?page=com.atlassian.jira.plugin.... ]
Paul Robinson updated JBTM-1293:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> ATBridgeTest#testSimple counter isn't incremented
> -------------------------------------------------
>
> Key: JBTM-1293
> URL: https://issues.jboss.org/browse/JBTM-1293
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Testing, TXFramework
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.M2
>
> Original Estimate: 3 days
> Time Spent: 7 hours, 35 minutes
> Remaining Estimate: 0 minutes
>
> See:
> http://172.17.131.2/view/Narayana+BlackTie/job/jbossts-narayana-java7/21/...
> {code}
> @Test
> public void testSimple() throws Exception
> {
> ut.begin();
> client.incrementCounter(1);
> ut.commit();
> ut.begin();
> int counter = client.getCounter();
> ut.commit();
> Assert.assertEquals(1, counter);
> }
> {code}
> Even though the first transaction should have committed an update to the counter, it is still set to zero in the second transaction.
> This happens intermittently (once so far). It also happened on Beacon which is notorious for test failures caused by things going slowly. I would suspect that the bridged JTA transaction in the first transaction hasn't quite finished the commit when the second transaction is begun.
> If the WS-AT coordinator sends an async commit to the participants and an async committed to the client, then this problem could happen if the client's 'committed' is received before the participant's 'commit' message.
> To verify this we need to check that the coordinator sends an async (@OneWay) commit message to the participant. In which case the simplest solution is to add a 3sec delay between the two transactions. We should also look for other tests that may be affected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 2 months
[JBoss JIRA] (JBTM-1293) ATBridgeTest#testSimple counter isn't incremented
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1293?page=com.atlassian.jira.plugin.... ]
Paul Robinson logged work on JBTM-1293:
---------------------------------------
Author: Paul Robinson
Created on: 16/Jan/13 3:48 AM
Start Date: 16/Jan/13 3:48 AM
Worklog Time Spent: 5 minutes
Issue Time Tracking
-------------------
Remaining Estimate: 0 minutes (was: 2 days, 30 minutes)
Time Spent: 7 hours, 35 minutes (was: 7 hours, 30 minutes)
Worklog Id: (was: 12428405)
> ATBridgeTest#testSimple counter isn't incremented
> -------------------------------------------------
>
> Key: JBTM-1293
> URL: https://issues.jboss.org/browse/JBTM-1293
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Testing, TXFramework
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.M2
>
> Original Estimate: 3 days
> Time Spent: 7 hours, 35 minutes
> Remaining Estimate: 0 minutes
>
> See:
> http://172.17.131.2/view/Narayana+BlackTie/job/jbossts-narayana-java7/21/...
> {code}
> @Test
> public void testSimple() throws Exception
> {
> ut.begin();
> client.incrementCounter(1);
> ut.commit();
> ut.begin();
> int counter = client.getCounter();
> ut.commit();
> Assert.assertEquals(1, counter);
> }
> {code}
> Even though the first transaction should have committed an update to the counter, it is still set to zero in the second transaction.
> This happens intermittently (once so far). It also happened on Beacon which is notorious for test failures caused by things going slowly. I would suspect that the bridged JTA transaction in the first transaction hasn't quite finished the commit when the second transaction is begun.
> If the WS-AT coordinator sends an async commit to the participants and an async committed to the client, then this problem could happen if the client's 'committed' is received before the participant's 'commit' message.
> To verify this we need to check that the coordinator sends an async (@OneWay) commit message to the participant. In which case the simplest solution is to add a 3sec delay between the two transactions. We should also look for other tests that may be affected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 2 months
[JBoss JIRA] (JBTM-1293) ATBridgeTest#testSimple counter isn't incremented
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1293?page=com.atlassian.jira.plugin.... ]
Paul Robinson commented on JBTM-1293:
-------------------------------------
I've merged in the commit to fix the usage of JPA. THis should resolve the issue. Re-open if it doesn't.
> ATBridgeTest#testSimple counter isn't incremented
> -------------------------------------------------
>
> Key: JBTM-1293
> URL: https://issues.jboss.org/browse/JBTM-1293
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Testing, TXFramework
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.M2
>
> Original Estimate: 3 days
> Time Spent: 7 hours, 30 minutes
> Remaining Estimate: 2 days, 30 minutes
>
> See:
> http://172.17.131.2/view/Narayana+BlackTie/job/jbossts-narayana-java7/21/...
> {code}
> @Test
> public void testSimple() throws Exception
> {
> ut.begin();
> client.incrementCounter(1);
> ut.commit();
> ut.begin();
> int counter = client.getCounter();
> ut.commit();
> Assert.assertEquals(1, counter);
> }
> {code}
> Even though the first transaction should have committed an update to the counter, it is still set to zero in the second transaction.
> This happens intermittently (once so far). It also happened on Beacon which is notorious for test failures caused by things going slowly. I would suspect that the bridged JTA transaction in the first transaction hasn't quite finished the commit when the second transaction is begun.
> If the WS-AT coordinator sends an async commit to the participants and an async committed to the client, then this problem could happen if the client's 'committed' is received before the participant's 'commit' message.
> To verify this we need to check that the coordinator sends an async (@OneWay) commit message to the participant. In which case the simplest solution is to add a 3sec delay between the two transactions. We should also look for other tests that may be affected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 2 months