[JBoss JIRA] (JBTM-1155) Remember where we are in the commit list for recovery
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1155?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson updated JBTM-1155:
--------------------------------
Fix Version/s: 5.0.0.M2
(was: 5.0.0.M3)
> Remember where we are in the commit list for recovery
> -----------------------------------------------------
>
> Key: JBTM-1155
> URL: https://issues.jboss.org/browse/JBTM-1155
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Recovery, Transaction Core
> Affects Versions: 4.16.4
> Reporter: Mark Little
> Assignee: Mark Little
> Fix For: 5.0.0.M2
>
>
> We keep track of where the coordinator is in the list of resources to commit during doCommit, so that we can avoid heuristics as much as possible. Basically we need to remember if we have gotten past the first participant. However, we do not remember this value (boolean) as part of the transaction state. This means that upon recovery there is a chance that a participant that failed to commit the first time round and then causes a heuristic rollback subsequently, will cause the transaction silently mask the heuristic and roll back all of the other participants, delete the log and report a normal transaction abort state. In fact it should ensure the heuristic is raised.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 2 months
[JBoss JIRA] (JBTM-1155) Remember where we are in the commit list for recovery
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1155?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson reopened JBTM-1155:
---------------------------------
> Remember where we are in the commit list for recovery
> -----------------------------------------------------
>
> Key: JBTM-1155
> URL: https://issues.jboss.org/browse/JBTM-1155
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Recovery, Transaction Core
> Affects Versions: 4.16.4
> Reporter: Mark Little
> Assignee: Mark Little
> Fix For: 5.0.0.M3
>
>
> We keep track of where the coordinator is in the list of resources to commit during doCommit, so that we can avoid heuristics as much as possible. Basically we need to remember if we have gotten past the first participant. However, we do not remember this value (boolean) as part of the transaction state. This means that upon recovery there is a chance that a participant that failed to commit the first time round and then causes a heuristic rollback subsequently, will cause the transaction silently mask the heuristic and roll back all of the other participants, delete the log and report a normal transaction abort state. In fact it should ensure the heuristic is raised.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 2 months
[JBoss JIRA] (JBTM-1355) Merge XTS JUnit and Arquillian tests
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1355?page=com.atlassian.jira.plugin.... ]
Paul Robinson reassigned JBTM-1355:
-----------------------------------
Assignee: Amos Feng (was: Paul Robinson)
> Merge XTS JUnit and Arquillian tests
> ------------------------------------
>
> Key: JBTM-1355
> URL: https://issues.jboss.org/browse/JBTM-1355
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: Testing, XTS
> Reporter: Paul Robinson
> Assignee: Amos Feng
> Priority: Minor
> Labels: assign
> Fix For: 4.17.4, 5.0.0.M2
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> When migrating the XTS tests to Arquillian, we wanted to make sure that the old tests where still functional whilst the Arquillian counterparts stabilized. As a result we now have two classes for each test. The Arquillian test delegates each @Test method to the corresponding @Test in the old suite.
> For example:
> We have the actual test in:
> ./XTS/localjunit/WSTX/src/main/java/com/arjuna/wst11/tests/arq/ba/MultiClose.java
> And then a Arquillian JUnit test which just calls the test methods above is here:
> ./XTS/localjunit/WSTX/src/test/java/com/arjuna/wst11/tests/arq/ba/MultiCloseTest.java
> To resolve this issue, we should remove the tests under './XTS/localjunit/WSTX/src/main/java' and merge the test methods into Arquillian test. At the end of this process "./XTS/localjunit/WSTX/src/main" should be empty (and thus removed).
> This applies to most, if not all suites under "./XTS/localjunit/".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 2 months
[JBoss JIRA] (JBTM-1147) Refactor ParticipantCompletion recovery tests to remove duplicate rules
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1147?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson updated JBTM-1147:
--------------------------------
Please can you add an estimate for this issue?
> Refactor ParticipantCompletion recovery tests to remove duplicate rules
> -----------------------------------------------------------------------
>
> Key: JBTM-1147
> URL: https://issues.jboss.org/browse/JBTM-1147
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: XTS
> Affects Versions: 4.16.4, 5.0.0.M1
> Reporter: Paul Robinson
> Assignee: Amos Feng
> Priority: Minor
> Fix For: 5.0.0.Final
>
>
> The Byteman rules for the participant completion XTS recovery tests have many rules that are almost duplicates of each other. For example:
> The following rules in BACrashDuringCommit could be refactored into a single rule
> {code}
> #####################################################################
> # Setup counter MultiParticipantParticipantCompletionParticipantCloseTest
> #
> RULE setup counter MultiParticipantParticipantCompletionParticipantCloseTest
> CLASS org.jboss.jbossts.xts.servicetests.test.ba.MultiParticipantParticipantCompletionParticipantCloseTest
> METHOD run()
> AT ENTRY
> IF TRUE
> DO debug("creating counter and rendezvous"),
> createCounter("closes", 3),
> createRendezvous("closes-complete", 2)
> ENDRULE
> #####################################################################
> # Setup counter MultiParticipantCoordinatorCompletionParticipantCloseTest
> #
> RULE setup counter MultiParticipantCoordinatorCompletionParticipantCloseTest
> CLASS org.jboss.jbossts.xts.servicetests.test.ba.MultiParticipantParticipantCompletionParticipantCloseAndExitTest
> METHOD run()
> AT ENTRY
> IF TRUE
> DO debug("creating counter and rendezvous"),
> createCounter("closes", 3),
> createRendezvous("closes-complete", 2)
> ENDRULE
> #####################################################################
> # Setup counter MultiServiceParticipantCompletionParticipantCloseTest
> #
> RULE setup counter MultiServiceParticipantCompletionParticipantCloseTest
> CLASS org.jboss.jbossts.xts.servicetests.test.ba.MultiServiceParticipantCompletionParticipantCloseTest
> METHOD run()
> AT ENTRY
> IF TRUE
> DO debug("creating counter and rendezvous"),
> createCounter("closes", 3),
> createRendezvous("closes-complete", 2)
> ENDRULE
> #####################################################################
> # Setup counter MultiServiceParticipantCompletionParticipantCloseAndExitTest
> #
> RULE setup counter MultiServiceParticipantCompletionParticipantCloseAndExitTest
> CLASS org.jboss.jbossts.xts.servicetests.test.ba.MultiServiceParticipantCompletionParticipantCloseAndExitTest
> METHOD run()
> AT ENTRY
> IF TRUE
> DO debug("creating counter and rendezvous"),
> createCounter("closes", 3),
> createRendezvous("closes-complete", 2)
> ENDRULE
> {code}
> These can be re-factored in to a rule like this:
> {code}
> RULE setup counter
> INTERFACE org.jboss.jbossts.xts.servicetests.test.XTSServiceTest
> METHOD run()
> AT ENTRY
> IF $0.getClass().getName().contains("ParticipantCompletionParticipant")
> DO debug("creating counter and rendezvous"),
> createCounter("closes", 3),
> createRendezvous("closes-complete", 2)
> ENDRULE
> {code}
> Also, the following similar rules are also present in this file:
> {code}
> #####################################################################
> # Wait on Rendezvous before calling uba.close() on MultiServiceParticipantCompletionParticipantCloseTest
> #
> RULE wait for closes MultiParticipantParticipantCompletionParticipantCloseTest
> CLASS org.jboss.jbossts.xts.servicetests.test.ba.MultiParticipantParticipantCompletionParticipantCloseTest
> METHOD run()
> AT CALL UserBusinessActivity.close()
> IF TRUE
> DO debug("waiting to call close"),
> rendezvous("closes-complete"),
> debug("rendezvous complete, calling close")
> ENDRULE
> #####################################################################
> # Wait on Rendezvous before calling uba.close() on MultiParticipantParticipantCompletionParticipantCloseAndExitTest
> #
> RULE wait for closes MultiParticipantParticipantCompletionParticipantCloseAndExitTest
> CLASS org.jboss.jbossts.xts.servicetests.test.ba.MultiParticipantParticipantCompletionParticipantCloseAndExitTest
> METHOD run()
> AT CALL UserBusinessActivity.close()
> IF TRUE
> DO debug("waiting to call close"),
> rendezvous("closes-complete"),
> debug("rendezvous complete, calling close")
> ENDRULE
> #####################################################################
> # Wait on Rendezvous before calling uba.close() on MultiServiceParticipantCompletionParticipantCloseTest
> #
> RULE wait for closes MultiServiceParticipantCompletionParticipantCloseTest
> CLASS org.jboss.jbossts.xts.servicetests.test.ba.MultiServiceParticipantCompletionParticipantCloseTest
> METHOD run()
> AT CALL UserBusinessActivity.close()
> IF TRUE
> DO debug("waiting to call close"),
> rendezvous("closes-complete"),
> debug("rendezvous complete, calling close")
> ENDRULE
> #####################################################################
> # Wait on Rendezvous before calling uba.close() on MultiServiceParticipantCompletionParticipantCloseAndExitTest
> #
> RULE wait for closes MultiServiceParticipantCompletionParticipantCloseAndExitTest
> CLASS org.jboss.jbossts.xts.servicetests.test.ba.MultiServiceParticipantCompletionParticipantCloseAndExitTest
> METHOD run()
> AT CALL UserBusinessActivity.close()
> IF TRUE
> DO debug("waiting to call close"),
> rendezvous("closes-complete"),
> debug("rendezvous complete, calling close")
> ENDRULE
> {code}
> Which could be replaced with something like this:
> {code}
> RULE wait for closes
> INTERFACE org.jboss.jbossts.xts.servicetests.test.XTSServiceTest
> METHOD run()
> AT CALL UserBusinessActivity.close()
> IF $0.getClass().getName().contains("ParticipantCompletionParticipant")
> DO debug("waiting to call close"),
> rendezvous("closes-complete"),
> debug("rendezvous complete, calling close")
> ENDRULE
> {code}
> We could also re-factor these two rules out into a separate Byteman script and add it to all tests that need it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 2 months
[JBoss JIRA] (JBTM-1016) Run bmcheck.sh regularly to spot inconsistencies between byteman scripts and the code
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1016?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson updated JBTM-1016:
--------------------------------
Please can you add an estimate for this issue?
> Run bmcheck.sh regularly to spot inconsistencies between byteman scripts and the code
> -------------------------------------------------------------------------------------
>
> Key: JBTM-1016
> URL: https://issues.jboss.org/browse/JBTM-1016
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: XTS
> Reporter: Paul Robinson
> Assignee: Amos Feng
> Fix For: 5.0.0.Final
>
>
> I've found many bugs in the XTS crash recovery tests that where due to changes being made to the XTS code without updating the byteman scripts. The problem is that these inconsistencies often go unnoticed when the tests run, until you notice a failure in the test.
> Can we run bmcheck as part of the maven build and make the build fail if it detects errors? Needs to be integrated into the poms, perhaps by an exec in an antrun plugin
> NOTE: Before raising the pull req it will be necessary to resolve any the discovered errors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 2 months
[JBoss JIRA] (JBTM-1311) Unify all XTS/localjunit tests
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1311?page=com.atlassian.jira.plugin.... ]
Paul Robinson logged work on JBTM-1311:
---------------------------------------
Author: Paul Robinson
Created on: 14/Jan/13 5:01 AM
Start Date: 14/Jan/13 5:01 AM
Worklog Time Spent: 2 hours
Issue Time Tracking
-------------------
Remaining Estimate: 4 hours (was: 6 hours)
Time Spent: 4 hours (was: 2 hours)
Worklog Id: (was: 12428396)
> Unify all XTS/localjunit tests
> -------------------------------
>
> Key: JBTM-1311
> URL: https://issues.jboss.org/browse/JBTM-1311
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: Testing, XTS
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Priority: Minor
> Fix For: 4.17.4, 5.0.0.M2
>
> Original Estimate: 1 day
> Time Spent: 4 hours
> Remaining Estimate: 4 hours
>
> All the XTS/localjunit tests run with Arquillian and should have a consistent configuration. Therefore we should be able to put all the config in the XTS/localjunit/pom.xml. However, the crash recovery tests in particular have a there own properties and Arquillian config.
> Also, the test don't have a consistent arquillian.xml. We should try to make this consistent too
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 2 months
[JBoss JIRA] (JBTM-1311) Unify all XTS/localjunit tests
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1311?page=com.atlassian.jira.plugin.... ]
Paul Robinson updated JBTM-1311:
--------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/jbosstm/narayana/pull/201
> Unify all XTS/localjunit tests
> -------------------------------
>
> Key: JBTM-1311
> URL: https://issues.jboss.org/browse/JBTM-1311
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: Testing, XTS
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Priority: Minor
> Fix For: 4.17.4, 5.0.0.M2
>
> Original Estimate: 1 day
> Time Spent: 2 hours
> Remaining Estimate: 6 hours
>
> All the XTS/localjunit tests run with Arquillian and should have a consistent configuration. Therefore we should be able to put all the config in the XTS/localjunit/pom.xml. However, the crash recovery tests in particular have a there own properties and Arquillian config.
> Also, the test don't have a consistent arquillian.xml. We should try to make this consistent too
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 2 months
[JBoss JIRA] (JBTM-1311) Unify all XTS/localjunit tests
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1311?page=com.atlassian.jira.plugin.... ]
Paul Robinson commented on JBTM-1311:
-------------------------------------
Port this to 4.17 after:
* Pull request passes
* Merged to master
* IPv6 tests pass
> Unify all XTS/localjunit tests
> -------------------------------
>
> Key: JBTM-1311
> URL: https://issues.jboss.org/browse/JBTM-1311
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: Testing, XTS
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Priority: Minor
> Fix For: 4.17.4, 5.0.0.M2
>
> Original Estimate: 1 day
> Time Spent: 2 hours
> Remaining Estimate: 6 hours
>
> All the XTS/localjunit tests run with Arquillian and should have a consistent configuration. Therefore we should be able to put all the config in the XTS/localjunit/pom.xml. However, the crash recovery tests in particular have a there own properties and Arquillian config.
> Also, the test don't have a consistent arquillian.xml. We should try to make this consistent too
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 2 months
[JBoss JIRA] (JBTM-1355) Merge XTS JUnit and Arquillian tests
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1355?page=com.atlassian.jira.plugin.... ]
Paul Robinson updated JBTM-1355:
--------------------------------
Comment: was deleted
(was: I think we should also consider placing all the unit tests (WS-C, WSAS, WS-T, WSCF, WSTX) under a sinbgle project, separated by package. This should reduce the number of poms, arquillian.xmls etc we need to maintain.)
> Merge XTS JUnit and Arquillian tests
> ------------------------------------
>
> Key: JBTM-1355
> URL: https://issues.jboss.org/browse/JBTM-1355
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: Testing, XTS
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Priority: Minor
> Labels: assign
> Fix For: 4.17.4, 5.0.0.M2
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> When migrating the XTS tests to Arquillian, we wanted to make sure that the old tests where still functional whilst the Arquillian counterparts stabilized. As a result we now have two classes for each test. The Arquillian test delegates each @Test method to the corresponding @Test in the old suite.
> For example:
> We have the actual test in:
> ./XTS/localjunit/WSTX/src/main/java/com/arjuna/wst11/tests/arq/ba/MultiClose.java
> And then a Arquillian JUnit test which just calls the test methods above is here:
> ./XTS/localjunit/WSTX/src/test/java/com/arjuna/wst11/tests/arq/ba/MultiCloseTest.java
> To resolve this issue, we should remove the tests under './XTS/localjunit/WSTX/src/main/java' and merge the test methods into Arquillian test. At the end of this process "./XTS/localjunit/WSTX/src/main" should be empty (and thus removed).
> This applies to most, if not all suites under "./XTS/localjunit/".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 2 months
[JBoss JIRA] (JBTM-1311) Unify all XTS/localjunit tests
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1311?page=com.atlassian.jira.plugin.... ]
Paul Robinson logged work on JBTM-1311:
---------------------------------------
Author: Paul Robinson
Created on: 14/Jan/13 3:35 AM
Start Date: 14/Jan/13 3:34 AM
Worklog Time Spent: 2 hours
Issue Time Tracking
-------------------
Remaining Estimate: 6 hours (was: 1 day)
Time Spent: 2 hours
Worklog Id: (was: 12428395)
> Unify all XTS/localjunit tests
> -------------------------------
>
> Key: JBTM-1311
> URL: https://issues.jboss.org/browse/JBTM-1311
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: Testing, XTS
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Priority: Minor
> Fix For: 4.17.4, 5.0.0.M2
>
> Original Estimate: 1 day
> Time Spent: 2 hours
> Remaining Estimate: 6 hours
>
> All the XTS/localjunit tests run with Arquillian and should have a consistent configuration. Therefore we should be able to put all the config in the XTS/localjunit/pom.xml. However, the crash recovery tests in particular have a there own properties and Arquillian config.
> Also, the test don't have a consistent arquillian.xml. We should try to make this consistent too
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 2 months