[JBoss JIRA] (JBTM-2910) Don't allow transactional driver recovery handler to close underlying JDBC connection
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-2910?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson updated JBTM-2910:
--------------------------------
Description: As the reference to the JDBC2RecoveryConnection is not retained, it is eligible for garbage collection. It's finalizer calls the connection close and prevents recovery from completing. (was: As the reference is not stored the transactionaldriver recovery connection is eligible for finalizer which calls the connection close and prevents recovery from completing.)
> Don't allow transactional driver recovery handler to close underlying JDBC connection
> -------------------------------------------------------------------------------------
>
> Key: JBTM-2910
> URL: https://issues.jboss.org/browse/JBTM-2910
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Reporter: Tom Jenkinson
> Assignee: Tom Jenkinson
> Fix For: 5.next
>
>
> As the reference to the JDBC2RecoveryConnection is not retained, it is eligible for garbage collection. It's finalizer calls the connection close and prevents recovery from completing.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 10 months
[JBoss JIRA] (JBTM-2907) Implement doRecover method into JTS XATerminatorImple for WFTC inflow jca txn integration works
by Ondra Chaloupka (JIRA)
[ https://issues.jboss.org/browse/JBTM-2907?page=com.atlassian.jira.plugin.... ]
Ondra Chaloupka updated JBTM-2907:
----------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Implement doRecover method into JTS XATerminatorImple for WFTC inflow jca txn integration works
> -----------------------------------------------------------------------------------------------
>
> Key: JBTM-2907
> URL: https://issues.jboss.org/browse/JBTM-2907
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Components: JTS
> Affects Versions: 5.6.1.Final, 5.5.24.Final
> Reporter: Ondra Chaloupka
> Assignee: Ondra Chaloupka
> Priority: Blocker
> Fix For: 5.2.25.Final, 5.next
>
>
> When RAR calls {{XATerminator.recover(int)}} the call chain is not directed to Narayana implementation of XATerminator but it's passed to WFTC where {{ExtendedJBossXATerminator}} method {{doRecover}} is called. But the {{doRecover}} does not provide the expected recovery call - e.g. it does not accept flags ({{XAResource.TMSTARTRSCAN}}, {{XAResource.TMENDRSCAN}}) to drive the whole recovery process in case.
> The biggest functionality trouble is for JTS where {{XATerminatorImple}} does not implement intentionally the {{doRecover}} function (https://github.com/jbosstm/narayana/blob/5.5.24.Final/ArjunaJTS/jtax/clas...). Thus RAR using call {{XATerminator.recover}} when JTS is under use does nothing.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 10 months
[JBoss JIRA] (JBTM-2905) JCAServerTransactionHeaderReader is placed under tests package which makes troubles for tooling
by Ondra Chaloupka (JIRA)
[ https://issues.jboss.org/browse/JBTM-2905?page=com.atlassian.jira.plugin.... ]
Ondra Chaloupka commented on JBTM-2905:
---------------------------------------
[~tomjenkinson] there was not directly linked JBEAP issue to this. Maybe one could be created. It was found during my investigation and the main issue here was the error message {{ARJUNA012389: OSB: Error constructing record header}} during container startup.
The reason why that was linked to the JBEAP was that my understanding of not having the header reader available was the fact of having trouble to get working the expired scanner. That was how I understand the functionality. But I can be missing something.
> JCAServerTransactionHeaderReader is placed under tests package which makes troubles for tooling
> -----------------------------------------------------------------------------------------------
>
> Key: JBTM-2905
> URL: https://issues.jboss.org/browse/JBTM-2905
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Components: Tooling
> Affects Versions: 5.6.1.Final
> Reporter: Ondra Chaloupka
> Assignee: Ondra Chaloupka
> Priority: Minor
> Fix For: 5.2.25.Final, 5.next
>
>
> The class {{JCAServerTransactionHeaderReader}} is placed under package {{com.hp.mwtests.ts.jta.jts.tools.}} which means is not available during runtime of tooling. As the header reader is used by {{com.arjuna.ats.arjuna.tools.osb.mbean.ObjStoreBrowser}} it brings situations where the record can't be loaded by tooling. The browser seems to be used by Expiry Scanner and that suffers by that fact.
> The WFLY start sequence contains info of not possible to load the reader when the object store contains some unfinished jca subordinate transaction.
> {code}
> INFO [com.arjuna.ats.arjuna] (MSC service thread 1-4) ARJUNA012389: OSB: Error constructing record header reader: com.hp.mwtests.ts.jta.jts.tools.JCAServerTransactionHeaderReader from [Module "org.jboss.jts" from local module loader @6b419da (finder: local module finder @3b2da18f (roots: /home/ochaloup/Transactions/eap-tests-transactions/jbossts/target/jbossas-jbossts/modules,/home/ochaloup/jboss/jboss-eap-7.1.0.DR19/modules,/home/ochaloup/jboss/jboss-eap-7.1.0.DR19/modules/system/layers/base,/home/ochaloup/Transactions/eap-tests-transactions/jbossts/target/jbossas-jbossts/modules))]
> {code}
> The point is to move the jca reader under jts tooling package to be compiled and distributed in the {{jts}} jar.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 10 months
[JBoss JIRA] (JBTM-2908) JCA committed inflow transaction is not moved to assumed completed category for JTS
by Ondra Chaloupka (JIRA)
[ https://issues.jboss.org/browse/JBTM-2908?page=com.atlassian.jira.plugin.... ]
Issue was automatically transitioned when Ondra Chaloupka created pull request #1192 in GitHub
----------------------------------------------------------------------------------------------
Status: Pull Request Sent (was: Open)
> JCA committed inflow transaction is not moved to assumed completed category for JTS
> -----------------------------------------------------------------------------------
>
> Key: JBTM-2908
> URL: https://issues.jboss.org/browse/JBTM-2908
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Components: JTS
> Affects Versions: 5.6.1.Final, 5.5.24.Final
> Reporter: Ondra Chaloupka
> Assignee: Ondra Chaloupka
>
> We have test which checks whether EIS is capable to finish transaction after JVM crash.
> The scenario is following:
> - 2 test XA resources are enlisted
> - EIS RAR XATerminator calls prepare and commit
> - JVM crash occurs at the start of the first XAResource.commit call
> - app server is restarted
> - doRecoveryScan()/waitForOrphanInterval/doRecoveryScan()
> - both (mock) XAResources are not rolled-back
> - EIS XATerminator.commit is called
> - doRecoveryScan()/waitForOrphanInterval/doRecoveryScan()
> - both (mock) XAResources are committed
> but the committed tx is not removed from log:
> {code}
> jvmCrashAfterPrepareJTS(org.jboss.as.test.jbossts.crashrec.jca.test.JcaInflowTransactionTestCase) Time elapsed: 125.532 sec <<< FAILURE!
> java.lang.AssertionError: After commiting txn there should be no one in the txn log expected:<0> but was:<1>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.jboss.as.test.jbossts.crashrec.jca.test.JcaInflowTransactionTestCase.jvmCrashAfterPrepareJTS(JcaInflowTransactionTestCase.java:763)
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 10 months
[JBoss JIRA] (JBTM-2908) JCA committed inflow transaction is not moved to assumed completed category for JTS
by Ondra Chaloupka (JIRA)
[ https://issues.jboss.org/browse/JBTM-2908?page=com.atlassian.jira.plugin.... ]
Ondra Chaloupka moved JBEAP-11609 to JBTM-2908:
-----------------------------------------------
Project: JBoss Transaction Manager (was: JBoss Enterprise Application Platform)
Key: JBTM-2908 (was: JBEAP-11609)
Workflow: GIT Pull Request workflow (was: CDW with loose statuses v1)
Component/s: JTS
(was: Transactions)
Affects Version/s: 5.6.1.Final
5.5.24.Final
(was: 7.1.0.DR18)
> JCA committed inflow transaction is not moved to assumed completed category for JTS
> -----------------------------------------------------------------------------------
>
> Key: JBTM-2908
> URL: https://issues.jboss.org/browse/JBTM-2908
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Components: JTS
> Affects Versions: 5.6.1.Final, 5.5.24.Final
> Reporter: Ondra Chaloupka
> Assignee: Ondra Chaloupka
>
> We have test which checks whether EIS is capable to finish transaction after JVM crash.
> The scenario is following:
> - 2 test XA resources are enlisted
> - EIS RAR XATerminator calls prepare and commit
> - JVM crash occurs at the start of the first XAResource.commit call
> - app server is restarted
> - doRecoveryScan()/waitForOrphanInterval/doRecoveryScan()
> - both (mock) XAResources are not rolled-back
> - EIS XATerminator.commit is called
> - doRecoveryScan()/waitForOrphanInterval/doRecoveryScan()
> - both (mock) XAResources are committed
> but the committed tx is not removed from log:
> {code}
> jvmCrashAfterPrepareJTS(org.jboss.as.test.jbossts.crashrec.jca.test.JcaInflowTransactionTestCase) Time elapsed: 125.532 sec <<< FAILURE!
> java.lang.AssertionError: After commiting txn there should be no one in the txn log expected:<0> but was:<1>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.jboss.as.test.jbossts.crashrec.jca.test.JcaInflowTransactionTestCase.jvmCrashAfterPrepareJTS(JcaInflowTransactionTestCase.java:763)
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 10 months
[JBoss JIRA] (JBTM-2905) JCAServerTransactionHeaderReader is placed under tests package which makes troubles for tooling
by Ondra Chaloupka (JIRA)
[ https://issues.jboss.org/browse/JBTM-2905?page=com.atlassian.jira.plugin.... ]
Ondra Chaloupka edited comment on JBTM-2905 at 6/16/17 5:56 AM:
----------------------------------------------------------------
[~mmusgrov] ok, that could be my wrong in understanding the issue here. Without the header reader I got troubles to get working ExpiredAssumedCompleteScanner. But I could take it from a wrong end. In that case, this change would be superfluous and the fix should go in opposite way - removing from the default list and leaving header reader in the test package. Can you please elaborate a bit on what is the correct way of fixing it? Thanks in advance!
was (Author: ochaloup):
[~mmusgrov] ok, that could be my wrong in understanding the issue here. Without the header reader I got troubles to get working ExpiredAssumedCompleteScanner. But I could take it from a wrong end. In that case, this change would be superfluous and the fix should go in opposite way - removing from the default list and leaving header reader in the test package. Can you please elaborate a bit on it what is the correct way of fixing it? Thanks in advance!
> JCAServerTransactionHeaderReader is placed under tests package which makes troubles for tooling
> -----------------------------------------------------------------------------------------------
>
> Key: JBTM-2905
> URL: https://issues.jboss.org/browse/JBTM-2905
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Components: Tooling
> Affects Versions: 5.6.1.Final
> Reporter: Ondra Chaloupka
> Assignee: Ondra Chaloupka
> Priority: Minor
> Fix For: 5.2.25.Final, 5.next
>
>
> The class {{JCAServerTransactionHeaderReader}} is placed under package {{com.hp.mwtests.ts.jta.jts.tools.}} which means is not available during runtime of tooling. As the header reader is used by {{com.arjuna.ats.arjuna.tools.osb.mbean.ObjStoreBrowser}} it brings situations where the record can't be loaded by tooling. The browser seems to be used by Expiry Scanner and that suffers by that fact.
> The WFLY start sequence contains info of not possible to load the reader when the object store contains some unfinished jca subordinate transaction.
> {code}
> INFO [com.arjuna.ats.arjuna] (MSC service thread 1-4) ARJUNA012389: OSB: Error constructing record header reader: com.hp.mwtests.ts.jta.jts.tools.JCAServerTransactionHeaderReader from [Module "org.jboss.jts" from local module loader @6b419da (finder: local module finder @3b2da18f (roots: /home/ochaloup/Transactions/eap-tests-transactions/jbossts/target/jbossas-jbossts/modules,/home/ochaloup/jboss/jboss-eap-7.1.0.DR19/modules,/home/ochaloup/jboss/jboss-eap-7.1.0.DR19/modules/system/layers/base,/home/ochaloup/Transactions/eap-tests-transactions/jbossts/target/jbossas-jbossts/modules))]
> {code}
> The point is to move the jca reader under jts tooling package to be compiled and distributed in the {{jts}} jar.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 10 months
[JBoss JIRA] (JBTM-2905) JCAServerTransactionHeaderReader is placed under tests package which makes troubles for tooling
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-2905?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson reopened JBTM-2905:
---------------------------------
Just for backport to 5.5
> JCAServerTransactionHeaderReader is placed under tests package which makes troubles for tooling
> -----------------------------------------------------------------------------------------------
>
> Key: JBTM-2905
> URL: https://issues.jboss.org/browse/JBTM-2905
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Components: Tooling
> Affects Versions: 5.6.1.Final
> Reporter: Ondra Chaloupka
> Assignee: Ondra Chaloupka
> Priority: Minor
> Fix For: 5.2.25.Final, 5.next
>
>
> The class {{JCAServerTransactionHeaderReader}} is placed under package {{com.hp.mwtests.ts.jta.jts.tools.}} which means is not available during runtime of tooling. As the header reader is used by {{com.arjuna.ats.arjuna.tools.osb.mbean.ObjStoreBrowser}} it brings situations where the record can't be loaded by tooling. The browser seems to be used by Expiry Scanner and that suffers by that fact.
> The WFLY start sequence contains info of not possible to load the reader when the object store contains some unfinished jca subordinate transaction.
> {code}
> INFO [com.arjuna.ats.arjuna] (MSC service thread 1-4) ARJUNA012389: OSB: Error constructing record header reader: com.hp.mwtests.ts.jta.jts.tools.JCAServerTransactionHeaderReader from [Module "org.jboss.jts" from local module loader @6b419da (finder: local module finder @3b2da18f (roots: /home/ochaloup/Transactions/eap-tests-transactions/jbossts/target/jbossas-jbossts/modules,/home/ochaloup/jboss/jboss-eap-7.1.0.DR19/modules,/home/ochaloup/jboss/jboss-eap-7.1.0.DR19/modules/system/layers/base,/home/ochaloup/Transactions/eap-tests-transactions/jbossts/target/jbossas-jbossts/modules))]
> {code}
> The point is to move the jca reader under jts tooling package to be compiled and distributed in the {{jts}} jar.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 10 months
[JBoss JIRA] (JBTM-2905) JCAServerTransactionHeaderReader is placed under tests package which makes troubles for tooling
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-2905?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson updated JBTM-2905:
--------------------------------
Fix Version/s: 5.2.25.Final
(was: 5.5.24.Final)
> JCAServerTransactionHeaderReader is placed under tests package which makes troubles for tooling
> -----------------------------------------------------------------------------------------------
>
> Key: JBTM-2905
> URL: https://issues.jboss.org/browse/JBTM-2905
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Components: Tooling
> Affects Versions: 5.6.1.Final
> Reporter: Ondra Chaloupka
> Assignee: Ondra Chaloupka
> Priority: Minor
> Fix For: 5.2.25.Final, 5.next
>
>
> The class {{JCAServerTransactionHeaderReader}} is placed under package {{com.hp.mwtests.ts.jta.jts.tools.}} which means is not available during runtime of tooling. As the header reader is used by {{com.arjuna.ats.arjuna.tools.osb.mbean.ObjStoreBrowser}} it brings situations where the record can't be loaded by tooling. The browser seems to be used by Expiry Scanner and that suffers by that fact.
> The WFLY start sequence contains info of not possible to load the reader when the object store contains some unfinished jca subordinate transaction.
> {code}
> INFO [com.arjuna.ats.arjuna] (MSC service thread 1-4) ARJUNA012389: OSB: Error constructing record header reader: com.hp.mwtests.ts.jta.jts.tools.JCAServerTransactionHeaderReader from [Module "org.jboss.jts" from local module loader @6b419da (finder: local module finder @3b2da18f (roots: /home/ochaloup/Transactions/eap-tests-transactions/jbossts/target/jbossas-jbossts/modules,/home/ochaloup/jboss/jboss-eap-7.1.0.DR19/modules,/home/ochaloup/jboss/jboss-eap-7.1.0.DR19/modules/system/layers/base,/home/ochaloup/Transactions/eap-tests-transactions/jbossts/target/jbossas-jbossts/modules))]
> {code}
> The point is to move the jca reader under jts tooling package to be compiled and distributed in the {{jts}} jar.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 10 months