April 2018 - jbossts-issues - Jboss List Archives

[JBoss JIRA] (JBTM-3012) Cache recovery connection in Tomcat integration

by Tom Jenkinson (JIRA)

Tom Jenkinson created JBTM-3012: ----------------------------------- Summary: Cache recovery connection in Tomcat integration Key: JBTM-3012 URL: https://issues.jboss.org/browse/JBTM-3012 Project: JBoss Transaction Manager Issue Type: Bug Components: Tomcat Reporter: Tom Jenkinson Assignee: Tom Jenkinson Fix For: 5.next The current TransactionalDataSourceFactory allocates a new XAConnection per recovery manager cycle. It would be better to close it or cache it so we don't get the possibility of a leak with perhaps some databases -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years

1
0
0 / 0

[JBoss JIRA] (JBTM-3008) Upgrade to Tomcat 9.0

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/JBTM-3008?page=com.atlassian.jira.plugin.... ] Issue was automatically transitioned when Tom Jenkinson created pull request #1299 in GitHub -------------------------------------------------------------------------------------------- Status: Pull Request Sent (was: Open) > Upgrade to Tomcat 9.0 > --------------------- > > Key: JBTM-3008 > URL: https://issues.jboss.org/browse/JBTM-3008 > Project: JBoss Transaction Manager > Issue Type: Task > Reporter: Amos Feng > Assignee: Amos Feng > Fix For: 5.next > > -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years

1
0
0 / 0

[JBoss JIRA] (JBTM-3005) Add a quickstart showing the Tomcat and DBCP2

by Michal Karm Babacek (JIRA)

[ https://issues.jboss.org/browse/JBTM-3005?page=com.atlassian.jira.plugin.... ] Michal Karm Babacek edited comment on JBTM-3005 at 4/13/18 6:44 AM: -------------------------------------------------------------------- [~tomjenkinson], [~zhfeng], hi guys, I did try yesterday and then again today. Some observations: * My [comment|https://issues.jboss.org/browse/JBTM-3005?focusedCommentId=135582...] is still valid. It does not work as expected. I appreciate Amos' [quickstart|https://github.com/jbosstm/quickstart/pull/221/files], but I utterly fail to understand why don't you fix/rewrite/modify [the original rudimentary recovery test|https://github.com/Karm/narayana/tree/narayana-tomcat-ts/tomcat/tomc...]. I did my best to port the quickstart to the aforementioned test suite, basically dropping the former code altogether. See: [This web app|https://github.com/Karm/narayana/blob/narayana-tomcat-ts-WIP/tomcat/t...]. (And its byteman rule in resources). * It does not work still, with commit causing the phase2commit flat out kill the app; I know it is not being caught in the quickstart app, but it should - [log|https://paste.fedoraproject.org/paste/q~FMpWhTbIgmqswlz1GOaw], [dbtrace|https://paste.fedoraproject.org/paste/ylEYS-SiFVxltjVALuF2KQ]. * Connections to the DB are being exhausted: Each recovery call takes a connection and keeps it: [see log|https://paste.fedoraproject.org/paste/HLD7PIAvkG7Fjvbcx-De8Q], which leads to DB trace: [see trace|https://paste.fedoraproject.org/paste/sjhrHoMVYXQxhYlsSnum7A] * You can find the whole tomcat (17MB) with the web app war file (context.xml, Tomcat DBCP2 with managed package, all in it) on this [gdrive link|https://drive.google.com/file/d/1YU_wPyw7U3PofCQeZdWxZTvUajijgCoP/vi...]. The source of the web app is [here|https://github.com/Karm/narayana/blob/narayana-tomcat-ts-WIP/tomcat/...]. Note the [TransactionalDataSourceFactory.java|https://github.com/Karm/narayana/blob...]. Also note that the Tomcat DBCP jar and Tomcat Juli jar are present in the war file and not in /lib to avoid classloader issues. * *EDIT 2018-04-13:* One can use Maven Central to get Tomcat DBCP2 + Manged package now: {noformat}<dependency> <groupId>org.apache.tomcat</groupId> <artifactId>tomcat-dbcp</artifactId> <version>9.0.7</version> </dependency>{noformat} * This is how I start it: {{java -javaagent:$BYTEMAN_HOME/lib/byteman.jar=script:$BTM_SCRIPT -Djava.security.egd=file:/dev/./urandom -Djava.util.logging.config.file=$CATALINA_HOME/conf/logging.properties -Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager -Djdk.tls.ephemeralDHKeySize=2048 -Djava.protocol.handler.pkgs=org.apache.catalina.webresources -Dignore.endorsed.dirs= -classpath $CATALINA_HOME/bin/bootstrap.jar:$CATALINA_HOME/bin/tomcat-juli.jar -Dcatalina.base=$CATALINA_HOME -Dcatalina.home=$CATALINA_HOME -Djava.io.tmpdir=$CATALINA_HOME/temp org.apache.catalina.startup.Bootstrap start}} * The how-to on starting PostgreSQL container and its parameters (e.g. max_connections=20) is here JBTM-3004. h3. Call to action I would like to kindly ask you to either clearly explain in a doc why a particular approach with Helper and enlisting is taken in the [quickstart|https://github.com/jbosstm/quickstart/pull/221/files] and not in [the original rudimentary recovery test|https://github.com/Karm/narayana/tree/narayana-tomcat-ts/tomcat/tomc...], or to open [the original rudimentary recovery test|https://github.com/Karm/narayana/tree/narayana-tomcat-ts/tomcat/tomc...] and refactor it. I naturally prefer the latter. I would like to also ask you to at least once try with PostgreSQL and not with H2. We need at least 1 semi-real-world use case example with a real driver to a real database with a real connection pool issues. The whole thing with Docker and PostgreSQL outlined on JBTM-3004 is meant to help you to give it a spin in ~2 minutes without any DBAllocator / remote DB hassle. The final goal is to have [the original rudimentary recovery test|https://github.com/Karm/narayana/tree/narayana-tomcat-ts/tomcat/tomc...] ported to the usage of the recovery helper and the new factory so as it works with Tomcat DBCP2, Byteman rules (and not things like [this|https://github.com/jbosstm/quickstart/pull/221/files#diff-c05f008e01...]). I am willing to do the leg work, to move stuff around, to modify the listener on the Tomcat side, to polish the TS, but I need your help with the Narayana specifics and the current quickstart just doesn't cut it. was (Author: mbabacek): [~tomjenkinson], [~zhfeng], hi guys, I did try yesterday and then again today. Some observations: * My [comment|https://issues.jboss.org/browse/JBTM-3005?focusedCommentId=135582...] is still valid. It does not work as expected. I appreciate Amos' [quickstart|https://github.com/jbosstm/quickstart/pull/221/files], but I utterly fail to understand why don't you fix/rewrite/modify [the original rudimentary recovery test|https://github.com/Karm/narayana/tree/narayana-tomcat-ts/tomcat/tomc...]. I did my best to port the quickstart to the aforementioned test suite, basically dropping the former code altogether. See: [This web app|https://github.com/Karm/narayana/blob/narayana-tomcat-ts-WIP/tomcat/t...]. (And its byteman rule in resources). * It does not work still, with commit causing the phase2commit flat out kill the app; I know it is not being caught in the quickstart app, but it should - [log|https://paste.fedoraproject.org/paste/q~FMpWhTbIgmqswlz1GOaw], [dbtrace|https://paste.fedoraproject.org/paste/ylEYS-SiFVxltjVALuF2KQ]. * Connections to the DB are being exhausted: Each recovery call takes a connection and keeps it: [see log|https://paste.fedoraproject.org/paste/HLD7PIAvkG7Fjvbcx-De8Q], which leads to DB trace: [see trace|https://paste.fedoraproject.org/paste/sjhrHoMVYXQxhYlsSnum7A] * You can find the whole tomcat (17MB) with the web app war file (context.xml, Tomcat DBCP2 with managed package, all in it) on this [gdrive link|https://drive.google.com/file/d/1YU_wPyw7U3PofCQeZdWxZTvUajijgCoP/vi...]. The source of the web app is [here|https://github.com/Karm/narayana/blob/narayana-tomcat-ts-WIP/tomcat/...]. Note the [TransactionalDataSourceFactory.java|https://github.com/Karm/narayana/blob...]. Also note that the Tomcat DBCP jar and Tomcat Juli jar are present in the war file and not in /lib to avoid classloader issues. * This is how I start it: {{java -javaagent:$BYTEMAN_HOME/lib/byteman.jar=script:$BTM_SCRIPT -Djava.security.egd=file:/dev/./urandom -Djava.util.logging.config.file=$CATALINA_HOME/conf/logging.properties -Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager -Djdk.tls.ephemeralDHKeySize=2048 -Djava.protocol.handler.pkgs=org.apache.catalina.webresources -Dignore.endorsed.dirs= -classpath $CATALINA_HOME/bin/bootstrap.jar:$CATALINA_HOME/bin/tomcat-juli.jar -Dcatalina.base=$CATALINA_HOME -Dcatalina.home=$CATALINA_HOME -Djava.io.tmpdir=$CATALINA_HOME/temp org.apache.catalina.startup.Bootstrap start}} * The how-to on starting PostgreSQL container and its parameters (e.g. max_connections=20) is here JBTM-3004. h3. Call to action I would like to kindly ask you to either clearly explain in a doc why a particular approach with Helper and enlisting is taken in the [quickstart|https://github.com/jbosstm/quickstart/pull/221/files] and not in [the original rudimentary recovery test|https://github.com/Karm/narayana/tree/narayana-tomcat-ts/tomcat/tomc...], or to open [the original rudimentary recovery test|https://github.com/Karm/narayana/tree/narayana-tomcat-ts/tomcat/tomc...] and refactor it. I naturally prefer the latter. I would like to also ask you to at least once try with PostgreSQL and not with H2. We need at least 1 semi-real-world use case example with a real driver to a real database with a real connection pool issues. The whole thing with Docker and PostgreSQL outlined on JBTM-3004 is meant to help you to give it a spin in ~2 minutes without any DBAllocator / remote DB hassle. The final goal is to have [the original rudimentary recovery test|https://github.com/Karm/narayana/tree/narayana-tomcat-ts/tomcat/tomc...] ported to the usage of the recovery helper and the new factory so as it works with Tomcat DBCP2, Byteman rules (and not things like [this|https://github.com/jbosstm/quickstart/pull/221/files#diff-c05f008e01...]). I am willing to do the leg work, to move stuff around, to modify the listener on the Tomcat side, to polish the TS, but I need your help with the Narayana specifics and the current quickstart just doesn't cut it. > Add a quickstart showing the Tomcat and DBCP2 > --------------------------------------------- > > Key: JBTM-3005 > URL: https://issues.jboss.org/browse/JBTM-3005 > Project: JBoss Transaction Manager > Issue Type: Task > Components: Demonstrator > Reporter: Amos Feng > Assignee: Amos Feng > Fix For: 5.8.1.Final > > > This quickstart needs to show how to use the DBCP2 in Tomcat to support the XA transaction. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years

1
0
0 / 0

[JBoss JIRA] (JBTM-3005) Add a quickstart showing the Tomcat and DBCP2

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/JBTM-3005?page=com.atlassian.jira.plugin.... ] Tom Jenkinson reopened JBTM-3005: --------------------------------- > Add a quickstart showing the Tomcat and DBCP2 > --------------------------------------------- > > Key: JBTM-3005 > URL: https://issues.jboss.org/browse/JBTM-3005 > Project: JBoss Transaction Manager > Issue Type: Task > Components: Demonstrator > Reporter: Amos Feng > Assignee: Amos Feng > Fix For: 5.8.1.Final > > > This quickstart needs to show how to use the DBCP2 in Tomcat to support the XA transaction. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years

1
0
0 / 0

[JBoss JIRA] (JBTM-3005) Add a quickstart showing the Tomcat and DBCP2

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/JBTM-3005?page=com.atlassian.jira.plugin.... ] Tom Jenkinson resolved JBTM-3005. --------------------------------- Resolution: Done > Add a quickstart showing the Tomcat and DBCP2 > --------------------------------------------- > > Key: JBTM-3005 > URL: https://issues.jboss.org/browse/JBTM-3005 > Project: JBoss Transaction Manager > Issue Type: Task > Components: Demonstrator > Reporter: Amos Feng > Assignee: Amos Feng > Fix For: 5.8.1.Final > > > This quickstart needs to show how to use the DBCP2 in Tomcat to support the XA transaction. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years

1
0
0 / 0

[JBoss JIRA] (JBTM-3005) Add a quickstart showing the Tomcat and DBCP2

by Michal Karm Babacek (JIRA)

[ https://issues.jboss.org/browse/JBTM-3005?page=com.atlassian.jira.plugin.... ] Michal Karm Babacek commented on JBTM-3005: ------------------------------------------- [~tomjenkinson], {quote} ...Karm could create a thread on our developer space to discuss this... {quote} O.K., let's continue here: https://developer.jboss.org/message/981896#981896 {quote} ...we are discussing something that is now not related to a DBCP2 quickstart... {quote} The topic is still closely related to the quick start. The point is that the JIRA should not be closed as the quick start does not do what it should, IMHO. It should be a comprehensive, best practice demonstration for users to bootstrap their web applications. Let me advocate for the opinion that if I cannot use it with Tomcat 9, Tomcat DBCP2 and PostgreSQL, it still needs a touch or two. Regarding "I cannot": Let's assume I posses some at least rudimentary Java skills. If I cannot figure it out from the quickstart and its README, the quickstart is not finished. {quote} ...we are talking about Karms test... {quote} We are not talking about Karm's test, we are talking about [~gytis]' test. He designed the test app. The configuration generation for JBTM-3004 is abandoned, Tomcat JDBC path is dead, but that is just the configuration generator. The test web app stays similar - with addition of the new factory etc. as elaborated on in my previous comment. {quote} Karm - did you try to take Amos' quickstart and run it with Postgres for example? {quote} I did - with Tomcat DBCP2 + Managed instead of Amos' org.apache.commons imports, with PostgreSQL and with Tomcat 9 and I really fail to see the expected results as discussed earlier. Moving to https://developer.jboss.org/message/981896#981896, if you prefer it. > Add a quickstart showing the Tomcat and DBCP2 > --------------------------------------------- > > Key: JBTM-3005 > URL: https://issues.jboss.org/browse/JBTM-3005 > Project: JBoss Transaction Manager > Issue Type: Task > Components: Demonstrator > Reporter: Amos Feng > Assignee: Amos Feng > Fix For: 5.8.1.Final > > > This quickstart needs to show how to use the DBCP2 in Tomcat to support the XA transaction. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years

1
0
0 / 0

[JBoss JIRA] (JBTM-3011) Uploading lra coordinator docker image should be part of the narayana release process

by Ondra Chaloupka (JIRA)

[ https://issues.jboss.org/browse/JBTM-3011?page=com.atlassian.jira.plugin.... ] Ondra Chaloupka updated JBTM-3011: ---------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done > Uploading lra coordinator docker image should be part of the narayana release process > ------------------------------------------------------------------------------------- > > Key: JBTM-3011 > URL: https://issues.jboss.org/browse/JBTM-3011 > Project: JBoss Transaction Manager > Issue Type: Enhancement > Components: Build System, LRA > Affects Versions: 5.8.1.Final > Reporter: Ondra Chaloupka > Assignee: Ondra Chaloupka > > when narayana release is run we should consider pushing the lra docker image to the docker hub at the https://hub.docker.com/r/jbosstm/lra-coordinator/ -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years

1
0
0 / 0

[JBoss JIRA] (JBTM-3005) Add a quickstart showing the Tomcat and DBCP2

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/JBTM-3005?page=com.atlassian.jira.plugin.... ] Tom Jenkinson commented on JBTM-3005: ------------------------------------- Perhaps Karm could create a thread on our developer space to discuss this as that is the usual place we prefer to discuss the problems as they don't always strictly relate to a single issue: https://developer.jboss.org/en/jbosstm/dev/content?filterID=contentstatus... That discussion can then be linked from this issue in the forum if it does make sense. However, this particular Jira pertains to a DBCP2 Quickstart and we are discussing something that is now not related to a DBCP2 quickstart - we are talking about Karms test which I think was originally produced for JBTM-3004 To keep on the quickstart, Karm - did you try to take Amos' quickstart and run it with Postgres for example? This is not to say that we shouldn't look at your test suite but it would give a simpler reproducer perhaps if it can be replicated there. > Add a quickstart showing the Tomcat and DBCP2 > --------------------------------------------- > > Key: JBTM-3005 > URL: https://issues.jboss.org/browse/JBTM-3005 > Project: JBoss Transaction Manager > Issue Type: Task > Components: Demonstrator > Reporter: Amos Feng > Assignee: Amos Feng > Fix For: 5.8.1.Final > > > This quickstart needs to show how to use the DBCP2 in Tomcat to support the XA transaction. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years

1
0
0 / 0

[JBoss JIRA] (JBTM-3005) Add a quickstart showing the Tomcat and DBCP2

by Michal Karm Babacek (JIRA)

[ https://issues.jboss.org/browse/JBTM-3005?page=com.atlassian.jira.plugin.... ] Michal Karm Babacek commented on JBTM-3005: ------------------------------------------- [~ochaloup], {quote} I'm returning to your previous [comment|https://issues.jboss.org/browse/JBTM-3005?focusedCommentId=135582...] as you say that it's still valid (is that right?) {quote} It is valid in a sense that the test doesn't work. The code has evolved since, obviously, hence the updated comment from [yesterday|https://issues.jboss.org/browse/JBTM-3005?focusedCommentId=1356...]. {quote} I seems there is recovery manager not running at all. {quote} It runs fine. I don't know what you mean. Obviously, it is in web.xml as it used to be. {quote} Either way I tried the test where I borrowed your context.xml and run it as it is in the tomcat-jta repo {quote} It does not. * You have {{import org.apache.commons.dbcp2.}} imports there; you are not using the things from my example, you are not using Tomcat DBCP2+Managed * You did not demonstrate a single transaction with DB * You did not interrupt a single commit with Byteman * You did not demonstrate any recovery Your comment doesn't make anything clearer unless I missed a link to a test or something. > Add a quickstart showing the Tomcat and DBCP2 > --------------------------------------------- > > Key: JBTM-3005 > URL: https://issues.jboss.org/browse/JBTM-3005 > Project: JBoss Transaction Manager > Issue Type: Task > Components: Demonstrator > Reporter: Amos Feng > Assignee: Amos Feng > Fix For: 5.8.1.Final > > > This quickstart needs to show how to use the DBCP2 in Tomcat to support the XA transaction. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years

1
0
0 / 0

[JBoss JIRA] (JBTM-3011) Uploading lra coordinator docker image should be part of the narayana release process

by Ondra Chaloupka (JIRA)

[ https://issues.jboss.org/browse/JBTM-3011?page=com.atlassian.jira.plugin.... ] Issue was automatically transitioned when Ondra Chaloupka created pull request #1298 in GitHub ---------------------------------------------------------------------------------------------- Status: Pull Request Sent (was: Open) > Uploading lra coordinator docker image should be part of the narayana release process > ------------------------------------------------------------------------------------- > > Key: JBTM-3011 > URL: https://issues.jboss.org/browse/JBTM-3011 > Project: JBoss Transaction Manager > Issue Type: Enhancement > Components: Build System, LRA > Affects Versions: 5.8.1.Final > Reporter: Ondra Chaloupka > Assignee: Ondra Chaloupka > > when narayana release is run we should consider pushing the lra docker image to the docker hub at the https://hub.docker.com/r/jbosstm/lra-coordinator/ -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

jbossts-issues April 2018