[JBoss JIRA] (JBTM-2880) Refactor codebase to minimize usage of e.printStackTrace() call and change for using logger
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-2880?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson closed JBTM-2880.
-------------------------------
> Refactor codebase to minimize usage of e.printStackTrace() call and change for using logger
> -------------------------------------------------------------------------------------------
>
> Key: JBTM-2880
> URL: https://issues.jboss.org/browse/JBTM-2880
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Affects Versions: 5.5.6.Final
> Reporter: Ondra Chaloupka
> Assignee: Ondra Chaloupka
> Priority: Minor
> Fix For: 5.9.0.Final
>
>
> The code base uses call `e.printStackTrace()` on several places. That usage should be minimized and used only when it's good reason for it. In general such calls should be replaced printing with `logger`, probably in level `WARN` with some additional information, why the stacktrace is printed - what error occured - included.
> By quick check these are places where exception stack trace is printed directly to `stderr`.
> {code}
> -vertx/shared/src/main/java/ClientVerticle.java-
> -vertx/shared/src/main/java/SampleVerticle2.java-
> -vertx/shared/src/main/java/SampleVerticle1.java-
> osgi/jta/src/main/java/org/jboss/narayana/osgi/jta/internal/ObjStoreBrowserImpl.java
> XTS/WSAS/classes/com/arjuna/mwlabs/wsas/UserActivityImple.java
> XTS/WSAS/classes/com/arjuna/mwlabs/wsas/activity/ActivityHandleImple.java
> XTS/WSCF/classes/com/arjuna/mwlabs/wscf11/model/sagas/arjunacore/SagasHLSImple.java
> XTS/WSCF/classes/com/arjuna/mwlabs/wscf11/model/twophase/arjunacore/TwoPhaseHLSImple.java
> XTS/WSCF/classes/com/arjuna/mwlabs/wscf/model/sagas/arjunacore/ParticipantRecord.java
> XTS/WSCF/classes/com/arjuna/mwlabs/wscf/model/sagas/arjunacore/CoordinatorControl.java
> XTS/WSCF/classes/com/arjuna/mwlabs/wscf/model/twophase/arjunacore/ParticipantRecord.java
> XTS/WSCF/classes/com/arjuna/mwlabs/wscf/model/twophase/arjunacore/CoordinatorControl.java
> XTS/WSCF/classes/com/arjuna/mw/wscf/utils/DomUtil.java
> XTS/WSCF/classes/com/arjuna/mw/wscf/protocols/ProtocolManager.java
> XTS/WSTX/classes/com/arjuna/mwlabs/wst11/at/RegistrarImple.java
> XTS/WSTX/classes/com/arjuna/mwlabs/wst11/at/context/ArjunaContextImple.java
> XTS/WSTX/classes/com/arjuna/mwlabs/wst11/at/remote/TransactionManagerImple.java
> XTS/WSTX/classes/com/arjuna/mwlabs/wst11/at/remote/UserTransactionImple.java
> XTS/WSTX/classes/com/arjuna/mwlabs/wst11/at/remote/UserTransactionStandaloneImple.java
> XTS/WSTX/classes/com/arjuna/mwlabs/wst11/at/participants/CleanupSynchronization.java
> XTS/WSTX/classes/com/arjuna/mwlabs/wst11/at/ContextFactoryImple.java
> XTS/WSTX/classes/com/arjuna/mwlabs/wst11/ba/context/ArjunaContextImple.java
> XTS/WSTX/classes/com/arjuna/mwlabs/wst11/ba/remote/UserBusinessActivityImple.java
> XTS/WSTX/classes/com/arjuna/mwlabs/wst11/ba/remote/BusinessActivityManagerImple.java
> XTS/WSTX/classes/com/arjuna/mwlabs/wst11/ba/remote/BAParticipantManagerImple.java
> XTS/WSTX/classes/com/arjuna/mwlabs/wst11/ba/remote/UserBusinessActivityStandaloneImple.java
> XTS/WSTX/classes/com/arjuna/mwlabs/wst11/ba/participants/CleanupSynchronization.java
> XTS/WSTX/classes/com/arjuna/mwlabs/wst11/ba/ContextFactoryImple.java
> XTS/WSTX/classes/com/arjuna/mwlabs/wst/at/participants/DurableTwoPhaseCommitParticipant.java
> XTS/localjunit/WSTX11-interop/src/main/java/com/jboss/transaction/txinterop/proxy/ProxyListenerService.java
> XTS/localjunit/WSTFSC07-interop/src/main/java/com/jboss/transaction/wstf/proxy/ProxyListenerService.java
> XTS/WS-T/dev/src/com/arjuna/schemas/ws/_2005/_10/wsarjtx/TerminationCoordinatorRPCService.java
> XTS/WS-T/dev/src/com/arjuna/wst11/stub/CompletionStub.java
> XTS/WS-T/dev/src/com/arjuna/wst11/stub/CompletionRPCStub.java
> XTS/WS-T/dev/src/com/arjuna/wst11/stub/BusinessActivityTerminatorRPCStub.java
> XTS/WS-T/dev/src/com/arjuna/wst11/messaging/TerminationCoordinatorRPCProcessorImpl.java
> XTS/WS-T/dev/src/com/arjuna/wst11/messaging/CompletionCoordinatorProcessorImpl.java
> XTS/WS-T/dev/src/com/arjuna/wst11/messaging/CompletionCoordinatorRPCProcessorImpl.java
> XTS/WS-T/dev/src/com/arjuna/wst11/messaging/TerminationCoordinatorProcessorImpl.java
> XTS/WS-C/dev/src/com/arjuna/wsc11/messaging/ActivationCoordinatorProcessorImpl.java
> XTS/WS-C/dev/src/com/arjuna/wsc11/messaging/RegistrationCoordinatorProcessorImpl.java
> XTS/WS-C/dev/src/com/arjuna/webservices/SoapFault.java
> ArjunaJTA/jta/classes/com/arjuna/ats/jta/xa/XidImple.java
> ArjunaJTA/jta/classes/com/arjuna/ats/internal/jta/transaction/arjunacore/jca/XATerminatorImple.java
> ArjunaJTA/jta/classes/com/arjuna/ats/internal/jta/transaction/arjunacore/jca/TransactionImporterImple.java
> ArjunaJTA/jta/classes/com/arjuna/ats/internal/jta/transaction/arjunacore/TransactionImple.java
> ArjunaJTA/jta/classes/com/arjuna/ats/internal/jta/transaction/arjunacore/subordinate/TransactionImple.java
> ArjunaJTA/jta/classes/com/arjuna/ats/internal/jta/recovery/arjunacore/SubordinateJTAXAResourceOrphanFilter.java
> ArjunaJTA/jdbc/classes/com/arjuna/ats/internal/jdbc/DirectRecoverableConnection.java
> ArjunaJTA/jdbc/classes/com/arjuna/ats/internal/jdbc/ConnectionManager.java
> ArjunaJTA/jdbc/classes/com/arjuna/ats/internal/jdbc/ProvidedXADataSourceConnection.java
> ArjunaJTA/jdbc/classes/com/arjuna/ats/internal/jdbc/IndirectRecoverableConnection.java
> ArjunaJTA/jdbc/classes/com/arjuna/ats/internal/jdbc/recovery/JDBCXARecovery.java
> blacktie/utils/cpp-plugin/src/main/java/org/jboss/narayana/blacktie/plugins/AddCommonSources.java
> blacktie/jatmibroker-xatmi/src/main/java/org/jboss/narayana/blacktie/jatmibroker/core/server/SocketServer.java
> blacktie/wildfly-blacktie/subsystem/src/main/java/org/codehaus/stomp/jms/ProtocolConverter.java
> blacktie/blacktie-admin-services/src/main/java/org/jboss/narayana/blacktie/administration/core/AdministrationProxy.java
> tools/src/main/java/io/narayana/perf/Measurement.java
> rts/at/tx/src/main/java/org/jboss/jbossts/star/resource/RESTRecord.java
> rts/at/tx/src/main/java/org/jboss/jbossts/star/service/Coordinator.java
> txframework/src/main/java/org/jboss/narayana/txframework/impl/Participant.java
> compensations/src/main/java/org/jboss/narayana/compensations/internal/ParticipantInterceptor.java
> compensations/src/main/java/org/jboss/narayana/compensations/internal/ParticipantImpl.java
> ArjunaCore/arjuna/services/classes/com/arjuna/ats/arjuna/services/recovery/RecoveryManagerService.java
> ArjunaCore/arjuna/classes/com/arjuna/ats/internal/arjuna/utils/AndroidProcessId.java
> ArjunaCore/arjuna/classes/com/arjuna/ats/internal/arjuna/abstractrecords/CadaverRecord.java
> ArjunaCore/arjuna/classes/com/arjuna/ats/internal/arjuna/objectstore/ShadowingStore.java
> ArjunaCore/arjuna/classes/com/arjuna/ats/internal/arjuna/objectstore/CacheStore.java
> ArjunaCore/arjuna/classes/com/arjuna/ats/internal/arjuna/objectstore/LogStore.java
> ArjunaCore/arjuna/classes/com/arjuna/ats/arjuna/coordinator/AbstractRecord.java
> ArjunaCore/arjuna/classes/com/arjuna/ats/arjuna/coordinator/BasicAction.java
> ArjunaCore/arjuna/classes/com/arjuna/ats/arjuna/common/ObjectStoreEnvironmentBean.java
> ArjunaCore/arjuna/classes/com/arjuna/ats/arjuna/tools/log/LogBrowser.java
> ArjunaCore/arjuna/classes/com/arjuna/ats/arjuna/tools/stats/TxPerfGraph.java
> ArjunaCore/arjuna/classes/com/arjuna/ats/arjuna/tools/OTM.java
> ArjunaCore/arjuna/classes/com/arjuna/ats/arjuna/StateManager.java
> ArjunaCore/arjuna/classes/com/arjuna/ats/arjuna/recovery/RecoveryManager.java
> ArjunaJTS/integration/src/main/java/com/arjuna/ats/internal/jbossatx/jta/jca/XATerminator.java
> ArjunaJTS/integration/src/main/java/com/arjuna/ats/internal/jbossatx/jts/jca/XATerminator.java
> ArjunaJTS/integration/src/main/java/com/arjuna/ats/internal/jbossatx/jts/PropagationContextManager.java
> ArjunaJTS/jtax/classes/com/arjuna/ats/internal/jta/transaction/jts/jca/XATerminatorImple.java
> ArjunaJTS/jtax/classes/com/arjuna/ats/internal/jta/transaction/jts/BaseTransaction.java
> ArjunaJTS/jtax/classes/com/arjuna/ats/internal/jta/transaction/jts/TransactionImple.java
> ArjunaJTS/jtax/classes/com/arjuna/ats/internal/jta/transaction/jts/subordinate/jca/coordinator/ServerTransaction.java
> ArjunaJTS/jtax/classes/com/arjuna/ats/internal/jta/transaction/jts/subordinate/jca/SubordinateAtomicTransaction.java
> ArjunaJTS/jtax/classes/com/arjuna/ats/internal/jta/transaction/jts/subordinate/TransactionImple.java
> ArjunaJTS/jtax/classes/com/arjuna/ats/internal/jta/transaction/jts/subordinate/SubordinateAtomicTransaction.java
> ArjunaJTS/jtax/classes/com/arjuna/ats/internal/jta/resources/jts/orbspecific/XAResourceRecord.java
> ArjunaJTS/jtax/classes/com/arjuna/ats/internal/jta/recovery/jts/JCAServerTransactionRecoveryModule.java
> ArjunaJTS/orbportability/classes/com/arjuna/orbportability/common/ant/IDLCompiler.java
> ArjunaJTS/jts/services/classes/com/arjuna/ats/jts/services/transactionserver/TransactionServerService.java
> ArjunaJTS/jts/classes/com/arjuna/ats/internal/jts/utils/TxStoreLog.java
> ArjunaJTS/jts/classes/com/arjuna/ats/internal/jts/orbspecific/interposition/ServerControl.java
> ArjunaJTS/jts/classes/com/arjuna/ats/internal/jts/orbspecific/coordinator/ArjunaTransactionImple.java
> ArjunaJTS/jts/classes/com/arjuna/ats/internal/jts/orbspecific/jacorb/recoverycoordinators/ORBRunner.java
> ArjunaJTS/jts/classes/com/arjuna/ats/internal/jts/orbspecific/jacorb/recoverycoordinators/JacOrbRCServiceInit.java
> ArjunaJTS/jts/classes/com/arjuna/ats/internal/jts/orbspecific/ibmorb/recoverycoordinators/ORBRunner.java
> ArjunaJTS/jts/classes/com/arjuna/ats/internal/jts/orbspecific/javaidl/recoverycoordinators/ORBRunner.java
> ArjunaJTS/jts/classes/com/arjuna/ats/internal/jts/orbspecific/CurrentImple.java
> ArjunaJTS/jts/classes/com/arjuna/ats/internal/jts/orbspecific/TransactionFactoryImple.java
> ArjunaJTS/jts/classes/com/arjuna/ats/internal/jts/orbspecific/recovery/RecoveryEnablement.java
> ArjunaJTS/jts/classes/com/arjuna/ats/internal/jts/context/ContextManager.java
> ArjunaJTS/jts/classes/com/arjuna/ats/internal/jts/resources/ExtendedResourceRecord.java
> ArjunaJTS/jts/classes/com/arjuna/ats/jts/TransactionServer.java
> ArjunaJTS/jts/classes/com/arjuna/ats/jts/orbspecific/jacorb/interceptors/interposition/InterpositionClientRequestInterceptorImpl.java
> ArjunaJTS/jts/classes/com/arjuna/ats/jts/orbspecific/jacorb/interceptors/context/ContextServerRequestInterceptorImpl.java
> ArjunaJTS/jts/classes/com/arjuna/ats/jts/orbspecific/ibmorb/interceptors/context/ContextServerRequestInterceptorImpl.java
> ArjunaJTS/jts/classes/com/arjuna/ats/jts/orbspecific/javaidl/interceptors/context/ContextServerRequestInterceptorImpl.java
> ArjunaJTS/jts/classes/com/arjuna/ats/jts/ExplicitInterposition.java
> STM/src/main/java/org/jboss/stm/internal/reflect/InvocationHandler.java
> STM/src/main/java/org/jboss/stm/internal/proxy/OptimisticLockManagerProxy.java
> STM/src/main/java/org/jboss/stm/internal/proxy/LockManagerProxy.java
> STM/src/main/java/org/jboss/stm/internal/optimistic/OptimisticLockRecord.java
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
5 years, 10 months
[JBoss JIRA] (JBTM-3020) Add ability for resources to indicate XA_RDONLY on end
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-3020?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson updated JBTM-3020:
--------------------------------
Fix Version/s: 5.next
(was: 5.9.0.Final)
> Add ability for resources to indicate XA_RDONLY on end
> ------------------------------------------------------
>
> Key: JBTM-3020
> URL: https://issues.jboss.org/browse/JBTM-3020
> Project: JBoss Transaction Manager
> Issue Type: Feature Request
> Reporter: David Lloyd
> Assignee: Ondra Chaloupka
> Fix For: 5.next
>
>
> As discussed in WFLY-10258 and https://developer.jboss.org/message/982097, this request is to add the ability for an XAResource to indicate (on end) that it has no committable work, which would act as a hint to order that XAResource at an earlier point of prepare processing, which will in turn increase the chances of a 1PC optimization occurring.
> As expressed in the forum thread, the mechanism should not interfere with compatibility. One possible way to do this would be to introduce an enhanced subinterface of XAResource which includes a method like this:
> {code:java}
> int endWithResult(Xid xid, int flags) throws XAException;
> {code}
> The method behaves semantically identically to {{XAResource#end}} , except it would be allowed to return {{XA_RDONLY}} or {{XA_OK}}. A value of {{XA_RDONLY}} would indicate that the resource expects to return {{XA_RDONLY}} in response to a {{prepare}} call, whereas a value of {{XA_OK}} indicates that the resource's future {{prepare}} result cannot yet be decided or will be {{XA_OK}}. An invalid result should probably behave equivalently to an {{XAException}} being thrown by the {{end}} method. {{XAER_RMERR}} seems like a reasonable error code for this case. An alternative strategy would be to treat an invalid return value as being equivalent to {{XA_OK}}.
> Since it's a subinterface of {{XAResource}}, it could also define the following default method:
> {code:java}
> default void end(Xid xid, int flags) throws XAException {
> endWithResult(xid, flags);
> }
> {code}
> This method would not need to be called by the TM, but would correctly satisfy the {{XAResource}} contract without requiring the user to implement the redundant method.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
5 years, 10 months
[JBoss JIRA] (JBTM-3019) Testsuite: Docker controller leaves stray volumes and fills up disk space unnecessairly over time
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-3019?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson updated JBTM-3019:
--------------------------------
Fix Version/s: 5.next
(was: 5.9.0.Final)
> Testsuite: Docker controller leaves stray volumes and fills up disk space unnecessairly over time
> -------------------------------------------------------------------------------------------------
>
> Key: JBTM-3019
> URL: https://issues.jboss.org/browse/JBTM-3019
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Components: Testing
> Affects Versions: 5.8.1.Final
> Environment: Docker enabled Jenkins slaves
> Reporter: Michal Karm Babacek
> Assignee: Michal Karm Babacek
> Priority: Minor
> Fix For: 5.next
>
>
> h3. Problem
> The Docker controller that allocates databases as Docker containers cleans up containers and does not leave unnecessary images:
> {code}
> [root@karm-centos7-x86-64 ~]# docker images
> REPOSITORY TAG IMAGE ID CREATED SIZE
> docker.io/postgres 9.4 26bd9b04b948 6 days ago 232 MB
> docker.io/postgres 10 0965cdc98045 6 days ago 234 MB
> docker.io/postgres <none> ed5db6e669ff 7 weeks ago 263 MB
> docker.io/postgres <none> 30121e967865 7 weeks ago 289 MB
> [root@karm-centos7-x86-64 ~]# docker ps -a
> CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
> [root@karm-centos7-x86-64 ~]#
> {code}
> Although it leaves stray container volumes for some reason:
> {code}
> [root@karm-centos7-x86-64 ~]# du -hs /var/lib/docker-latest/volumes
> 15G /var/lib/docker-latest/volumes
> [root@karm-centos7-x86-64 ~]# docker volume ls -qf dangling=true | wc -l
> 409
> {code}
> It unnecessarily clogs the slaves' disk space. The 15G of garbage has been created over dozens and dozens of builds with at least two containers each, but it shouldn't be happening anyway.
> h3. Call to action
> Review whether [removeContainerCmd|https://github.com/jbosstm/narayana/blob/master/tools/...] is supposed to be enough to not only remove the container but to also remove its volume.
> h3. Workaround
> {code}
> docker volume prune
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
5 years, 10 months
[JBoss JIRA] (JBTM-3017) Provide a check to see if the last recovery scan "cleaned" the store.
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-3017?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson closed JBTM-3017.
-------------------------------
> Provide a check to see if the last recovery scan "cleaned" the store.
> ----------------------------------------------------------------------
>
> Key: JBTM-3017
> URL: https://issues.jboss.org/browse/JBTM-3017
> Project: JBoss Transaction Manager
> Issue Type: Feature Request
> Components: Recovery, Tooling
> Affects Versions: 5.8.1.Final
> Reporter: Michael Musgrove
> Assignee: Michael Musgrove
> Fix For: 5.9.0.Final, 5.5.32.Final
>
>
> There are some recovery manager use cases where the user needs to know that the log store is empty and that all orphans have been detected (for example it is possible that some resource managers were not available during the last scan).
> This feature would be particularly useful when running on OpenShift in order to determine when it is safe scale down and reclaim the space used by a pod.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
5 years, 10 months