June 2020 - jbossts-issues - Jboss List Archives

[JBoss JIRA] (JBTM-3325) Create a way to close XAResource at the end of the recovery cycle processing

by Ondrej Chaloupka (Jira)

[ https://issues.redhat.com/browse/JBTM-3325?page=com.atlassian.jira.plugin... ] Ondrej Chaloupka updated JBTM-3325: ----------------------------------- Forum Reference: https://groups.google.com/forum/#!topic/narayana-users/v4Mr__BTliQ > Create a way to close XAResource at the end of the recovery cycle processing > ---------------------------------------------------------------------------- > > Key: JBTM-3325 > URL: https://issues.redhat.com/browse/JBTM-3325 > Project: JBoss Transaction Manager > Issue Type: Enhancement > Components: JTA > Affects Versions: 5.10.5.Final > Reporter: Ondrej Chaloupka > Assignee: Ondrej Chaloupka > Priority: Major > > From discussions about Narayana integration to Agroal (https://agroal.github.io/) there came an idea how to make easier for Agroal to integrate with Narayana recovery processing. > Usually (or at least Agroal does so) the brand new {{XAResource}} is provided from the call of the {{XAResourceRecovery}} (https://github.com/jbosstm/jboss-transaction-spi/blob/7.6.0.Final/src/mai...). > aka. Agroal implements the {{XAResourceRecovery}} and register it with the Narayana with adding it to with https://github.com/jbosstm/jboss-transaction-spi/blob/7.6.0.Final/src/mai... to be used in {{XARecoveryModule}}. > When the periodic recovery cycle ends the {{XAResource}} is not used (next time the recovery processing calls the {{XAResourceRecovery#getXAResources()}} to get the resource for scanning again). The transaction manager announces that the scan ended with call {{XAResource.recover(XAResource.TMENDRSCAN)}} (this is an internal to how Narayana works). > It would be beneficial provide an option that Narayana closes {{XAResource}}s at the end of the recovery cycle when Narayana does not plan to use it again. > The idea is to check if the {{XAResource}} is {{AutoCloseable}} and if so then the {{XAResource}} is closed at the end of the recovery cycle processing. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3325) Create a way to close XAResource at the end of the recovery cycle processing

by Ondrej Chaloupka (Jira)

[ https://issues.redhat.com/browse/JBTM-3325?page=com.atlassian.jira.plugin... ] Ondrej Chaloupka edited comment on JBTM-3325 at 6/3/20 6:22 AM: ---------------------------------------------------------------- [~mmusgrov] I will create the discussion thread on the google groups. Just quick points from my perspective. ad 1) This is an additional feature which can be or could not be used. It may help for some integration purposes (ie. Agroal-Quarkus in particular) ad 2) During the recovery it's the recovery manager thread which uses the XAResource and up to the decision of RM by implementing {{AutoCloseable}} and configure Narayana and provide appropriate instance (ie. probably non-shared) of XAResource. ad 3) We talk about recovery manager here not about TM. ad 4) Agree with the analysis. This issue is a follow-up of an internal discussion on how to help Agroal with integration to Narayana recovery. This change/feature is particular for Narayana and its behaviour. E.g. as one single point of all mentioned - as said Narayana is JTA implementation (not XA while on top of XA) and it does not use the {{int}} to ask for more items on {{recover}} call at all. was (Author: ochaloup): [~mmusgrov] I will create the discussion thread on the google groups. Just quick points from my perspective. ad 1) This is an additional feature which can be or could not be used. It may help for some integration purposes (ie. Agroal-Quarkus in particular) ad 2) During the recovery it's the recovery manager thread which uses the XAResource and up to the decision of RM by implementing {{AutoCloseable}} and configure Narayana and provide appropriate instance (ie. probably non-shared) of XAResource. ad 3) We talk about recovery manager here not about TM. ad 4) Agree with the analysis. This issue is the follow-up on our discussion on how to help with integration with Agroal. This feature is particular for Narayana and its behaviour. E.g. as one single point of all mentioned - as said Narayana is JTA implementation (not XA while on top of XA) and it does not use the {{int}} to ask for more items on {{recover}} call at all. > Create a way to close XAResource at the end of the recovery cycle processing > ---------------------------------------------------------------------------- > > Key: JBTM-3325 > URL: https://issues.redhat.com/browse/JBTM-3325 > Project: JBoss Transaction Manager > Issue Type: Enhancement > Components: JTA > Affects Versions: 5.10.5.Final > Reporter: Ondrej Chaloupka > Assignee: Ondrej Chaloupka > Priority: Major > > From discussions about Narayana integration to Agroal (https://agroal.github.io/) there came an idea how to make easier for Agroal to integrate with Narayana recovery processing. > Usually (or at least Agroal does so) the brand new {{XAResource}} is provided from the call of the {{XAResourceRecovery}} (https://github.com/jbosstm/jboss-transaction-spi/blob/7.6.0.Final/src/mai...). > aka. Agroal implements the {{XAResourceRecovery}} and register it with the Narayana with adding it to with https://github.com/jbosstm/jboss-transaction-spi/blob/7.6.0.Final/src/mai... to be used in {{XARecoveryModule}}. > When the periodic recovery cycle ends the {{XAResource}} is not used (next time the recovery processing calls the {{XAResourceRecovery#getXAResources()}} to get the resource for scanning again). The transaction manager announces that the scan ended with call {{XAResource.recover(XAResource.TMENDRSCAN)}} (this is an internal to how Narayana works). > It would be beneficial provide an option that Narayana closes {{XAResource}}s at the end of the recovery cycle when Narayana does not plan to use it again. > The idea is to check if the {{XAResource}} is {{AutoCloseable}} and if so then the {{XAResource}} is closed at the end of the recovery cycle processing. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3325) Create a way to close XAResource at the end of the recovery cycle processing

by Ondrej Chaloupka (Jira)

[ https://issues.redhat.com/browse/JBTM-3325?page=com.atlassian.jira.plugin... ] Ondrej Chaloupka commented on JBTM-3325: ---------------------------------------- [~mmusgrov] I will create the discussion thread on the google groups. Just quick points from my perspective. ad 1) This is an additional feature which can be or could not be used. It may help for some integration purposes (ie. Agroal-Quarkus in particular) ad 2) During the recovery it's the recovery manager thread which uses the XAResource and up to the decision of RM by implementing {{AutoCloseable}} and configure Narayana and provide appropriate instance (ie. probably non-shared) of XAResource. ad 3) We talk about recovery manager here not about TM. ad 4) Agree with the analysis. This issue is the follow-up on our discussion on how to help with integration with Agroal. This feature is particular for Narayana and its behaviour. E.g. as one single point of all mentioned - as said Narayana is JTA implementation (not XA while on top of XA) and it does not use the {{int}} to ask for more items on {{recover}} call at all. > Create a way to close XAResource at the end of the recovery cycle processing > ---------------------------------------------------------------------------- > > Key: JBTM-3325 > URL: https://issues.redhat.com/browse/JBTM-3325 > Project: JBoss Transaction Manager > Issue Type: Enhancement > Components: JTA > Affects Versions: 5.10.5.Final > Reporter: Ondrej Chaloupka > Assignee: Ondrej Chaloupka > Priority: Major > > From discussions about Narayana integration to Agroal (https://agroal.github.io/) there came an idea how to make easier for Agroal to integrate with Narayana recovery processing. > Usually (or at least Agroal does so) the brand new {{XAResource}} is provided from the call of the {{XAResourceRecovery}} (https://github.com/jbosstm/jboss-transaction-spi/blob/7.6.0.Final/src/mai...). > aka. Agroal implements the {{XAResourceRecovery}} and register it with the Narayana with adding it to with https://github.com/jbosstm/jboss-transaction-spi/blob/7.6.0.Final/src/mai... to be used in {{XARecoveryModule}}. > When the periodic recovery cycle ends the {{XAResource}} is not used (next time the recovery processing calls the {{XAResourceRecovery#getXAResources()}} to get the resource for scanning again). The transaction manager announces that the scan ended with call {{XAResource.recover(XAResource.TMENDRSCAN)}} (this is an internal to how Narayana works). > It would be beneficial provide an option that Narayana closes {{XAResource}}s at the end of the recovery cycle when Narayana does not plan to use it again. > The idea is to check if the {{XAResource}} is {{AutoCloseable}} and if so then the {{XAResource}} is closed at the end of the recovery cycle processing. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3325) Create a way to close XAResource at the end of the recovery cycle processing

by Michael Musgrove (Jira)

[ https://issues.redhat.com/browse/JBTM-3325?page=com.atlassian.jira.plugin... ] Michael Musgrove commented on JBTM-3325: ---------------------------------------- A few of points: 1. It is normally the application servers job to close connections. This method can potentially break assumptions made by the app server. 2. The resource adaptor can be shared by multiple threads so all other threads that are potentially using the adaptor need to be notified. Agroal probably knows how to handle that but can we be sure that other adaptors do too. You may argue that you have made it configurable, but the accompanying PR sets this behaviour globally so all resource types will be expected to handle the close correctly (and be expected to work with the application servers' connection management policies). Again, basically it is the app servers job to close connections. 3. A TM can have a connection to an RM via more than one resource adaptor and the 'XAResource#isSameRM' method is provided to tell the TM when that is the case. What effect will your closing of one of them have on the other resource adaptors that connect to the same RM? 4. Finally TMENDRSCAN is not to tell the resource adaptor that the scan has ended. It is the resource adaptors job to tell the TM when the scan has finished and it does that in 'int xa_recover(..)' by returning an int that the caller uses to determine whether the passed in array is full or not. If the caller did not supply a big enough array then the caller can keep calling the recover method until the cursor has reached the end of the list of prepared branches. The caller tells the resource to reset its cursor using the TMENDRSCAN flag. Remark: JTA is a layer over XA and is somewhat vague on the usage of this flag, in fact the spec does not even discuss it. I would expect it is never used since in a Java environment the resource returns a Java array from the recover call whereas in the XA API the caller supplies the array. I think this issue should be discussed within the community before making the change. > Create a way to close XAResource at the end of the recovery cycle processing > ---------------------------------------------------------------------------- > > Key: JBTM-3325 > URL: https://issues.redhat.com/browse/JBTM-3325 > Project: JBoss Transaction Manager > Issue Type: Enhancement > Components: JTA > Affects Versions: 5.10.5.Final > Reporter: Ondrej Chaloupka > Assignee: Ondrej Chaloupka > Priority: Major > > From discussions about Narayana integration to Agroal (https://agroal.github.io/) there came an idea how to make easier for Agroal to integrate with Narayana recovery processing. > Usually (or at least Agroal does so) the brand new {{XAResource}} is provided from the call of the {{XAResourceRecovery}} (https://github.com/jbosstm/jboss-transaction-spi/blob/7.6.0.Final/src/mai...). > aka. Agroal implements the {{XAResourceRecovery}} and register it with the Narayana with adding it to with https://github.com/jbosstm/jboss-transaction-spi/blob/7.6.0.Final/src/mai... to be used in {{XARecoveryModule}}. > When the periodic recovery cycle ends the {{XAResource}} is not used (next time the recovery processing calls the {{XAResourceRecovery#getXAResources()}} to get the resource for scanning again). The transaction manager announces that the scan ended with call {{XAResource.recover(XAResource.TMENDRSCAN)}} (this is an internal to how Narayana works). > It would be beneficial provide an option that Narayana closes {{XAResource}}s at the end of the recovery cycle when Narayana does not plan to use it again. > The idea is to check if the {{XAResource}} is {{AutoCloseable}} and if so then the {{XAResource}} is closed at the end of the recovery cycle processing. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3320) LRA forget calls for nested completed participants are not repeated and do not close the LRA

by Martin Stefanko (Jira)

[ https://issues.redhat.com/browse/JBTM-3320?page=com.atlassian.jira.plugin... ] Martin Stefanko updated JBTM-3320: ---------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done > LRA forget calls for nested completed participants are not repeated and do not close the LRA > -------------------------------------------------------------------------------------------- > > Key: JBTM-3320 > URL: https://issues.redhat.com/browse/JBTM-3320 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.10.5.Final > Reporter: Martin Stefanko > Assignee: Martin Stefanko > Priority: Major > > forgetAllParticipants does not repeat failed forget calls and if the calls are successful the nested LRA is not finished. This leaves the nested LRA active. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3323) LRA server filter is registered twice

by Martin Stefanko (Jira)

[ https://issues.redhat.com/browse/JBTM-3323?page=com.atlassian.jira.plugin... ] Martin Stefanko updated JBTM-3323: ---------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done > LRA server filter is registered twice > ------------------------------------- > > Key: JBTM-3323 > URL: https://issues.redhat.com/browse/JBTM-3323 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.10.5.Final > Reporter: Michael Musgrove > Assignee: Martin Stefanko > Priority: Critical > Fix For: 5.next > > > The LRA ServerLRAFilter is being registered twice, once implicitly because ServerLRAFilter is a Provider, and once explicitly in FilterRegistration. Resteasy ignores the second registration but this is not the case for other JAX-RS implementations such as Apache CXF and the endpoints may be registered twice. In particular this can result in 2 LRAs being created for the same client request. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3060) Enhance quickstart readme with summary of all quickstarts while sorting them into categories

by Ondrej Chaloupka (Jira)

[ https://issues.redhat.com/browse/JBTM-3060?page=com.atlassian.jira.plugin... ] Ondrej Chaloupka updated JBTM-3060: ----------------------------------- Git Pull Request: https://github.com/jbosstm/quickstart/pull/233 > Enhance quickstart readme with summary of all quickstarts while sorting them into categories > -------------------------------------------------------------------------------------------- > > Key: JBTM-3060 > URL: https://issues.redhat.com/browse/JBTM-3060 > Project: JBoss Transaction Manager > Issue Type: Enhancement > Reporter: Ondrej Chaloupka > Assignee: Ondrej Chaloupka > Priority: Minor > > The current README of the quickstart repository https://github.com/jbosstm/quickstart/blob/5.9.0.Final/README.md is a bit modest. Any stranger should get information about the overall structure of the repo while guiding him to find the quickstart he needs. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3325) Create a way to close XAResource at the end of the recovery cycle processing

by Ondrej Chaloupka (Jira)

[ https://issues.redhat.com/browse/JBTM-3325?page=com.atlassian.jira.plugin... ] Ondrej Chaloupka updated JBTM-3325: ----------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/jbosstm/narayana/pull/1631 > Create a way to close XAResource at the end of the recovery cycle processing > ---------------------------------------------------------------------------- > > Key: JBTM-3325 > URL: https://issues.redhat.com/browse/JBTM-3325 > Project: JBoss Transaction Manager > Issue Type: Enhancement > Components: JTA > Affects Versions: 5.10.5.Final > Reporter: Ondrej Chaloupka > Assignee: Ondrej Chaloupka > Priority: Major > > From discussions about Narayana integration to Agroal (https://agroal.github.io/) there came an idea how to make easier for Agroal to integrate with Narayana recovery processing. > Usually (or at least Agroal does so) the brand new {{XAResource}} is provided from the call of the {{XAResourceRecovery}} (https://github.com/jbosstm/jboss-transaction-spi/blob/7.6.0.Final/src/mai...). > aka. Agroal implements the {{XAResourceRecovery}} and register it with the Narayana with adding it to with https://github.com/jbosstm/jboss-transaction-spi/blob/7.6.0.Final/src/mai... to be used in {{XARecoveryModule}}. > When the periodic recovery cycle ends the {{XAResource}} is not used (next time the recovery processing calls the {{XAResourceRecovery#getXAResources()}} to get the resource for scanning again). The transaction manager announces that the scan ended with call {{XAResource.recover(XAResource.TMENDRSCAN)}} (this is an internal to how Narayana works). > It would be beneficial provide an option that Narayana closes {{XAResource}}s at the end of the recovery cycle when Narayana does not plan to use it again. > The idea is to check if the {{XAResource}} is {{AutoCloseable}} and if so then the {{XAResource}} is closed at the end of the recovery cycle processing. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3326) Nested participant AfterLRA call in complete scenario should be postponed until the parent LRA completes/compensates

by Martin Stefanko (Jira)

Martin Stefanko created JBTM-3326: ------------------------------------- Summary: Nested participant AfterLRA call in complete scenario should be postponed until the parent LRA completes/compensates Key: JBTM-3326 URL: https://issues.redhat.com/browse/JBTM-3326 Project: JBoss Transaction Manager Issue Type: Bug Components: LRA Affects Versions: 5.10.4.Final Reporter: Martin Stefanko Assignee: Martin Stefanko Currently, the nested participant enters the H_H state after it completes and the recovery calls the after LRA method in the first pass. This call should be postponed until the parent LRA finishes. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3325) Create a way to close XAResource at the end of the recovery cycle processing

by Ondrej Chaloupka (Jira)

Ondrej Chaloupka created JBTM-3325: -------------------------------------- Summary: Create a way to close XAResource at the end of the recovery cycle processing Key: JBTM-3325 URL: https://issues.redhat.com/browse/JBTM-3325 Project: JBoss Transaction Manager Issue Type: Enhancement Components: JTA Affects Versions: 5.10.5.Final Reporter: Ondrej Chaloupka Assignee: Ondrej Chaloupka >From discussions about Narayana integration to Agroal (https://agroal.github.io/) there came an idea how to make easier for Agroal to integrate with Narayana recovery processing. Usually (or at least Agroal does so) the brand new {{XAResource}} is provided from the call of the {{XAResourceRecovery}} (https://github.com/jbosstm/jboss-transaction-spi/blob/7.6.0.Final/src/mai...). aka. Agroal implements the {{XAResourceRecovery}} and register it with the Narayana with adding it to with https://github.com/jbosstm/jboss-transaction-spi/blob/7.6.0.Final/src/mai... to be used in {{XARecoveryModule}}. When the periodic recovery cycle ends the {{XAResource}} is not used (next time the recovery processing calls the {{XAResourceRecovery#getXAResources()}} to get the resource for scanning again). The transaction manager announces that the scan ended with call {{XAResource.recover(XAResource.TMENDRSCAN)}} (this is an internal to how Narayana works). It would be beneficial provide an option that Narayana closes {{XAResource}}s at the end of the recovery cycle when Narayana does not plan to use it again. The idea is to check if the {{XAResource}} is {{AutoCloseable}} and if so then the {{XAResource}} is closed at the end of the recovery cycle processing. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

jbossts-issues June 2020