July 2020 - jbossts-issues - Jboss List Archives

[JBoss JIRA] (JBTM-3308) Some TCK tests pass but leave the LRAs in not finished state

by Martin Stefanko (Jira)

[ https://issues.redhat.com/browse/JBTM-3308?page=com.atlassian.jira.plugin... ] Martin Stefanko resolved JBTM-3308. ----------------------------------- Resolution: Done > Some TCK tests pass but leave the LRAs in not finished state > ------------------------------------------------------------ > > Key: JBTM-3308 > URL: https://issues.redhat.com/browse/JBTM-3308 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.10.4.Final > Reporter: Martin Stefanko > Assignee: Martin Stefanko > Priority: Major > > It seems that the LRA is correctly closed but the /lra-coordinator still reports it in Active status. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 9 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3341) Failed LRA is not kept in FailedTo* state in the object store

by Martin Stefanko (Jira)

[ https://issues.redhat.com/browse/JBTM-3341?page=com.atlassian.jira.plugin... ] Martin Stefanko updated JBTM-3341: ---------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done > Failed LRA is not kept in FailedTo* state in the object store > ------------------------------------------------------------- > > Key: JBTM-3341 > URL: https://issues.redhat.com/browse/JBTM-3341 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.10.4.Final > Reporter: Martin Stefanko > Assignee: Martin Stefanko > Priority: Major > > when executing {{TckContextTests#testStatus,TckContextTests#testForget}} one after another the LRA started in testForget is kept in Closing state in object store even when it's removed from the in memory LRA lists. When the testStatus invokes recovery this LRA is also recovered (because it's still in Closing state) and then it's kept even in the in memory recovery list and again displayed to users. The testForget LRA is finished with failing participant (returning FailedToComplete) and the second phase correctly returns FINISH_ERROR, however, this change needs to be also reflected in the state of the parent Transaction object. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 9 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3344) Remove Thorntail as LRA runtime

by Michael Musgrove (Jira)

[ https://issues.redhat.com/browse/JBTM-3344?page=com.atlassian.jira.plugin... ] Michael Musgrove commented on JBTM-3344: ---------------------------------------- We should deprecate for at least one release first and then remove it in the one after that. > Remove Thorntail as LRA runtime > ------------------------------- > > Key: JBTM-3344 > URL: https://issues.redhat.com/browse/JBTM-3344 > Project: JBoss Transaction Manager > Issue Type: Task > Components: LRA > Reporter: Ondrej Chaloupka > Priority: Major > > The LRA provides the runner for Thorntail runtime. The Thorntail is being abandoned for Quarkus. > The LRA may stop to provide the Thorntail runner and it could stop to use it in tests. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 9 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3344) Remove Thorntail as LRA runtime

by Ondrej Chaloupka (Jira)

Ondrej Chaloupka created JBTM-3344: -------------------------------------- Summary: Remove Thorntail as LRA runtime Key: JBTM-3344 URL: https://issues.redhat.com/browse/JBTM-3344 Project: JBoss Transaction Manager Issue Type: Task Components: LRA Reporter: Ondrej Chaloupka The LRA provides the runner for Thorntail runtime. The Thorntail is being abandoned for Quarkus. The LRA may stop to provide the Thorntail runner and it could stop to use it in tests. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 9 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3343) Integration LRA tests need to be runnable on all runtimes

by Ondrej Chaloupka (Jira)

[ https://issues.redhat.com/browse/JBTM-3343?page=com.atlassian.jira.plugin... ] Ondrej Chaloupka updated JBTM-3343: ----------------------------------- Summary: Integration LRA tests need to be runnable on all runtimes (was: Integration LRA tests need to be run on all runtimes) > Integration LRA tests need to be runnable on all runtimes > --------------------------------------------------------- > > Key: JBTM-3343 > URL: https://issues.redhat.com/browse/JBTM-3343 > Project: JBoss Transaction Manager > Issue Type: Enhancement > Components: LRA > Affects Versions: 5.10.4.Final > Reporter: Ondrej Chaloupka > Assignee: Ondrej Chaloupka > Priority: Critical > > The LRA integration testing is currently split to two parts. The Narayana byteman recovery testing is run only with WildFly runtime while the TCK and other integration tests are run with combination of Qurakus/Thorntail. > The goal of this issue is to change the structure of the LRA integration tests to run with all available runtimes. Currently we have Quarkus, WildFly and Thorntail. > The integration tests need be runnable against the all runtimes. > NOTE: The Thorntail is eprecated and will be removed from the LRA. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 9 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3343) Integration LRA tests need to be run on all runtimes

by Ondrej Chaloupka (Jira)

Ondrej Chaloupka created JBTM-3343: -------------------------------------- Summary: Integration LRA tests need to be run on all runtimes Key: JBTM-3343 URL: https://issues.redhat.com/browse/JBTM-3343 Project: JBoss Transaction Manager Issue Type: Enhancement Components: LRA Affects Versions: 5.10.4.Final Reporter: Ondrej Chaloupka Assignee: Ondrej Chaloupka The LRA integration testing is currently split to two parts. The Narayana byteman recovery testing is run only with WildFly runtime while the TCK and other integration tests are run with combination of Qurakus/Thorntail. The goal of this issue is to change the structure of the LRA integration tests to run with all available runtimes. Currently we have Quarkus, WildFly and Thorntail. The integration tests need be runnable against the all runtimes. NOTE: The Thorntail is eprecated and will be removed from the LRA. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 9 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3331) LRA end should not return internal server error when precondition fails as it's considered behaviour by spec

by Ondrej Chaloupka (Jira)

[ https://issues.redhat.com/browse/JBTM-3331?page=com.atlassian.jira.plugin... ] Ondrej Chaloupka commented on JBTM-3331: ---------------------------------------- [~mmusgrov] thanks, that helped. I was thinking about such solution but I was a bit unsure. > LRA end should not return internal server error when precondition fails as it's considered behaviour by spec > ------------------------------------------------------------------------------------------------------------ > > Key: JBTM-3331 > URL: https://issues.redhat.com/browse/JBTM-3331 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.10.5.Final > Reporter: Ondrej Chaloupka > Assignee: Ondrej Chaloupka > Priority: Critical > > I've spent some time with https://issues.redhat.com/browse/JBTM-3318 recently and I have a doubt about behaviour of the LRA. The JBTM-3318 consists of race condition on starting/enlisting/timeouting the LRA. > The same issue makes failing the `TckTests#timeLimit` and `TckRecoveryTests#testCancelWhenParticipantIsUnavailable` on our slow AMS CI. > I don't want to talk now about the TCK failure but about the related behaviour of the Narayana implementation. > The LRA participant defines the {{timeLimit}} (https://github.com/eclipse/microprofile-lra/blob/1.0-M1/tck/src/main/java...). > And what happens is that the client (TCK test) calls the LRA method, the JAX-RS filter starts a LRA on coordinator, meanwhile the timeout limit elapses, the JAX-RS filter tries to enlist the LRA participant to started LRA but it fails as the LRA was cancelled because of timeout. > Now. The possible non-deterministic Narayana behaviour is that in case of failure on LRA participant enlistment the client may or may not get internal server error. > It's because the LRA in timeouted state on client is tried to be cancelled (see https://github.com/jbosstm/narayana/blob/5.10.5.Final/rts/lra/lra-client/...). > The {{NarayanaLRAClient#endLRA}} tries to cancel the LRA. But as the coordinator timeouted the LRA then now depends if recovery already removed the LRA or not. If the LRA was not removed yet then {{412, PRECONDITION FAILED}} is returned. If the recovery made it then {{404, NOT FOUDN}} is returned. > Now the {{endLRA}} considers the {{404}} as not a failure that is considered as {{500, INTERNAL SERVER ERROR}} while the {{412, PRECONDITION FAILED}} is considered as internal server error. That should not be that way as the LRA spec considers {{412}} as "correct" error (see https://github.com/eclipse/microprofile-lra/blob/1.0-M1/api/src/main/java...). > Such an anticipated return state should not be reported to client as {{500}} - {{internal server error}}. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 9 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3331) LRA end should not return internal server error when precondition fails as it's considered behaviour by spec

by Michael Musgrove (Jira)

[ https://issues.redhat.com/browse/JBTM-3331?page=com.atlassian.jira.plugin... ] Michael Musgrove commented on JBTM-3331: ---------------------------------------- If the LRA has gone we used to return 404 NOT_FOUND. But the spec was changed to also allow returning Response.Status.GONE and Response.Status.PRECONDITION_FAILED. So we just need to include those two codes in the list of expected response codes for a join request. > LRA end should not return internal server error when precondition fails as it's considered behaviour by spec > ------------------------------------------------------------------------------------------------------------ > > Key: JBTM-3331 > URL: https://issues.redhat.com/browse/JBTM-3331 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.10.5.Final > Reporter: Ondrej Chaloupka > Assignee: Ondrej Chaloupka > Priority: Critical > > I've spent some time with https://issues.redhat.com/browse/JBTM-3318 recently and I have a doubt about behaviour of the LRA. The JBTM-3318 consists of race condition on starting/enlisting/timeouting the LRA. > The same issue makes failing the `TckTests#timeLimit` and `TckRecoveryTests#testCancelWhenParticipantIsUnavailable` on our slow AMS CI. > I don't want to talk now about the TCK failure but about the related behaviour of the Narayana implementation. > The LRA participant defines the {{timeLimit}} (https://github.com/eclipse/microprofile-lra/blob/1.0-M1/tck/src/main/java...). > And what happens is that the client (TCK test) calls the LRA method, the JAX-RS filter starts a LRA on coordinator, meanwhile the timeout limit elapses, the JAX-RS filter tries to enlist the LRA participant to started LRA but it fails as the LRA was cancelled because of timeout. > Now. The possible non-deterministic Narayana behaviour is that in case of failure on LRA participant enlistment the client may or may not get internal server error. > It's because the LRA in timeouted state on client is tried to be cancelled (see https://github.com/jbosstm/narayana/blob/5.10.5.Final/rts/lra/lra-client/...). > The {{NarayanaLRAClient#endLRA}} tries to cancel the LRA. But as the coordinator timeouted the LRA then now depends if recovery already removed the LRA or not. If the LRA was not removed yet then {{412, PRECONDITION FAILED}} is returned. If the recovery made it then {{404, NOT FOUDN}} is returned. > Now the {{endLRA}} considers the {{404}} as not a failure that is considered as {{500, INTERNAL SERVER ERROR}} while the {{412, PRECONDITION FAILED}} is considered as internal server error. That should not be that way as the LRA spec considers {{412}} as "correct" error (see https://github.com/eclipse/microprofile-lra/blob/1.0-M1/api/src/main/java...). > Such an anticipated return state should not be reported to client as {{500}} - {{internal server error}}. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 9 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3342) LRA annotated method should expose the parent context header

by Michael Musgrove (Jira)

[ https://issues.redhat.com/browse/JBTM-3342?page=com.atlassian.jira.plugin... ] Michael Musgrove updated JBTM-3342: ----------------------------------- Description: When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [LRA_HTTP_ENDED_CONTEXT_HEADER|http://example.com/] http header. (was: When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [LRA_HTTP_ENDED_CONTEXT_HEADER|http://example.com/]_ http header.) > LRA annotated method should expose the parent context header > ------------------------------------------------------------ > > Key: JBTM-3342 > URL: https://issues.redhat.com/browse/JBTM-3342 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.10.5.Final > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Major > Fix For: 5.next > > > When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [LRA_HTTP_ENDED_CONTEXT_HEADER|http://example.com/] http header. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 9 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3342) LRA annotated method should expose the parent context header

by Michael Musgrove (Jira)

[ https://issues.redhat.com/browse/JBTM-3342?page=com.atlassian.jira.plugin... ] Michael Musgrove updated JBTM-3342: ----------------------------------- Description: When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [LRA_HTTP_ENDED_CONTEXT_HEADER|http://example.com/]_ http header. (was: When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [LRA_HTTP_ENDED_CONTEXT_HEADER|http://example.com]_] http header.) > LRA annotated method should expose the parent context header > ------------------------------------------------------------ > > Key: JBTM-3342 > URL: https://issues.redhat.com/browse/JBTM-3342 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.10.5.Final > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Major > Fix For: 5.next > > > When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [LRA_HTTP_ENDED_CONTEXT_HEADER|http://example.com/]_ http header. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 9 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

jbossts-issues July 2020