[jbossts-issues] [JBoss JIRA] Commented: (JBTM-103) Unify default transaction timeout values

[ http://jira.jboss.com/jira/browse/JBTM-103?page=comments#action_12368229 ] Mark Little commented on JBTM-103: ---------------------------------- In ArjunaJTA BaseTransaction.begin: Integer value = (Integer) _timeouts.get(ThreadUtil.getThreadId()); int v = 0; // if not set then assume 0. What else can we do? if (value != null) { v = value.intValue(); } // TODO set default timeout which doesn't exist in the JTAX BaseTransaction, because that relies on the JTS Current object to manage timeouts, which pulls the default from the JTS property and not the ArjunaCore property (check relevant Environment.java classes to see what I mean). The JTA and JTS implementations should both use the Core definition of default transaction timeout. At the moment, if someone wants to set a default timeout for JTA transactions, that should be used if no explicit timeout is defined, they can only do so via the JTS implementation. Plus, they'd need to make sure the JTS value is the same as the Core value if they want to mix and match transaction implementations (not likely in reality). We should have only a single place to set the default transaction timeout, and this value should be used when no timeout is explicitly defined. A value of 0 or -1 should be taken as "no timeout", i.e., infinite. JTS TransactionFactory does this already: int theTimeout = time_out; if (theTimeout == 0) theTimeout = TransactionFactoryImple._defaultTimeout; and _defaultTimeout could be 0. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira